Use generators instead of list comprehension

To make tasks faster and more memory-efficient.

For example (Notification.id.in_(n.id for n in notifications) is twice
as fast as a generator than it is as a list comprehension.

Generators are also more memory efficient.

Author: CrystalPea

app/dao/notifications_dao.py

@@ -579,7 +579,7 @@ def dao_timeout_notifications(cutoff_time, limit=100000):
     )
 
     Notification.query.filter(
-        Notification.id.in_([n.id for n in notifications]),
+        Notification.id.in_(n.id for n in notifications),
     ).update({"status": new_status, "updated_at": updated_at}, synchronize_session=False)
 
     db.session.commit()
@@ -698,7 +698,7 @@ def dao_update_notifications_by_reference(references, update_dict):
 
 
 def dao_get_unknown_references(references):
-    v = values(column("reference", String), name="references").data([(r,) for r in references])
+    v = values(column("reference", String), name="references").data((r,) for r in references)
 
     return (
         db.session.execute(

app/dao/services_dao.py

@@ -410,7 +410,7 @@ def _delete(query):
     _delete(ApiKey.get_history_model().query.filter_by(service_id=service.id))
     _delete(AnnualBilling.query.filter_by(service_id=service.id))
 
-    verify_codes = VerifyCode.query.join(User).filter(User.id.in_([x.id for x in service.users]))
+    verify_codes = VerifyCode.query.join(User).filter(User.id.in_(x.id for x in service.users))
     list(map(db.session.delete, verify_codes))
     users = list(service.users)
     for user in users: