Merge pull request #4765 from alphagov/BC-ses-stub-fix

corlettb · web-flow · commit 76d8481eb91e · 2026-03-13T08:33:13.000Z
Fix SES stub logging TypeError in Celery workers.
diff --git a/app/clients/email/aws_ses_stub.py b/app/clients/email/aws_ses_stub.py
@@ -49,7 +49,7 @@ def send_email(
         else:
             elapsed_time = monotonic() - start_time
             current_app.logger.info(
-                "AWS SES stub request finished in %.4g seconds", elapsed_time, {"duration": elapsed_time}
+                "AWS SES stub request finished in %.4g seconds", elapsed_time, extra={"duration": elapsed_time}
             )
             self.statsd_client.timing("clients.ses_stub.request-time", elapsed_time)
             self.statsd_client.incr("clients.ses_stub.success")

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ def send_email(`
`49`	`49`	`else:`
`50`	`50`	`elapsed_time = monotonic() - start_time`
`51`	`51`	`current_app.logger.info(`
`52`		`- "AWS SES stub request finished in %.4g seconds", elapsed_time, {"duration": elapsed_time}`
	`52`	`+ "AWS SES stub request finished in %.4g seconds", elapsed_time, extra={"duration": elapsed_time}`
`53`	`53`	`)`
`54`	`54`	`self.statsd_client.timing("clients.ses_stub.request-time", elapsed_time)`
`55`	`55`	`self.statsd_client.incr("clients.ses_stub.success")`