switch dashboard queries to use new bulk DB session

This change routes dashboard queries to the new 'bulk' database via the . We are starting with the dashboards as the first real-world test of the replica connection. This is a low-risk change that can be easily rolled back if users see any issues.

Author: spatel033

app/dao/fact_notification_status_dao.py

@@ -135,10 +135,12 @@ def fetch_notification_status_for_service_for_day(bst_day, service_id):
     )
 
 
-def fetch_notification_status_for_service_for_today_and_7_previous_days(service_id, by_template=False, limit_days=7):
+def fetch_notification_status_for_service_for_today_and_7_previous_days(
+    service_id, by_template=False, limit_days=7, session=db.session
+):
     start_date = midnight_n_days_ago(limit_days)
     now = datetime.utcnow()
-    stats_for_7_days = db.session.query(
+    stats_for_7_days = session.query(
         FactNotificationStatus.notification_type.label("notification_type"),
         FactNotificationStatus.notification_status.label("status"),
         *([FactNotificationStatus.template_id.label("template_id")] if by_template else []),
@@ -150,7 +152,7 @@ def fetch_notification_status_for_service_for_today_and_7_previous_days(service_
     )
 
     stats_for_today = (
-        db.session.query(
+        session.query(
             Notification.notification_type.cast(db.Text),
             Notification.status,
             *([Notification.template_id] if by_template else []),
@@ -169,7 +171,7 @@ def fetch_notification_status_for_service_for_today_and_7_previous_days(service_
     all_stats_table = stats_for_7_days.union_all(stats_for_today).subquery()
 
     aggregation = (
-        db.session.query(
+        session.query(
             *([all_stats_table.c.template_id] if by_template else []),
             all_stats_table.c.notification_type,
             all_stats_table.c.status,
@@ -183,7 +185,7 @@ def fetch_notification_status_for_service_for_today_and_7_previous_days(service_
         .subquery()
     )
 
-    query = db.session.query(
+    query = session.query(
         *(
             [Template.name.label("template_name"), Template.is_precompiled_letter, aggregation.c.template_id]
             if by_template

app/template_statistics/rest.py

@@ -1,5 +1,6 @@
 from flask import Blueprint, jsonify, request
 
+from app import db
 from app.dao.fact_notification_status_dao import (
     fetch_notification_status_for_service_for_today_and_7_previous_days,
 )
@@ -26,7 +27,7 @@ def get_template_statistics_for_service_by_day(service_id):
     if whole_days < 0 or whole_days > 7:
         raise InvalidRequest({"whole_days": ["whole_days must be between 0 and 7"]}, status_code=400)
     data = fetch_notification_status_for_service_for_today_and_7_previous_days(
-        service_id, by_template=True, limit_days=whole_days
+        service_id, by_template=True, limit_days=whole_days, session=db.session_bulk
     )
 
     return jsonify(

tests/app/dao/test_fact_notification_status_dao.py

@@ -5,6 +5,7 @@
 import pytest
 from freezegun import freeze_time
 
+from app import db
 from app.constants import (
     EMAIL_TYPE,
     KEY_TYPE_TEAM,
@@ -41,6 +42,7 @@
     create_service,
     create_template,
 )
+from tests.utils import QueryRecorder
 
 
 def test_fetch_notification_status_for_service_by_month(notify_db_session):
@@ -134,7 +136,16 @@ def test_fetch_notification_status_for_service_for_day(notify_db_session):
 
 
 @freeze_time("2018-10-31T18:00:00")
-def test_fetch_notification_status_for_service_for_today_and_7_previous_days(notify_db_session):
+@pytest.mark.parametrize(
+    "sess,expected_bind_key",
+    (
+        (db.session, None),
+        (db.session_bulk, "bulk"),
+    ),
+)
+def test_fetch_notification_status_for_service_for_today_and_7_previous_days(
+    notify_db_session, sess, expected_bind_key
+):
     service_1 = create_service(service_name="service_1")
     sms_template = create_template(service=service_1, template_type=SMS_TYPE)
     sms_template_2 = create_template(service=service_1, template_type=SMS_TYPE)
@@ -154,10 +165,14 @@ def test_fetch_notification_status_for_service_for_today_and_7_previous_days(not
     # too early, shouldn't be included
     create_notification(service_1.templates[0], created_at=datetime(2018, 10, 30, 12, 0, 0), status="delivered")
 
-    results = sorted(
-        fetch_notification_status_for_service_for_today_and_7_previous_days(service_1.id),
-        key=lambda x: (x.notification_type, x.status),
-    )
+    service_id = service_1.id
+    with QueryRecorder() as query_recorder:
+        results = sorted(
+            fetch_notification_status_for_service_for_today_and_7_previous_days(service_id=service_id, session=sess),
+            key=lambda x: (x.notification_type, x.status),
+        )
+
+    assert {query_info.bind_key for query_info in query_recorder.queries} == {expected_bind_key}
 
     assert len(results) == 4
 

tests/app/template_statistics/test_rest.py

@@ -62,7 +62,9 @@ def test_get_template_statistics_for_service_by_day_accepts_old_query_string(
 
 
 @freeze_time("2018-01-02 12:00:00")
-def test_get_template_statistics_for_service_by_day_goes_to_db(admin_request, mocker, sample_template):
+def test_get_template_statistics_for_service_by_day_goes_to_db(
+    admin_request, mocker, sample_template, notify_db_session_bulk
+):
     # first time it is called redis returns data, second time returns none
     mock_dao = mocker.patch(
         "app.template_statistics.rest.fetch_notification_status_for_service_for_today_and_7_previous_days",
@@ -94,7 +96,9 @@ def test_get_template_statistics_for_service_by_day_goes_to_db(admin_request, mo
         }
     ]
     # dao only called for 2nd, since redis returned values for first call
-    mock_dao.assert_called_once_with(str(sample_template.service_id), limit_days=1, by_template=True)
+    mock_dao.assert_called_once_with(
+        str(sample_template.service_id), limit_days=1, by_template=True, session=notify_db_session_bulk
+    )
 
 
 def test_get_template_statistics_for_service_by_day_returns_empty_list_if_no_templates(