Skip to content

Commit adfecac

Browse files
Fix rubocop offenses
1 parent 2495b6d commit adfecac

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010

1111
strategy:
1212
matrix:
13-
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3']
13+
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
1414
fail-fast: false
1515

1616
steps:

.rubocop.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,9 @@ Style/MethodCallWithArgsParentheses:
121121
Style/HashTransformKeys:
122122
Enabled: false
123123

124+
Naming/PredicateMethod:
125+
Enabled: false
126+
124127
Style/HashTransformValues:
125128
Enabled: false
126129

lib/redmine_plugin_kit/helpers/global_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def link_to_url(url, **options)
1515
return if url.blank?
1616

1717
parts = url.split '://'
18-
name = if parts.count.positive?
18+
name = if parts.any?
1919
parts.shift
2020
parts.join.chomp '/'
2121
else

test/units/loader_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def test_require_files_for_lib
8686
spec = File.join 'wiki_macros', '**/*_macro.rb'
8787
files = loader.require_files spec
8888

89-
assert files.count.positive?
89+
assert files.any?
9090
assert(files.detect { |file| file.include? 'test_macro' })
9191
end
9292

@@ -102,7 +102,7 @@ def test_require_files_for_app
102102
spec = File.join 'helpers', "**/#{@plugin_id}_*.rb"
103103
files = loader.require_files spec, use_app: true
104104

105-
assert files.count.positive?
105+
assert files.any?
106106
assert(files.detect { |file| file.include? 'redmine_test_plugin_settings_helper' })
107107
end
108108

@@ -157,7 +157,7 @@ def test_load_macros
157157
loader = RedminePluginKit::Loader.new plugin_id: @plugin_id
158158
macros = loader.load_macros!
159159

160-
assert macros.count.positive?
160+
assert macros.any?
161161
assert(macros.detect { |macro| macro.include? 'test_macro' })
162162
end
163163
end

0 commit comments

Comments
 (0)