Fix alpine v3 crash (#262)

HugoDF · web-flow · commit 18187d239389 · 2021-06-29T17:48:52.000Z
* optional chaining on window.Alpine.version

* use optional chaining to read alpine version
diff --git a/packages/shell-chrome/src/backend.js b/packages/shell-chrome/src/backend.js
@@ -45,9 +45,14 @@ function init() {
 
             this._stopMutationObserver = false
             this._lastComponentCrawl = Date.now()
+        }
+
+        get alpineVersion() {
+            return window?.Alpine?.version || ''
+        }
 
-            this.alpineVersion = window.Alpine.version
-            this.isV3 = isRequiredVersion('3.0.0', this.alpineVersion)
+        get isV3() {
+            return isRequiredVersion('3.0.0', this.alpineVersion)
         }
 
         runWithMutationPaused(cb) {
@@ -105,6 +110,7 @@ function init() {
                 return
             }
             if (isRequiredVersion('2.8.1', this.alpineVersion)) {
+                console.log('aaa')
                 window.addEventListener('error', (errorEvent) => {
                     if (errorEvent.error && errorEvent.error.el && errorEvent.error.expression) {
                         const { el, expression } = errorEvent.error
diff --git a/packages/simulator/navigation-target.html b/packages/simulator/navigation-target.html
@@ -6,7 +6,8 @@
         <!-- <script src="https://cdn.jsdelivr.net/gh/alpinejs/alpine@v2.x.x/dist/alpine.min.js" defer></script> -->
         <!-- Rollup server is configured to serve contents of node_modules/alpinejs/dist, see rollup.config.js -->
         <!-- Uncomment the following script to use that version, eg. when working offline -->
-        <script src="/alpine.js" defer></script>
+        <!-- <script src="/alpine.js" defer></script> -->
+        <script defer src="https://unpkg.com/alpinejs@3.x.x/dist/cdn.min.js"></script>
     </head>
 
     <body>
