cleanup not called when ancestor element removed #1567
-
|
version: 3.0.8 examples: |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
Good catch, there needs to be a more robust system that walks a removed element's children and cleans them up as well. |
Beta Was this translation helpful? Give feedback.
-
|
Currently, there are WeakMaps of elements and their cleanup functions - instead I think a better system would be attaching the cleanup functions directly to the dom nodes and running them as we walk |
Beta Was this translation helpful? Give feedback.
-
|
Fixed in this PR: #1569 Will be in the next release 👌 |
Beta Was this translation helpful? Give feedback.
Good catch, there needs to be a more robust system that walks a removed element's children and cleans them up as well.