You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
This is related to #2126 -- but different enough to warrant its own issue.
This issue covers two different leaks, but they're closely related.
Both are demonstrated here with reference to possible patches:
https://alpine-testlab.netlify.app/leak2-magic/
injectMagics holds a reference to el that never gets released
I have tested with this patch bep@6c14dfc -- which works for my simple test case, but I notice that
injectMagics
is also used elsewhere.magics' effects, e.g. in $watch, is never released
Which becomes a problem when they hold a reference to a DOM element (which they often do).
I have tested this patch: bep@9dfe0c4
That works. However, it only works for
$watch
and it may make the making of custom `magics´ harder than it should.Beta Was this translation helpful? Give feedback.
All reactions