Skip to content

Commit f6dce4f

Browse files
committed
ucm: remove 'error: ' prefix from error messages (duplication)
Signed-off-by: Jaroslav Kysela <[email protected]>
1 parent 953ce1f commit f6dce4f

File tree

2 files changed

+78
-111
lines changed

2 files changed

+78
-111
lines changed

src/ucm/main.c

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -692,13 +692,13 @@ static int run_device_sequence(snd_use_case_mgr_t *uc_mgr, struct use_case_verb
692692
snd_trace(UCM, "device sequence '%s/%s': %s", verb->name, name, uc_mgr_enable_str(enable));
693693

694694
if (verb == NULL) {
695-
snd_error(UCM, "error: enadev2 / disdev2 must be executed inside the verb context");
695+
snd_error(UCM, "enadev2 / disdev2 must be executed inside the verb context");
696696
return -ENOENT;
697697
}
698698

699699
device = find_device(uc_mgr, verb, name, 0);
700700
if (device == NULL) {
701-
snd_error(UCM, "error: unable to find device '%s'\n", name);
701+
snd_error(UCM, "unable to find device '%s'\n", name);
702702
return -ENOENT;
703703
}
704704

@@ -718,7 +718,7 @@ static int run_device_all_sequence(snd_use_case_mgr_t *uc_mgr, struct use_case_v
718718
snd_trace(UCM, "disable all devices sequence for '%s'", verb->name);
719719

720720
if (verb == NULL) {
721-
snd_error(UCM, "error: disdevall must be executed inside the verb context");
721+
snd_error(UCM, "disdevall must be executed inside the verb context");
722722
return -ENOENT;
723723
}
724724

@@ -758,7 +758,7 @@ static int execute_sequence(snd_use_case_mgr_t *uc_mgr,
758758
int err = 0;
759759

760760
if (uc_mgr->sequence_hops > 100) {
761-
snd_error(UCM, "error: too many inner sequences!");
761+
snd_error(UCM, "too many inner sequences!");
762762
return -EINVAL;
763763
}
764764
uc_mgr->sequence_hops++;
@@ -1500,7 +1500,7 @@ const char *parse_open_variables(snd_use_case_mgr_t *uc_mgr, const char *name)
15001500

15011501
err = snd_config_load_string(&cfg, args, 0);
15021502
if (err < 0) {
1503-
snd_error(UCM, "error: open arguments are not valid (%s)", args);
1503+
snd_error(UCM, "open arguments are not valid (%s)", args);
15041504
goto skip;
15051505
}
15061506

@@ -1573,15 +1573,15 @@ int snd_use_case_mgr_open(snd_use_case_mgr_t **uc_mgr,
15731573
if (err < 0) {
15741574
if (err == -ENXIO && mgr->suppress_nodev_errors)
15751575
goto _err;
1576-
snd_error(UCM, "error: failed to import %s use case configuration %d",
1576+
snd_error(UCM, "failed to import %s use case configuration %d",
15771577
card_name, err);
15781578

15791579
goto _err;
15801580
}
15811581

15821582
err = check_empty_configuration(mgr);
15831583
if (err < 0) {
1584-
snd_error(UCM, "error: failed to import %s (empty configuration)", card_name);
1584+
snd_error(UCM, "failed to import %s (empty configuration)", card_name);
15851585
goto _err;
15861586
}
15871587

@@ -1613,7 +1613,7 @@ int snd_use_case_mgr_reload(snd_use_case_mgr_t *uc_mgr)
16131613
/* reload all use cases */
16141614
err = import_master_config(uc_mgr);
16151615
if (err < 0) {
1616-
snd_error(UCM, "error: failed to reload use cases");
1616+
snd_error(UCM, "failed to reload use cases");
16171617
pthread_mutex_unlock(&uc_mgr->mutex);
16181618
return -EINVAL;
16191619
}
@@ -2480,7 +2480,7 @@ static int set_fixedboot_user(snd_use_case_mgr_t *uc_mgr,
24802480
int err;
24812481

24822482
if (value != NULL && *value) {
2483-
snd_error(UCM, "error: wrong value for _fboot (%s)", value);
2483+
snd_error(UCM, "wrong value for _fboot (%s)", value);
24842484
return -EINVAL;
24852485
}
24862486
if (list_empty(&uc_mgr->fixedboot_list))
@@ -2500,7 +2500,7 @@ static int set_boot_user(snd_use_case_mgr_t *uc_mgr,
25002500
int err;
25012501

25022502
if (value != NULL && *value) {
2503-
snd_error(UCM, "error: wrong value for _boot (%s)", value);
2503+
snd_error(UCM, "wrong value for _boot (%s)", value);
25042504
return -EINVAL;
25052505
}
25062506
if (list_empty(&uc_mgr->boot_list))
@@ -2518,7 +2518,7 @@ static int set_defaults_user(snd_use_case_mgr_t *uc_mgr,
25182518
const char *value)
25192519
{
25202520
if (value != NULL && *value) {
2521-
snd_error(UCM, "error: wrong value for _defaults (%s)", value);
2521+
snd_error(UCM, "wrong value for _defaults (%s)", value);
25222522
return -EINVAL;
25232523
}
25242524
return set_defaults(uc_mgr, false);
@@ -2581,8 +2581,7 @@ static int set_verb_user(snd_use_case_mgr_t *uc_mgr,
25812581
if (verb) {
25822582
err = set_verb(uc_mgr, verb, 1);
25832583
if (err < 0)
2584-
snd_error(UCM, "error: failed to initialize new use case: %s",
2585-
verb_name);
2584+
snd_error(UCM, "failed to initialize new use case: %s", verb_name);
25862585

25872586
}
25882587
return err;
@@ -2634,11 +2633,11 @@ static int switch_device(snd_use_case_mgr_t *uc_mgr,
26342633
if (uc_mgr->active_verb == NULL)
26352634
return -ENOENT;
26362635
if (device_status(uc_mgr, old_device) == 0) {
2637-
snd_error(UCM, "error: device %s not enabled", old_device);
2636+
snd_error(UCM, "device %s not enabled", old_device);
26382637
return -EINVAL;
26392638
}
26402639
if (device_status(uc_mgr, new_device) != 0) {
2641-
snd_error(UCM, "error: device %s already enabled", new_device);
2640+
snd_error(UCM, "device %s already enabled", new_device);
26422641
return -EINVAL;
26432642
}
26442643
xold = find_device(uc_mgr, uc_mgr->active_verb, old_device, 1);
@@ -2690,11 +2689,11 @@ static int switch_modifier(snd_use_case_mgr_t *uc_mgr,
26902689
if (uc_mgr->active_verb == NULL)
26912690
return -ENOENT;
26922691
if (modifier_status(uc_mgr, old_modifier) == 0) {
2693-
snd_error(UCM, "error: modifier %s not enabled", old_modifier);
2692+
snd_error(UCM, "modifier %s not enabled", old_modifier);
26942693
return -EINVAL;
26952694
}
26962695
if (modifier_status(uc_mgr, new_modifier) != 0) {
2697-
snd_error(UCM, "error: modifier %s already enabled", new_modifier);
2696+
snd_error(UCM, "modifier %s already enabled", new_modifier);
26982697
return -EINVAL;
26992698
}
27002699
xold = find_modifier(uc_mgr, uc_mgr->active_verb, old_modifier, 1);

0 commit comments

Comments
 (0)