NET:ETH:ALTERA: SM Ethernet 10G : Coverity fixes

Coverity minor fixes

Signed-off-by: Krishna Kumar S R <[email protected]>

Author: KrishnaSimmadhari

drivers/net/ethernet/altera/intel_fpga_eth_main.c

@@ -326,12 +326,12 @@ static int xtile_init_rx_buffer(struct intel_fpga_xtile_eth_private *priv,
 				struct altera_dma_buffer *rxbuffer,
 				int len)
 {
-       rxbuffer->skb = netdev_alloc_skb(priv->dev, len);
-       skb_reserve(rxbuffer->skb, SKB_DMA_REALIGN);
+	rxbuffer->skb = netdev_alloc_skb(priv->dev, len);
 
-       if (!rxbuffer->skb)
-                return -ENOMEM;
+	if (!rxbuffer->skb)
+		return -ENOMEM;
 
+	skb_reserve(rxbuffer->skb, SKB_DMA_REALIGN);
 	rxbuffer->dma_addr = dma_map_single(priv->device,
 					    rxbuffer->skb->data,
 					    len, DMA_FROM_DEVICE);
@@ -1576,15 +1576,16 @@ static int intel_fpga_xtile_validate(struct phylink_pcs *pcs,
 				      const struct phylink_link_state *state_validate)
 {
 	struct phylink_link_state *state = (struct phylink_link_state *)state_validate;
-	intel_fpga_xtile_eth_private *priv =
-		container_of(pcs, intel_fpga_xtile_eth_private, pcs);
+	intel_fpga_xtile_eth_private *priv = NULL;
+
+	if (!pcs)
+		return -EINVAL;
+
+	priv = container_of(pcs, intel_fpga_xtile_eth_private, pcs);
 
 	__ETHTOOL_DECLARE_LINK_MODE_MASK(mac_supported) = { 0, };
 	__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
 
-	if (!priv)
-		return -EINVAL;
-
 	if (state->interface != PHY_INTERFACE_MODE_NA &&
 	    state->interface != PHY_INTERFACE_MODE_10GKR &&
 	    state->interface != PHY_INTERFACE_MODE_10GBASER &&
@@ -1653,13 +1654,12 @@ static int intel_fpga_xtile_validate(struct phylink_pcs *pcs,
 static void intel_fpga_xtile_mac_pcs_get_state(struct phylink_pcs *pcs,
 					       struct phylink_link_state *state)
 {
+	if (!pcs)
+		return;
 	/* fixed speed for now */
 	intel_fpga_xtile_eth_private *priv =
 		container_of(pcs, intel_fpga_xtile_eth_private, pcs);
 
-	if (!priv)
-		return;
-
 	state->speed = priv->link_speed;
 	state->duplex = DUPLEX_FULL;
 	state->link = 1;
@@ -2135,8 +2135,8 @@ static int intel_fpga_xtile_probe(struct platform_device *pdev)
         ret  = of_property_read_string(pdev->dev.of_node, "if_name",
                                        &if_name);
 
-        if (if_name) {
-                memset(&ndev->name, 0, 16);
+        if (if_name && (strlen(if_name) < ARRAY_SIZE(ndev->name)-1)) {
+                memset(&ndev->name, 0, ARRAY_SIZE(ndev->name));
                 memcpy(ndev->name, if_name, strlen(if_name));
         }
 

drivers/net/ethernet/altera/intel_fpga_gts_ethtool.c

@@ -1649,9 +1649,9 @@ static int gts_set_pauseparam(struct net_device *dev,
 static int gts_get_ts_info(struct net_device *dev,
 			   struct kernel_ethtool_ts_info *info)
 {
-	intel_fpga_xtile_eth_private *priv = netdev_priv(dev);
-
 	return -EOPNOTSUPP;
+#if 0
+	intel_fpga_xtile_eth_private *priv = netdev_priv(dev);
 
 	info->so_timestamping = SOF_TIMESTAMPING_TX_HARDWARE |
 				SOF_TIMESTAMPING_RX_HARDWARE |
@@ -1668,8 +1668,8 @@ static int gts_get_ts_info(struct net_device *dev,
 
 	info->rx_filters = (1 << HWTSTAMP_FILTER_NONE) |
 			   (1 << HWTSTAMP_FILTER_ALL);
-
 	return 0;
+#endif
 }
 
 /* Set link ksettings (phy address, speed) for ethtools */

drivers/net/ethernet/altera/intel_fpga_hssigl_driver.c

@@ -40,7 +40,7 @@ int hssigldrv_probe_init(struct platform_device *pdev)
 		return -ENOENT;
 
 	pdev_tr = of_find_device_by_node(dev_tr);
-        if (!dev_tr) {
+        if (!pdev_tr) {
                 of_node_put(dev_tr);
                 return -ENODEV;
         }