Merge pull request duckdb#81 from carlopi/target_link_libraries_mbedtls

carlopi · web-flow · commit af7bcaf40c77 · 2025-07-07T00:42:06.000+02:00
Use target_link_libraries instead of LINKED_LIBS
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -49,7 +49,7 @@ endif()
 find_package(OpenSSL REQUIRED)
 include_directories(${OPENSSL_INCLUDE_DIR})
 if(EMSCRIPTEN)
-
+  target_link_libraries(httpfs_loadable_extension duckdb_mbedtls)
 else()
   target_link_libraries(httpfs_loadable_extension duckdb_mbedtls
                         ${OPENSSL_LIBRARIES})
diff --git a/extension_config.cmake b/extension_config.cmake
@@ -15,5 +15,4 @@ duckdb_extension_load(httpfs
 	SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}
 	INCLUDE_DIR ${CMAKE_CURRENT_LIST_DIR}/extension/httpfs/include
 	${LOAD_HTTPFS_TESTS}
-	LINKED_LIBS "../../third_party/mbedtls/libduckdb_mbedtls.a"
 )

Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,4 @@ duckdb_extension_load(httpfs`
`15`	`15`	`SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}`
`16`	`16`	`INCLUDE_DIR ${CMAKE_CURRENT_LIST_DIR}/extension/httpfs/include`
`17`	`17`	`${LOAD_HTTPFS_TESTS}`
`18`		`- LINKED_LIBS "../../third_party/mbedtls/libduckdb_mbedtls.a"`
`19`	`18`	`)`