Skip to content

Commit b30a6c5

Browse files
committed
Avoid UploadSingleBuffer routine when kms_key_id is provided
1 parent 07bc396 commit b30a6c5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

extension/httpfs/s3fs.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,8 @@ void S3FileSystem::FlushAllBuffers(S3FileHandle &file_handle) {
478478
file_handle.write_buffers_lock.unlock();
479479

480480
if (file_handle.initialized_multipart_upload == false) {
481-
if (to_flush.size() == 1) {
481+
// TODO (carlo): unclear how to handle kms_key_id, but given currently they are custom, leave the multiupload codepath in that case
482+
if (to_flush.size() == 1 && file_handle.auth_params.kms_key_id.empty()) {
482483
UploadSingleBuffer(file_handle, to_flush[0]);
483484
file_handle.upload_finalized= true;
484485
return;

0 commit comments

Comments
 (0)