build: remove retrofit and retrofit_generator

Author: riscait

.cspell/framework-words.txt

@@ -13,6 +13,7 @@ cupertino
 dorny
 dotenv
 draggable
+endtemplate
 fastlane
 firestore
 flutterfire

docs/dependency-adoption-principles.md

@@ -0,0 +1,29 @@
+# Dependency Adoption Principles
+
+## Why we prefer fewer dependencies
+
+- Smaller dependency graph is easier to audit and keep secure.
+- Fewer transitive packages reduce upgrade churn and version conflicts.
+- Build and CI setup stay simpler and more predictable.
+
+## Why we prefer less code generation
+
+- Generated code increases maintenance cost and review overhead.
+- Build steps become slower and more fragile.
+- Debugging becomes harder when logic is hidden behind generated layers.
+
+## Guidance for adding dependencies
+
+When proposing a new package, confirm:
+
+1. It solves a concrete problem we cannot reasonably address with existing tools.
+2. The dependency impact is small and well-scoped.
+3. Code generation is optional or clearly worth the trade-off.
+
+If a package requires heavy code generation (like retrofit), document the reason
+and consider a lighter alternative first.
+
+## History: removal of retrofit / freezed / riverpod_generator
+
+We removed `retrofit`, `freezed` and `riverpod_generator` from this template.
+The intent was to reduce the dependency surface and limit code generation.

packages/flutter_app/lib/package_adaptor/pub_dev_api_client_provider.dart

@@ -2,7 +2,7 @@ import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:pub_dev_api_client/pub_dev_api_client.dart';
 
 final pubDevApiClientProvider = Provider<PubDevApiClient>((ref) {
-  return PubDevApiClient.fromParameters(
+  return PubDevApiClient(
     baseUrl: 'https://pub.dev/api',
     timeoutDuration: const Duration(seconds: 30),
   );

packages/pub_dev_api_client/build.yaml

@@ -14,7 +14,3 @@ targets:
           checked: true
           explicit_to_json: true
           field_rename: snake
-      retrofit_generator:
-        generate_for:
-          include:
-            - lib/**/*_client.dart

packages/pub_dev_api_client/lib/src/pub_dev_api_client.dart

@@ -1,46 +1,60 @@
 import 'package:dio/dio.dart';
-import 'package:retrofit/retrofit.dart' hide Headers;
 
 import 'models/models.dart';
 
-part 'pub_dev_api_client.g.dart';
-
+/// {@template pub_dev_api_client.PubDevApiClient}
 /// Client for the Pub.dev API.
-@RestApi()
-abstract class PubDevApiClient {
-  /// Internal constructor.
-  factory PubDevApiClient.internal(Dio dio, {String baseUrl}) =
-      _PubDevApiClient;
-
-  /// Create a client from parameters.
-  factory PubDevApiClient.fromParameters({
+/// {@endtemplate}
+class PubDevApiClient {
+  /// {@macro pub_dev_api_client.PubDevApiClient}
+  PubDevApiClient({
     required String baseUrl,
     required Duration timeoutDuration,
-  }) {
-    return _PubDevApiClient(
-      Dio(
-        BaseOptions(
-          baseUrl: baseUrl,
-          connectTimeout: timeoutDuration,
-          sendTimeout: timeoutDuration,
-          receiveTimeout: timeoutDuration,
-          contentType: Headers.jsonContentType,
-        ),
-      )..interceptors.add(LogInterceptor(responseBody: true)),
-    );
-  }
+  }) : _dio = Dio(
+         BaseOptions(
+           baseUrl: baseUrl,
+           connectTimeout: timeoutDuration,
+           sendTimeout: timeoutDuration,
+           receiveTimeout: timeoutDuration,
+           contentType: Headers.jsonContentType,
+         ),
+       )..interceptors.add(LogInterceptor(responseBody: true));
+
+  final Dio _dio;
 
   /// Get packages by search word.
-  @GET('/search')
   Future<GetSearchedPackagesResponseBody> getSearchedPackages({
-    @Query('q') String? searchWord,
-    @Query('sort') String? sort = 'top',
-    @Query('page') int? page,
-  });
+    String? searchWord,
+    String? sort = 'top',
+    int? page,
+  }) async {
+    final queryParameters = <String, dynamic>{
+      'q': searchWord,
+      'sort': sort,
+      'page': page,
+    }..removeWhere((_, value) => value == null);
+    final response = await _dio.get<Map<String, dynamic>>(
+      '/search',
+      queryParameters: queryParameters,
+    );
+    final data = response.data;
+    if (data == null) {
+      throw StateError('Response data is null.');
+    }
+    return GetSearchedPackagesResponseBody.fromJson(data);
+  }
 
   /// Get particular package details.
-  @GET('/packages/{name}')
   Future<GetPackageDetailsResponseBody> getPackageDetails({
-    @Path('name') required String packageName,
-  });
+    required String packageName,
+  }) async {
+    final response = await _dio.get<Map<String, dynamic>>(
+      '/packages/$packageName',
+    );
+    final data = response.data;
+    if (data == null) {
+      throw StateError('Response data is null.');
+    }
+    return GetPackageDetailsResponseBody.fromJson(data);
+  }
 }

packages/pub_dev_api_client/lib/src/pub_dev_api_client.g.dart

@@ -12,11 +12,9 @@ dependencies:
   equatable: ^2.0.5
   json_annotation: ^4.9.0
   mock_web_server: ^5.0.0-nullsafety.1
-  retrofit: ^4.6.0
 
 dev_dependencies:
   altive_lints: ^2.1.0
   build_runner: ^2.4.13
   json_serializable: ^6.9.5
-  retrofit_generator: ^10.2.0
   test: ^1.28.0

packages/pub_dev_api_client/pubspec.yaml

@@ -7,7 +7,7 @@ import 'package:test/test.dart';
 
 void main() {
   PubDevApiClient createClient({required String baseUrl}) {
-    final client = PubDevApiClient.fromParameters(
+    final client = PubDevApiClient(
       baseUrl: baseUrl,
       timeoutDuration: const Duration(milliseconds: 30000),
     );
@@ -30,7 +30,7 @@ void main() {
   group('fromParameters', () {
     test('Ensure that RestApiClient can be instantiated '
         'using the fromParameters constructor', () {
-      final client = PubDevApiClient.fromParameters(
+      final client = PubDevApiClient(
         baseUrl: 'https://example.com/api-base-url',
         timeoutDuration: const Duration(seconds: 30),
       );