Upgrade puppeteer version. Fixes #115

kimmobrunfeldt · kimmobrunfeldt · commit 89cc04f7224d · 2019-11-05T01:43:45.000+01:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,7 +32,7 @@
     "lodash": "^4.17.15",
     "morgan": "^1.9.1",
     "pdf-parse": "^1.1.1",
-    "puppeteer": "^1.14.0",
+    "puppeteer": "^2.0.0",
     "server-destroy": "^1.0.1",
     "winston": "^2.3.1"
   },
diff --git a/test/resources/special-chars.html b/test/resources/special-chars.html
@@ -0,0 +1,10 @@
+<html>
+<head>
+  <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
+</head>
+ <body>
+    <p>
+     special characters: ä ö ü
+    </p>
+ </body>
+</html>
diff --git a/test/test-all.js b/test/test-all.js
@@ -23,9 +23,15 @@ function normalisePdfText(text) {
   return text.replace(/[\W_]+/g, '-');
 }
 
-function getPdfTextContent(buffer) {
+function getPdfTextContent(buffer, opts = {}) {
   return pdf(buffer)
-    .then(data => normalisePdfText(data.text));
+    .then((data) => {
+      if (opts.raw) {
+        return data.text;
+      }
+
+      return normalisePdfText(data.text);
+    });
 }
 
 describe('GET /api/render', () => {
@@ -177,4 +183,30 @@ describe('POST /api/render', () => {
         chai.expect(text).to.have.string('Cookie-named-url-to-pdf-test-2');
       })
   );
+
+  it('special characters should be rendered correctly', () =>
+    request(app)
+      .post('/api/render')
+      .send({ html: getResource('special-chars.html') })
+      .set('Connection', 'keep-alive')
+      .set('content-type', 'application/json')
+      .expect(200)
+      .expect('content-type', 'application/pdf')
+      .then((response) => {
+        if (DEBUG) {
+          console.log(response.headers);
+          console.log(response.body);
+          fs.writeFileSync('special-chars.pdf', response.body, { encoding: null });
+        }
+
+        return getPdfTextContent(response.body, { raw: true });
+      })
+      .then((text) => {
+        if (DEBUG) {
+          fs.writeFileSync('./special-chars-content.txt', text);
+        }
+
+        chai.expect(text).to.have.string('special characters: ä ö ü');
+      })
+  );
 });

-Original file line number
+Diff line change
@@ @@ -0,0 +1,10 @@ @@
 +<html>
 +<head>
 +  <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
 +</head>
 + <body>
 +    <p>
 +     special characters: ä ö ü
 +    </p>
 + </body>
 +</html>