Skip to content

Commit af1f842

Browse files
committed
replace enable-volume-group-snapshots with featuregate
replace the old ref of enable-volume-group-snapshots flag with featuregate
1 parent a0cef53 commit af1f842

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ Other than this, the NODE_NAME environment variable must be set where the CSI sn
119119
The following requisites must be met to enable the volume group snapshot feature:
120120

121121
* the Volume Group Snapshot CRDs are installed in the cluster
122-
* the `--enable-volume-group-snapshots=true` option is being passed to the snapshot controller
123-
* the `--enable-volume-group-snapshots=true` option is being passed to the CSI snapshotter sidecar
122+
* the `--feature-gates=CSIVolumeGroupSnapshot=true` option is being passed to the snapshot controller
123+
* the `--feature-gates=CSIVolumeGroupSnapshot=true` option is being passed to the CSI snapshotter sidecar
124124

125-
Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml` needs to be updated with `--enable-volume-group-snapshots=true` in order to enable this feature in the snapshot controller.
125+
Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml` needs to be updated with `--feature-gates=CSIVolumeGroupSnapshot=true` in order to enable this feature in the snapshot controller.
126126

127127
### Snapshot controller command line options
128128

@@ -159,7 +159,7 @@ Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.y
159159

160160
#### Volume Group Snapshot support
161161

162-
* `--enable-volume-group-snapshots`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster.
162+
* `--feature-gates=CSIVolumeGroupSnapshot=true`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster.
163163

164164
#### Other recognized arguments
165165
* `--kubeconfig <path>`: Path to Kubernetes client configuration that the snapshot controller uses to connect to Kubernetes API server. When omitted, default token provided by Kubernetes will be used. This option is useful only when the snapshot controller does not run as a Kubernetes pod, e.g. for debugging.
@@ -205,7 +205,7 @@ Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.y
205205

206206
#### Volume Group Snapshot support
207207

208-
* `--enable-volume-group-snapshots`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster.
208+
* `--feature-gates=CSIVolumeGroupSnapshot=true`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster.
209209

210210
#### Other recognized arguments
211211
* `--kubeconfig <path>`: Path to Kubernetes client configuration that the CSI external-snapshotter uses to connect to Kubernetes API server. When omitted, default token provided by Kubernetes will be used. This option is useful only when the external-snapshotter does not run as a Kubernetes pod, e.g. for debugging.

cmd/csi-snapshotter/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ func main() {
250250
if err != nil {
251251
klog.Errorf("error determining if driver supports create/delete group snapshot operations: %v", err)
252252
} else if !supportsCreateVolumeGroupSnapshot {
253-
klog.Warningf("CSI driver %s does not support GroupControllerCreateVolumeGroupSnapshot when the --enable-volume-group-snapshots flag is true", driverName)
253+
klog.Warningf("CSI driver %s does not support GroupControllerCreateVolumeGroupSnapshot when the --feature-gates=CSIVolumeGroupSnapshot=true flag is set", driverName)
254254
}
255255
groupSnapshotter = group_snapshotter.NewGroupSnapshotter(csiConn)
256256
if len(*groupSnapshotNamePrefix) == 0 {

0 commit comments

Comments
 (0)