refactor : split frequency parameters into a separate table

Author: Roshan

config/totem.php

@@ -33,7 +33,7 @@
             'parameters'        => [
                 [
                     'label'         => 'At',
-                    'modifier'      => 'at',
+                    'name'          => 'at',
                     'type'          => 'number',
                     'min'           => '0',
                     'max'           => '59',
@@ -51,7 +51,7 @@
             'parameters'        => [
                 [
                     'label'         => 'At',
-                    'modifier'      => 'at',
+                    'name'          => 'at',
                     'type'          => 'time',
                 ],
             ],
@@ -62,12 +62,12 @@
             'parameters'        => [
                 [
                     'label'         => 'First',
-                    'modifier'      => 'at',
+                    'name'          => 'at',
                     'type'          => 'time',
                 ],
                 [
                     'label'         => 'Second',
-                    'modifier'      => 'second_at',
+                    'name'          => 'second_at',
                     'type'          => 'time',
                 ],
             ],
@@ -83,14 +83,14 @@
             'parameters'        => [
                 [
                     'label'         => 'On',
-                    'modifier'      => 'on',
+                    'name'          => 'on',
                     'type'          => 'number',
                     'min'           => '1',
                     'max'           => '31',
                 ],
                 [
                     'label'         => 'At',
-                    'modifier'      => 'at',
+                    'name'          => 'at',
                     'type'          => 'time',
                 ],
             ],
@@ -106,13 +106,13 @@
             'parameters'        => [
                 [
                     'label'         => 'On',
-                    'modifier'      => 'on',
+                    'name'          => 'on',
                     'type'          => 'number',
                     'max'           => '',
                 ],
                 [
                     'label'         => 'At',
-                    'modifier'      => 'at',
+                    'name'          => 'at',
                     'type'          => 'time',
                 ],
             ],
@@ -123,12 +123,12 @@
             'parameters'        => [
                 [
                     'label'         => 'First',
-                    'modifier'      => 'on',
+                    'name'          => 'on',
                     'type'          => 'number',
                 ],
                 [
                     'label'         => 'Second',
-                    'modifier'      => 'second_at',
+                    'name'          => 'second_at',
                     'type'          => 'text',
                 ],
             ],
@@ -189,12 +189,12 @@
             'parameters'        => [
                 [
                     'label'         => 'Start',
-                    'modifier'      => 'start',
+                    'name'          => 'start',
                     'type'          => 'time',
                 ],
                 [
                     'label'         => 'End',
-                    'modifier'      => 'end',
+                    'name'          => 'end',
                     'type'          => 'time',
                 ],
             ],
@@ -205,12 +205,12 @@
             'parameters'        => [
                 [
                     'label'         => 'Start',
-                    'modifier'      => 'start',
+                    'name'          => 'start',
                     'type'          => 'time',
                 ],
                 [
                     'label'         => 'End',
-                    'modifier'      => 'end',
+                    'name'          => 'end',
                     'type'          => 'time',
                 ],
             ],

database/migrations/2017_08_05_195539_create_task_frequencies_table.php

@@ -17,38 +17,7 @@ public function up()
             $table->increments('id');
             $table->unsignedInteger('task_id');
             $table->string('label');
-            $table->enum('interval', [
-                'everyMinute',
-                'everyFiveMinutes',
-                'everyTenMinutes',
-                'everyThirtyMinutes',
-                'hourly',
-                'hourlyAt',
-                'daily',
-                'dailyAt',
-                'twiceDaily',
-                'weekly',
-                'weeklyOn',
-                'monthly',
-                'twiceMonthly',
-                'monthlyOn',
-                'quarterly',
-                'yearly',
-                'weekdays',
-                'sundays',
-                'mondays',
-                'tuesdays',
-                'wednesdays',
-                'thursdays',
-                'fridays',
-                'saturdays',
-            ]);
-            $table->integer('on')->nullable();
-            $table->integer('second_on')->nullable();
-            $table->string('at')->nullable();
-            $table->string('second_at')->nullable();
-            $table->time('start')->nullable();
-            $table->time('end')->nullable();
+            $table->string('interval');
             $table->timestamps();
         });
     }

database/migrations/2017_08_24_085132_create_frequency_parameters_table.php

@@ -0,0 +1,34 @@
+<?php
+
+use Illuminate\Support\Facades\Schema;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Database\Migrations\Migration;
+
+class CreateFrequencyParametersTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::create('frequency_parameters', function (Blueprint $table) {
+            $table->increments('id');
+            $table->unsignedInteger('frequency_id');
+            $table->string('name');
+            $table->string('value');
+            $table->timestamps();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::dropIfExists('frequency_parameters');
+    }
+}