refactor(stats) : task stats calculations

Author: qschmick

database/factories/ModelFactory.php

@@ -32,3 +32,14 @@
         'expression'   => '* * * * *',
     ];
 });
+
+$factory->define(Studio\Totem\Result::class, function (Faker\Generator $faker) {
+    return [
+        'task_id'     => $faker->randomDigit,
+        'ran_at'      => $faker->dateTimeBetween('-1 hour'),
+        'duration'    => (string) $faker->randomFloat(11, 0, 8000000),
+        'result'      => $faker->sentence,
+        'created_at'  => $faker->dateTimeBetween('-1 year', '-6 months'),
+        'updated_at'  => $faker->dateTimeBetween('-6 months'),
+    ];
+});

resources/views/tasks/index.blade.php

@@ -36,10 +36,10 @@
                         <span class="uk-float-right uk-hidden@s uk-text-muted">Command</span>
                     </td>
                     <td>
-                        {{  $task->results->count() > 0 ? number_format(  $task->results->sum('duration') / (1000 * $task->results->count()) , 2) : '0' }} seconds
+                        {{ number_format(  $task->averageRuntime / 1000 , 2 ) }} seconds
                         <span class="uk-float-right uk-hidden@s uk-text-muted">Avg. Runtime</span>
                     </td>
-                    @if($last = $task->results->last())
+                    @if($last = $task->lastResult)
                         <td>
                             {{$last->ran_at->toDateTimeString()}}
                             <span class="uk-float-right uk-hidden@s uk-text-muted">Last Run</span>

src/Task.php

@@ -95,6 +95,24 @@ public function results()
         return $this->hasMany(Result::class, 'task_id', 'id');
     }
 
+    /**
+     * Returns the most recent result entry for this task.
+     *
+     * @return Model|null
+     */
+    public function getLastResultAttribute()
+    {
+        return $this->results()->orderBy('id', 'desc')->first();
+    }
+
+    /**
+     * @return float
+     */
+    public function getAverageRuntimeAttribute()
+    {
+        return $this->results()->avg('duration') ?? 0.00;
+    }
+
     /**
      * Route notifications for the mail channel.
      *

tests/Feature/ViewDashboardTest.php

@@ -0,0 +1,94 @@
+<?php
+
+namespace Studio\Totem\Tests\Feature;
+
+use Studio\Totem\Task;
+use Studio\Totem\Result;
+use Studio\Totem\Tests\TestCase;
+
+class ViewDashboardTest extends TestCase
+{
+    /** @test */
+    public function user_can_view_dashboard()
+    {
+        $this->signIn();
+        $response = $this->get(route('totem.dashboard'));
+        $response->assertStatus(302);
+    }
+
+    /** @test */
+    public function guest_can_not_view_dashboard()
+    {
+        $response = $this->get(route('totem.dashboard'));
+        $response->assertStatus(403);
+    }
+
+    /** @test */
+    public function view_dashboard_single_task_no_results()
+    {
+        $this->signIn();
+        $task = factory(Task::class)->create();
+        $response = $this->get(route('totem.tasks.all', $task));
+        $response->assertStatus(200);
+        $this->assertEmpty($task->results);
+        $this->assertSame(0.0, $task->averageRuntime);
+        $response->assertSee($task->description);
+    }
+
+    /** @test */
+    public function view_dashboard_single_task_with_results()
+    {
+        $this->signIn();
+        $tasks = $this->_get_task_with_results();
+        $response = $this->get(route('totem.tasks.all', $tasks[0]));
+        $response->assertStatus(200);
+
+        $this->assertNotEmpty($tasks[0]->results);
+        $this->assertGreaterThanOrEqual(0.0, $tasks[0]->averageRuntime);
+        $response->assertSee($tasks[0]->description);
+    }
+
+    /** @test */
+    public function view_dashboard_single_task_with_multiple_results()
+    {
+        $this->signIn();
+        $tasks = $this->_get_task_with_results(1, 9);
+        $response = $this->get(route('totem.tasks.all', $tasks[0]));
+        $response->assertStatus(200);
+
+        $this->assertNotEmpty($tasks[0]->results);
+        $this->assertGreaterThanOrEqual(0.0, $tasks[0]->averageRuntime);
+        $response->assertSee($tasks[0]->description);
+    }
+
+    /** @test */
+    public function view_dashboard_multiple_tasks_with_multiple_results()
+    {
+        $this->signIn();
+        $tasks = $this->_get_task_with_results(4, 5);
+        $response = $this->get(route('totem.tasks.all', $tasks[0]));
+        $response->assertStatus(200);
+
+        foreach ($tasks as $task) {
+            $this->assertNotEmpty($task->results);
+            $this->assertGreaterThanOrEqual(0.0, $task->averageRuntime);
+            $response->assertSee($task->description);
+        }
+    }
+
+    /**
+     * @param int $task_count
+     * @param int $result_count
+     * @return mixed
+     */
+    private function _get_task_with_results($task_count = 1, $result_count = 1)
+    {
+        return factory(Task::class, $task_count)
+            ->create()
+            ->each(function ($task) use ($result_count) {
+                for ($i = 0; $i < $result_count; $i++) {
+                    $task->results()->save(factory(Result::class)->make());
+                }
+            });
+    }
+}