Merge pull request #67 from qschmick/fix/compile-params-console-bug

Fix/compile params console bug

Author: qschmick

src/Task.php

@@ -75,7 +75,8 @@ public function compileParameters($console = false)
             $parameters = collect($matches)->mapWithKeys(function ($parameter) use ($console, &$argument_index) {
                 $param = explode('=', $parameter[0]);
 
-                return count($param) > 1 ? [$param[0] => $param[1]]
+                return count($param) > 1
+                    ? ($console ? (starts_with($param[0], '--') ? [$param[0] => $param[1]] : [$argument_index++ => $param[1]]) : [$param[0] => $param[1]])
                     : (starts_with($param[0], '--') && ! $console ? [$param[0] => true] : [$argument_index++ => $param[0]]);
             })->toArray();
 

tests/Feature/CompileParametersTest.php

@@ -103,7 +103,25 @@ public function test_all_mixed_arguments()
         $this->assertSame('15', $parameters['arg3']);
         $this->assertSame('arg4', $parameters[1]);
         $this->assertSame('warm', $parameters['--someplace']);
-        $this->assertTrue($parameters['--flag']);
         $this->assertArrayHasKey('--flag', $parameters);
+        $this->assertSame(true, $parameters['--flag']);
+        $this->assertSame(true, $parameters['--flag2']);
+    }
+
+    public function test_all_mixed_arguments_console()
+    {
+        $task = factory(Task::class)->create();
+        $task->parameters = 'arg1 arg2=test arg3=15 arg4 --flag --flag2 --option=yes --someplace=warm';
+        $parameters = $task->compileParameters(true);
+
+        $this->assertCount(8, $parameters);
+        $this->assertSame('arg1', $parameters[0]);
+        $this->assertSame('test', $parameters[1]);
+        $this->assertSame('15', $parameters[2]);
+        $this->assertSame('arg4', $parameters[3]);
+        $this->assertSame('--flag', $parameters[4]);
+        $this->assertSame('--flag2', $parameters[5]);
+        $this->assertSame('yes', $parameters['--option']);
+        $this->assertSame('warm', $parameters['--someplace']);
     }
 }