refactor(core): clean up clang comments and workarounds (angular#55750)

Since we aren't using clang anymore, we can remove the comments and the workarounds that were in place to prevent it from doing the wrong thing.

PR Close angular#55750

Author: crisbeto

packages/common/http/src/interceptor.ts

@@ -181,14 +181,12 @@ function chainedInterceptorFn(
   interceptorFn: HttpInterceptorFn,
   injector: EnvironmentInjector,
 ): ChainedInterceptorFn<unknown> {
-  // clang-format off
   return (initialRequest, finalHandlerFn) =>
     runInInjectionContext(injector, () =>
       interceptorFn(initialRequest, (downstreamRequest) =>
         chainTailFn(downstreamRequest, finalHandlerFn),
       ),
     );
-  // clang-format on
 }
 
 /**

packages/common/src/pipes/date_pipe.ts

@@ -58,7 +58,6 @@ export const DATE_PIPE_DEFAULT_OPTIONS = new InjectionToken<DatePipeConfig>(
   ngDevMode ? 'DATE_PIPE_DEFAULT_OPTIONS' : '',
 );
 
-// clang-format off
 /**
  * @ngModule CommonModule
  * @description
@@ -217,7 +216,6 @@ export const DATE_PIPE_DEFAULT_OPTIONS = new InjectionToken<DatePipeConfig>(
  *
  * @publicApi
  */
-// clang-format on
 @Pipe({
   name: 'date',
   standalone: true,

packages/compiler-cli/src/ngtsc/core/src/compiler.ts

@@ -1402,7 +1402,6 @@ export class NgCompiler {
 
       // TODO(alxhub): understand why the cast here is necessary (something to do with `null`
       // not being assignable to `unknown` when wrapped in `Readonly`).
-      // clang-format off
       new DirectiveDecoratorHandler(
         reflector,
         evaluator,
@@ -1422,7 +1421,6 @@ export class NgCompiler {
         compilationMode,
         !!this.options.generateExtraImportsInLocalMode,
       ) as Readonly<DecoratorHandler<unknown, unknown, SemanticSymbol | null, unknown>>,
-      // clang-format on
       // Pipe handler must be before injectable handler in list so pipe factories are printed
       // before injectable factories (so injectable factories can delegate to them)
       new PipeDecoratorHandler(

packages/compiler-cli/src/ngtsc/reflection/src/host.ts

@@ -28,11 +28,8 @@ export interface Decorator {
   /**
    * `Import` by which the decorator was brought into the module in which it was invoked, or `null`
    * if the decorator was declared in the same module and not imported.
-   *
-   * Note: this field is declared using computed property syntax to work around a clang-format bug
-   * that resulted in inconsistent indentation of this comment block.
    */
-  ['import']: Import | null;
+  import: Import | null;
 
   /**
    * TypeScript reference to the decorator itself.

packages/compiler-cli/src/ngtsc/resource/src/loader.ts

@@ -232,14 +232,13 @@ export class AdapterResourceLoader implements ResourceLoader {
       failedLookupLocations: ReadonlyArray<string>;
     };
 
-    // clang-format off
     const failedLookup = ts.resolveModuleName(
       url + RESOURCE_MARKER,
       fromFile,
       this.options,
       this.lookupResolutionHost,
     ) as ResolvedModuleWithFailedLookupLocations;
-    // clang-format on
+
     if (failedLookup.failedLookupLocations === undefined) {
       throw new Error(
         `Internal error: expected to find failedLookupLocations during resolution of resource '${url}' in context of ${fromFile}`,

packages/compiler-cli/test/ngtsc/ngtsc_spec.ts

@@ -46,11 +46,7 @@ function getDiagnosticSourceCode(diag: ts.Diagnostic): string {
   return diag.file!.text.slice(diag.start!, diag.start! + diag.length!);
 }
 
-runInEachFileSystem(allTests);
-
-// Wrap all tests into a function to work around clang-format going crazy and (poorly)
-// reformatting the entire file.
-function allTests(os: string) {
+runInEachFileSystem((os: string) => {
   describe('ngtsc behavioral tests', () => {
     let env!: NgtscTestEnvironment;
 
@@ -10505,4 +10501,4 @@ function allTests(os: string) {
     expect(guard(node)).toBe(true);
     return node as T;
   }
-}
+});

packages/compiler-cli/test/test_support.ts

@@ -60,11 +60,9 @@ function createTestSupportFor(basePath: string) {
     'lib': Object.freeze([
       path.resolve(basePath, 'node_modules/typescript/lib/lib.es6.d.ts'),
     ]) as string[],
-    // clang-format off
     'paths': Object.freeze({'@angular/*': ['./node_modules/@angular/*']}) as {
       [index: string]: string[];
     },
-    // clang-format on
   };
 
   return {

packages/compiler/src/i18n/digest.ts

@@ -301,7 +301,6 @@ function hash32(view: DataView, length: number, c: number): number {
   return mix(a, b, c)[2];
 }
 
-// clang-format off
 function mix(a: number, b: number, c: number): [number, number, number] {
   a -= b;
   a -= c;
@@ -332,7 +331,6 @@ function mix(a: number, b: number, c: number): [number, number, number] {
   c ^= b >>> 15;
   return [a, b, c];
 }
-// clang-format on
 
 // Utils
 

packages/compiler/test/i18n/extractor_merger_spec.ts

@@ -733,15 +733,12 @@ function extract(
     throw new Error(`unexpected errors: ${result.errors.join('\n')}`);
   }
 
-  // clang-format off
-  // https://github.com/angular/clang-format/issues/35
   return result.messages.map((message) => [
     serializeI18nNodes(message.nodes),
     message.meaning,
     message.description,
     message.id,
   ]) as [string[], string, string, string][];
-  // clang-format on
 }
 
 function extractErrors(

packages/compiler/test/i18n/i18n_parser_spec.ts

@@ -326,45 +326,36 @@ export function _humanizeMessages(
   implicitTags: string[] = [],
   implicitAttrs: {[k: string]: string[]} = {},
 ): [string[], string, string, string][] {
-  // clang-format off
-  // https://github.com/angular/clang-format/issues/35
   return _extractMessages(html, implicitTags, implicitAttrs).map((message) => [
     serializeNodes(message.nodes),
     message.meaning,
     message.description,
     message.id,
   ]) as [string[], string, string, string][];
-  // clang-format on
 }
 
 function _humanizePlaceholders(
   html: string,
   implicitTags: string[] = [],
   implicitAttrs: {[k: string]: string[]} = {},
 ): string[] {
-  // clang-format off
-  // https://github.com/angular/clang-format/issues/35
   return _extractMessages(html, implicitTags, implicitAttrs).map((msg) =>
     Object.keys(msg.placeholders)
       .map((name) => `${name}=${msg.placeholders[name].text}`)
       .join(', '),
   );
-  // clang-format on
 }
 
 function _humanizePlaceholdersToMessage(
   html: string,
   implicitTags: string[] = [],
   implicitAttrs: {[k: string]: string[]} = {},
 ): string[] {
-  // clang-format off
-  // https://github.com/angular/clang-format/issues/35
   return _extractMessages(html, implicitTags, implicitAttrs).map((msg) =>
     Object.keys(msg.placeholderToMessage)
       .map((k) => `${k}=${digest(msg.placeholderToMessage[k])}`)
       .join(', '),
   );
-  // clang-format on
 }
 
 export function _extractMessages(