refactor(core): Remove unused JSNAMESPACE_SUPPORT from event-dispatch (angular#55619)

The usage of this option has been removed from google3 code, so we don't
need to keep it around anymore.

PR Close angular#55619

Author: rahatarmanahmed

goldens/public-api/core/primitives/event-dispatch/index.md

@@ -44,8 +44,6 @@ export class EventContract implements UnrenamedEventContract {
     exportAddA11yClickSupport(): void;
     handler(eventType: string): EventHandler | undefined;
     // (undocumented)
-    static JSNAMESPACE_SUPPORT: boolean;
-    // (undocumented)
     static MOUSE_SPECIAL_SUPPORT: boolean;
     registerDispatcher(dispatcher: Dispatcher_2, restriction: Restriction): void;
     replayEarlyEvents(earlyJsactionContainer?: EarlyJsactionDataContainer): void;

packages/core/primitives/event-dispatch/src/action_resolver.ts

@@ -33,7 +33,6 @@ const DEFAULT_EVENT_TYPE: string = EventType.CLICK;
 export class ActionResolver {
   private a11yClickSupport: boolean = false;
   private readonly customEventSupport: boolean;
-  private readonly jsnamespaceSupport: boolean;
   private readonly syntheticMouseEventSupport: boolean;
 
   private updateEventInfoForA11yClick?: (eventInfo: eventInfoLib.EventInfo) => void = undefined;
@@ -48,15 +47,12 @@ export class ActionResolver {
 
   constructor({
     customEventSupport = false,
-    jsnamespaceSupport = false,
     syntheticMouseEventSupport = false,
   }: {
     customEventSupport?: boolean;
-    jsnamespaceSupport?: boolean;
     syntheticMouseEventSupport?: boolean;
   } = {}) {
     this.customEventSupport = customEventSupport;
-    this.jsnamespaceSupport = jsnamespaceSupport;
     this.syntheticMouseEventSupport = syntheticMouseEventSupport;
   }
 
@@ -214,17 +210,14 @@ export class ActionResolver {
    * action the given event is mapped to, if any. It parses the
    * attribute value and stores it in a property on the node for
    * subsequent retrieval without re-parsing and re-accessing the
-   * attribute. In order to fully qualify jsaction names using a
-   * namespace, the DOM is searched starting at the current node and
-   * going through ancestor nodes until a jsnamespace attribute is
-   * found.
+   * attribute.
    *
    * @param actionElement The DOM node to retrieve the jsaction map from.
    * @param eventInfo `EventInfo` to set `action` and `actionElement` if an
    *    action is found on the `actionElement`.
    */
   private populateActionOnElement(actionElement: Element, eventInfo: eventInfoLib.EventInfo) {
-    const actionMap = this.parseActions(actionElement, eventInfoLib.getContainer(eventInfo));
+    const actionMap = this.parseActions(actionElement);
 
     const actionName = actionMap[eventInfoLib.getEventType(eventInfo)];
     if (actionName !== undefined) {
@@ -242,11 +235,9 @@ export class ActionResolver {
    * This is primarily for internal use.
    *
    * @param actionElement The DOM node to retrieve the jsaction map from.
-   * @param container The node which limits the namespace lookup for a jsaction
-   * name. The container node itself will not be searched.
    * @return Map from event to qualified name of the jsaction bound to it.
    */
-  private parseActions(actionElement: Element, container: Node): {[key: string]: string} {
+  private parseActions(actionElement: Element): {[key: string]: string} {
     let actionMap: {[key: string]: string} | undefined = cache.get(actionElement);
     if (!actionMap) {
       const jsactionAttribute = actionElement.getAttribute(Attribute.JSACTION);
@@ -271,58 +262,12 @@ export class ActionResolver {
           }
           cache.setParsed(jsactionAttribute, actionMap);
         }
-        // If namespace support is active we need to augment the (potentially
-        // cached) jsaction mapping with the namespace.
-        if (this.jsnamespaceSupport) {
-          const noNs = actionMap;
-          actionMap = {};
-          for (const type in noNs) {
-            actionMap[type] = this.getFullyQualifiedAction(noNs[type], actionElement, container);
-          }
-        }
         cache.set(actionElement, actionMap);
       }
     }
     return actionMap;
   }
 
-  /**
-   * Returns the fully qualified jsaction action. If the given jsaction
-   * name doesn't already contain the namespace, the function iterates
-   * over ancestor nodes until a jsnamespace attribute is found, and
-   * uses the value of that attribute as the namespace.
-   *
-   * @param action The jsaction action to resolve.
-   * @param start The node from which to start searching for a jsnamespace
-   * attribute.
-   * @param container The node which limits the search for a jsnamespace
-   * attribute. This node will be searched.
-   * @return The fully qualified name of the jsaction. If no namespace is found,
-   * returns the unqualified name in case it exists in the global namespace.
-   */
-  private getFullyQualifiedAction(action: string, start: Element, container: Node): string {
-    if (isNamespacedAction(action)) {
-      return action;
-    }
-
-    let node: Node | null = start;
-    while (node && node.nodeType === Node.ELEMENT_NODE) {
-      const namespace = getNamespaceFromElement(node as Element);
-      if (namespace) {
-        return namespace + Char.NAMESPACE_ACTION_SEPARATOR + action;
-      }
-
-      // If this node is the container, stop.
-      if (node === container) {
-        break;
-      }
-
-      node = node.parentNode;
-    }
-
-    return action;
-  }
-
   addA11yClickSupport(
     updateEventInfoForA11yClick: typeof a11yClick.updateEventInfoForA11yClick,
     preventDefaultForA11yClick: typeof a11yClick.preventDefaultForA11yClick,
@@ -334,29 +279,3 @@ export class ActionResolver {
     this.populateClickOnlyAction = populateClickOnlyAction;
   }
 }
-
-/**
- * Checks if a jsaction action contains a namespace part.
- */
-function isNamespacedAction(action: string): boolean {
-  return action.indexOf(Char.NAMESPACE_ACTION_SEPARATOR) >= 0;
-}
-
-/**
- * Returns the value of the jsnamespace attribute of the given node.
- * Also caches the value for subsequent lookups.
- * @param element The node whose jsnamespace attribute is being asked for.
- * @return The value of the jsnamespace attribute, or null if not found.
- */
-function getNamespaceFromElement(element: Element): string | null {
-  let namespace = cache.getNamespace(element);
-  // Only query for the attribute if it has not been queried for
-  // before. getAttribute() returns null if an attribute is not present. Thus,
-  // namespace is string|null if the query took place in the past, or
-  // undefined if the query did not take place.
-  if (namespace === undefined) {
-    namespace = element.getAttribute(Attribute.JSNAMESPACE);
-    cache.setNamespace(element, namespace);
-  }
-  return namespace;
-}

packages/core/primitives/event-dispatch/src/event_contract_defines.ts

@@ -6,12 +6,6 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-/**
- * @define Support for jsnamespace attribute.  This flag can be overridden in a
- * build rule to trim down the EventContract's binary size.
- */
-export const JSNAMESPACE_SUPPORT = false;
-
 /**
  * @define Support for accessible click actions.  This flag can be overridden in
  * a build rule.

packages/core/primitives/event-dispatch/src/eventcontract.ts

@@ -38,7 +38,6 @@ import {EventContractContainerManager} from './event_contract_container';
 import {
   A11Y_CLICK_SUPPORT,
   CUSTOM_EVENT_SUPPORT,
-  JSNAMESPACE_SUPPORT,
   MOUSE_SPECIAL_SUPPORT,
 } from './event_contract_defines';
 import * as eventInfoLib from './event_info';
@@ -91,13 +90,11 @@ export class EventContract implements UnrenamedEventContract {
   static CUSTOM_EVENT_SUPPORT = CUSTOM_EVENT_SUPPORT;
   static A11Y_CLICK_SUPPORT = A11Y_CLICK_SUPPORT;
   static MOUSE_SPECIAL_SUPPORT = MOUSE_SPECIAL_SUPPORT;
-  static JSNAMESPACE_SUPPORT = JSNAMESPACE_SUPPORT;
 
   private containerManager: EventContractContainerManager | null;
 
   private readonly actionResolver = new ActionResolver({
     customEventSupport: EventContract.CUSTOM_EVENT_SUPPORT,
-    jsnamespaceSupport: EventContract.JSNAMESPACE_SUPPORT,
     syntheticMouseEventSupport: EventContract.MOUSE_SPECIAL_SUPPORT,
   });
 

packages/core/primitives/event-dispatch/test/eventcontract_test.ts

@@ -1781,113 +1781,6 @@ describe('EventContract', () => {
     });
   });
 
-  describe('jsnamespace', () => {
-    beforeEach(() => {
-      EventContract.JSNAMESPACE_SUPPORT = true;
-    });
-
-    it('dispatches event', () => {
-      const container = getRequiredElementById('jsnamespace-container');
-      const actionElement = getRequiredElementById('jsnamespace-action-element');
-      const targetElement = getRequiredElementById('jsnamespace-target-element');
-
-      const dispatcher = jasmine.createSpy<Dispatcher>('dispatcher');
-      createEventContract({
-        eventContractContainerManager: new EventContractContainer(container),
-        eventTypes: ['click'],
-        dispatcher,
-      });
-
-      const clickEvent = dispatchMouseEvent(targetElement);
-
-      expect(dispatcher).toHaveBeenCalledTimes(2);
-      const eventInfoWrapper = getLastDispatchedEventInfoWrapper(dispatcher);
-      expect(eventInfoWrapper.getEventType()).toBe('click');
-      expect(eventInfoWrapper.getEvent()).toBe(clickEvent);
-      expect(eventInfoWrapper.getTargetElement()).toBe(targetElement);
-      expect(eventInfoWrapper.getAction()?.name).toBe('namespace.handleClick');
-      expect(eventInfoWrapper.getAction()?.element).toBe(actionElement);
-    });
-
-    it('caches namespace attribute', () => {
-      const container = getRequiredElementById('jsnamespace-container');
-      const namespaceElement = getRequiredElementById('jsnamespace-namespace-element');
-      const actionElement = getRequiredElementById('jsnamespace-action-element');
-      const targetElement = getRequiredElementById('jsnamespace-target-element');
-
-      const dispatcher = jasmine.createSpy<Dispatcher>('dispatcher');
-      createEventContract({
-        eventContractContainerManager: new EventContractContainer(container),
-        eventTypes: ['click'],
-        dispatcher,
-      });
-
-      let clickEvent = dispatchMouseEvent(targetElement);
-
-      expect(dispatcher).toHaveBeenCalledTimes(2);
-      let eventInfoWrapper = getLastDispatchedEventInfoWrapper(dispatcher);
-      expect(eventInfoWrapper.getEventType()).toBe('click');
-      expect(eventInfoWrapper.getEvent()).toBe(clickEvent);
-      expect(eventInfoWrapper.getTargetElement()).toBe(targetElement);
-      expect(eventInfoWrapper.getAction()?.name).toBe('namespace.handleClick');
-      expect(eventInfoWrapper.getAction()?.element).toBe(actionElement);
-
-      namespaceElement.setAttribute('jsnamespace', 'renamedNamespace');
-      dispatcher.calls.reset();
-
-      clickEvent = dispatchMouseEvent(targetElement);
-
-      expect(dispatcher).toHaveBeenCalledTimes(2);
-      eventInfoWrapper = getLastDispatchedEventInfoWrapper(dispatcher);
-      expect(eventInfoWrapper.getEventType()).toBe('click');
-      expect(eventInfoWrapper.getEvent()).toBe(clickEvent);
-      expect(eventInfoWrapper.getTargetElement()).toBe(targetElement);
-      expect(eventInfoWrapper.getAction()?.name).toBe('namespace.handleClick');
-      expect(eventInfoWrapper.getAction()?.element).toBe(actionElement);
-    });
-
-    it('re-parses jsaction attribute if the action cache is cleared', () => {
-      const container = getRequiredElementById('jsnamespace-container');
-      const namespaceElement = getRequiredElementById('jsnamespace-namespace-element');
-      const actionElement = getRequiredElementById('jsnamespace-action-element');
-      const targetElement = getRequiredElementById('jsnamespace-target-element');
-
-      const dispatcher = jasmine.createSpy<Dispatcher>('dispatcher');
-      createEventContract({
-        eventContractContainerManager: new EventContractContainer(container),
-        eventTypes: ['click'],
-        dispatcher,
-      });
-
-      let clickEvent = dispatchMouseEvent(targetElement);
-
-      expect(dispatcher).toHaveBeenCalledTimes(2);
-      let eventInfoWrapper = getLastDispatchedEventInfoWrapper(dispatcher);
-      expect(eventInfoWrapper.getEventType()).toBe('click');
-      expect(eventInfoWrapper.getEvent()).toBe(clickEvent);
-      expect(eventInfoWrapper.getTargetElement()).toBe(targetElement);
-      expect(eventInfoWrapper.getAction()?.name).toBe('namespace.handleClick');
-      expect(eventInfoWrapper.getAction()?.element).toBe(actionElement);
-
-      namespaceElement.setAttribute('jsnamespace', 'renamedNamespace');
-      // Clear namespace cache.
-      cache.clearNamespace(namespaceElement);
-      // Clear action cache.
-      cache.clear(actionElement);
-      dispatcher.calls.reset();
-
-      clickEvent = dispatchMouseEvent(targetElement);
-
-      expect(dispatcher).toHaveBeenCalledTimes(2);
-      eventInfoWrapper = getLastDispatchedEventInfoWrapper(dispatcher);
-      expect(eventInfoWrapper.getEventType()).toBe('click');
-      expect(eventInfoWrapper.getEvent()).toBe(clickEvent);
-      expect(eventInfoWrapper.getTargetElement()).toBe(targetElement);
-      expect(eventInfoWrapper.getAction()?.name).toBe('renamedNamespace.handleClick');
-      expect(eventInfoWrapper.getAction()?.element).toBe(actionElement);
-    });
-  });
-
   describe('early events', () => {
     let removeEventListenerSpy: jasmine.Spy;