refactor(core): Remove RootViewRef<T> because it is the same as ViewRef<T> (angular#52430)

`RootViewRef<T>` extends `ViewRef<T>` and overrides 3 methods with behavior
that is identical to `ViewRef<T>`. This commit removes `RootViewRef<T>`
because it is not needed.

PR Close angular#52430

Author: atscott

packages/core/src/render3/component_ref.ts

@@ -51,7 +51,7 @@ import {computeStaticStyling} from './styling/static_styling';
 import {mergeHostAttrs, setUpAttributes} from './util/attrs_utils';
 import {debugStringifyTypeForError, stringifyForError} from './util/stringify_utils';
 import {getComponentLViewByIndex, getNativeByTNode, getTNode} from './util/view_utils';
-import {InternalViewRef, RootViewRef} from './view_ref';
+import {InternalViewRef} from './view_ref';
 
 export class ComponentFactoryResolver extends AbstractComponentFactoryResolver {
   /**
@@ -319,7 +319,11 @@ export class ComponentRef<T> extends AbstractComponentRef<T> {
       private _tNode: TElementNode|TContainerNode|TElementContainerNode) {
     super();
     this.instance = instance;
-    this.hostView = this.changeDetectorRef = new RootViewRef<T>(_rootLView);
+    this.hostView = this.changeDetectorRef = new InternalViewRef<T>(
+        _rootLView,
+        undefined, /* _cdRefInjectingView */
+        false,     /* notifyErrorHandler */
+    );
     this.componentType = componentType;
   }
 

packages/core/src/render3/view_ref.ts

@@ -55,7 +55,7 @@ export class InternalViewRef<T> implements EmbeddedViewRef<T>, ChangeDetectorRef
        *
        * This may be different from `_lView` if the `_cdRefInjectingView` is an embedded view.
        */
-      private _cdRefInjectingView?: LView) {}
+      private _cdRefInjectingView?: LView, private readonly notifyErrorHandler = true) {}
 
   get context(): T {
     return this._lView[CONTEXT] as unknown as T;
@@ -282,7 +282,8 @@ export class InternalViewRef<T> implements EmbeddedViewRef<T>, ChangeDetectorRef
    * See {@link ChangeDetectorRef#detach} for more information.
    */
   detectChanges(): void {
-    detectChangesInternal(this._lView[TVIEW], this._lView, this.context as unknown as {});
+    detectChangesInternal(
+        this._lView[TVIEW], this._lView, this.context as unknown as {}, this.notifyErrorHandler);
   }
 
   /**
@@ -293,7 +294,8 @@ export class InternalViewRef<T> implements EmbeddedViewRef<T>, ChangeDetectorRef
    */
   checkNoChanges(): void {
     if (ngDevMode) {
-      checkNoChangesInternal(this._lView[TVIEW], this._lView, this.context as unknown as {});
+      checkNoChangesInternal(
+          this._lView[TVIEW], this._lView, this.context as unknown as {}, this.notifyErrorHandler);
     }
   }
 
@@ -320,29 +322,3 @@ export class InternalViewRef<T> implements EmbeddedViewRef<T>, ChangeDetectorRef
     this._appRef = appRef;
   }
 }
-
-export class RootViewRef<T> extends InternalViewRef<T> {
-  constructor(public _view: LView) {
-    super(_view);
-  }
-
-  override detectChanges(): void {
-    const lView = this._view;
-    const tView = lView[TVIEW];
-    const context = lView[CONTEXT];
-    detectChangesInternal(tView, lView, context, false);
-  }
-
-  override checkNoChanges(): void {
-    if (ngDevMode) {
-      const lView = this._view;
-      const tView = lView[TVIEW];
-      const context = lView[CONTEXT];
-      checkNoChangesInternal(tView, lView, context, false);
-    }
-  }
-
-  override get context(): T {
-    return null!;
-  }
-}

packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json

@@ -269,6 +269,9 @@
   {
     "name": "Injector"
   },
+  {
+    "name": "InternalViewRef"
+  },
   {
     "name": "LEAVE_TOKEN_REGEX"
   },
@@ -443,9 +446,6 @@
   {
     "name": "RendererStyleFlags2"
   },
-  {
-    "name": "RootViewRef"
-  },
   {
     "name": "RuntimeError"
   },
@@ -548,9 +548,6 @@
   {
     "name": "ViewEncapsulation"
   },
-  {
-    "name": "ViewRef"
-  },
   {
     "name": "WebAnimationsDriver"
   },
@@ -824,9 +821,6 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
-  {
-    "name": "detectChangesInternal"
-  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/animations/bundle.golden_symbols.json

@@ -290,6 +290,9 @@
   {
     "name": "Injector"
   },
+  {
+    "name": "InternalViewRef"
+  },
   {
     "name": "KeyEventsPlugin"
   },
@@ -485,9 +488,6 @@
   {
     "name": "RootComponent"
   },
-  {
-    "name": "RootViewRef"
-  },
   {
     "name": "RuntimeError"
   },
@@ -602,9 +602,6 @@
   {
     "name": "ViewEncapsulation"
   },
-  {
-    "name": "ViewRef"
-  },
   {
     "name": "WebAnimationsDriver"
   },
@@ -887,9 +884,6 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
-  {
-    "name": "detectChangesInternal"
-  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

@@ -194,6 +194,9 @@
   {
     "name": "Injector"
   },
+  {
+    "name": "InternalViewRef"
+  },
   {
     "name": "KeyEventsPlugin"
   },
@@ -368,9 +371,6 @@
   {
     "name": "RendererStyleFlags2"
   },
-  {
-    "name": "RootViewRef"
-  },
   {
     "name": "RuntimeError"
   },
@@ -458,9 +458,6 @@
   {
     "name": "ViewEncapsulation"
   },
-  {
-    "name": "ViewRef"
-  },
   {
     "name": "ZONE_IS_STABLE_OBSERVABLE"
   },
@@ -668,9 +665,6 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
-  {
-    "name": "detectChangesInternal"
-  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/defer/bundle.golden_symbols.json

@@ -227,6 +227,9 @@
   {
     "name": "Injector"
   },
+  {
+    "name": "InternalViewRef"
+  },
   {
     "name": "KeyEventsPlugin"
   },
@@ -419,9 +422,6 @@
   {
     "name": "RendererStyleFlags2"
   },
-  {
-    "name": "RootViewRef"
-  },
   {
     "name": "RuntimeError"
   },
@@ -509,9 +509,6 @@
   {
     "name": "ViewEncapsulation"
   },
-  {
-    "name": "ViewRef"
-  },
   {
     "name": "ZONE_IS_STABLE_OBSERVABLE"
   },
@@ -758,9 +755,6 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
-  {
-    "name": "detectChangesInternal"
-  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

@@ -272,6 +272,9 @@
   {
     "name": "Injector"
   },
+  {
+    "name": "InternalViewRef"
+  },
   {
     "name": "IterableChangeRecord_"
   },
@@ -506,9 +509,6 @@
   {
     "name": "RootComponent"
   },
-  {
-    "name": "RootViewRef"
-  },
   {
     "name": "RuntimeError"
   },
@@ -614,9 +614,6 @@
   {
     "name": "ViewEngineTemplateRef"
   },
-  {
-    "name": "ViewRef"
-  },
   {
     "name": "ZONE_IS_STABLE_OBSERVABLE"
   },
@@ -911,9 +908,6 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
-  {
-    "name": "detectChangesInternal"
-  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

@@ -257,6 +257,9 @@
   {
     "name": "Injector"
   },
+  {
+    "name": "InternalViewRef"
+  },
   {
     "name": "IterableChangeRecord_"
   },
@@ -494,9 +497,6 @@
   {
     "name": "RootComponent"
   },
-  {
-    "name": "RootViewRef"
-  },
   {
     "name": "RuntimeError"
   },
@@ -605,9 +605,6 @@
   {
     "name": "ViewEngineTemplateRef"
   },
-  {
-    "name": "ViewRef"
-  },
   {
     "name": "ZONE_IS_STABLE_OBSERVABLE"
   },
@@ -881,9 +878,6 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
-  {
-    "name": "detectChangesInternal"
-  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/hello_world/bundle.golden_symbols.json

@@ -137,6 +137,9 @@
   {
     "name": "Injector"
   },
+  {
+    "name": "InternalViewRef"
+  },
   {
     "name": "LOCALE_ID2"
   },
@@ -281,9 +284,6 @@
   {
     "name": "RendererFactory2"
   },
-  {
-    "name": "RootViewRef"
-  },
   {
     "name": "RuntimeError"
   },
@@ -350,9 +350,6 @@
   {
     "name": "ViewEncapsulation"
   },
-  {
-    "name": "ViewRef"
-  },
   {
     "name": "ZONE_IS_STABLE_OBSERVABLE"
   },
@@ -527,9 +524,6 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
-  {
-    "name": "detectChangesInternal"
-  },
   {
     "name": "diPublicInInjector"
   },