Skip to content

Commit d00f9e8

Browse files
iterianiatscott
authored andcommitted
refactor(core): Export some more symbols and check for truthiness on event types before adding them. (angular#55587)
In some cases, we will be passing in undefined for capture events, so handle this. PR Close angular#55587
1 parent 61007dc commit d00f9e8

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

goldens/public-api/core/primitives/event-dispatch/index.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ export class Dispatcher {
2828
unregisterHandler(namespace: string, name: string): void;
2929
}
3030

31+
// @public (undocumented)
32+
export interface EarlyJsactionDataContainer {
33+
// (undocumented)
34+
_ejsa?: EarlyJsactionData;
35+
}
36+
3137
// @public
3238
export class EventContract implements UnrenamedEventContract {
3339
constructor(containerManager: EventContractContainerManager);

packages/core/primitives/event-dispatch/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
export {Dispatcher, registerDispatcher} from './src/dispatcher';
1010
export {EventContractContainer} from './src/event_contract_container';
11+
export type {EarlyJsactionDataContainer} from './src/earlyeventcontract';
1112
export {EventContract} from './src/eventcontract';
1213
export {bootstrapEventContract, bootstrapEarlyEventContract} from './src/register_events';
1314

packages/core/primitives/event-dispatch/src/register_events.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ export function bootstrapEarlyEventContract(
5454
field: string,
5555
container: HTMLElement,
5656
appId: string,
57-
eventTypes: string[],
58-
captureEventTypes: string[],
57+
eventTypes?: string[],
58+
captureEventTypes?: string[],
5959
earlyJsactionTracker: EventContractTracker<EarlyJsactionDataContainer> = window as unknown as EventContractTracker<EarlyJsactionDataContainer>,
6060
) {
6161
if (!earlyJsactionTracker[field]) {
6262
earlyJsactionTracker[field] = {};
6363
}
6464
earlyJsactionTracker[field][appId] = {};
6565
const eventContract = new EarlyEventContract(earlyJsactionTracker[field][appId], container);
66-
eventContract.addEvents(eventTypes);
67-
eventContract.addEvents(captureEventTypes, true);
66+
eventTypes && eventContract.addEvents(eventTypes);
67+
captureEventTypes && eventContract.addEvents(captureEventTypes, true);
6868
}

0 commit comments

Comments
 (0)