Skip to content

Commit ed5bfe8

Browse files
MariosRadismhevery
authored andcommitted
docs: simplify deleteHero method in tutorial (angular#41303)
Fixes angular#41233 PR Close angular#41303
1 parent 5eb7f34 commit ed5bfe8

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

aio/content/examples/toh-pt6/src/app/hero.service.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ export class HeroService {
104104

105105
// #docregion deleteHero
106106
/** DELETE: delete the hero from the server */
107-
deleteHero(hero: Hero | number): Observable<Hero> {
108-
const id = typeof hero === 'number' ? hero : hero.id;
107+
deleteHero(id: number): Observable<Hero> {
109108
const url = `${this.heroesUrl}/${id}`;
110109

111110
return this.http.delete<Hero>(url, this.httpOptions).pipe(

aio/content/examples/toh-pt6/src/app/heroes/heroes.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class HeroesComponent implements OnInit {
3636
// #docregion delete
3737
delete(hero: Hero): void {
3838
this.heroes = this.heroes.filter(h => h !== hero);
39-
this.heroService.deleteHero(hero).subscribe();
39+
this.heroService.deleteHero(hero.id).subscribe();
4040
}
4141
// #enddocregion delete
4242

0 commit comments

Comments
 (0)