Merge pull request #187 from olle-johannesson/improve-code-coverage

Improve code coverage

Author: minjikarin

spec/amadeus/client.test.js

@@ -123,6 +123,26 @@ describe('Client', () => {
       });
     });
 
+    describe('.delete', () => {
+      it('should create a new request and call it', () => {
+        let call = client.unauthenticatedRequest = jest.fn();
+        client.accessToken = { bearerToken: () => {
+          return { then: resolve => resolve('token') };
+        }};
+        client.delete(path, params);
+        expect(call).toHaveBeenCalledWith('DELETE', path, params, 'token');
+      });
+
+      it('should work without params', () => {
+        let call = client.unauthenticatedRequest = jest.fn();
+        client.accessToken = { bearerToken: () => {
+          return { then: resolve => resolve('token') };
+        }};
+        client.delete(path);
+        expect(call).toHaveBeenCalledWith('DELETE', path, {}, 'token');
+      });
+    });
+
     describe('.unauthenticatedRequest', () => {
       it('should create a new request and call it', () => {
         client.accessToken.bearerToken = jest.fn(() => Promise.resolve('data'));

spec/amadeus/client/response.test.js

@@ -47,26 +47,27 @@ describe('Response', () => {
         expect(response.data).toEqual('b');
       });
 
-      it('should not parse if not json', () => {
-        response.contentType = 'plain/text';
+      it('should handle badly formed json', () => {
+        response.addChunk('{ "a" : ');
         response.parse();
         expect(response.parsed).toBeFalsy();
         expect(response.result).toBeNull();
         expect(response.data).toBeNull();
       });
 
-      it('should not parse if status code is 204', () => {
-        response.contentType = 'plain/text';
-        response.statusCode = 204;
+      it('should not parse if not json', () => {
+        response.headers['content-type'] = 'plain/text';
         response.parse();
         expect(response.parsed).toBeFalsy();
         expect(response.result).toBeNull();
         expect(response.data).toBeNull();
       });
 
-      it('should handle badly formed json', () => {
-        response.addChunk('{ "a" : ');
-        response.parse();
+      it('should not parse if status code is 204', () => {
+        response.contentType = 'plain/text';
+        response.statusCode = 204;
+        const parsingReturnValue = response.parse();
+        expect(parsingReturnValue).toBeUndefined();
         expect(response.parsed).toBeFalsy();
         expect(response.result).toBeNull();
         expect(response.data).toBeNull();

spec/amadeus/namespaces.test.js

@@ -318,6 +318,12 @@ describe('Namespaces', () => {
         .toHaveBeenCalledWith('/v3/travel/trip-parser', {});
     });
 
+    it('.amadeus.travel.tripParser.fromFile', () => {
+      const utf8Buffer = Buffer.from('file contént', 'utf8');
+      const base64Encoding = amadeus.travel.tripParser.fromFile(utf8Buffer);
+      expect(base64Encoding).toEqual('ZmlsZSBjb250w6ludA==');
+    });
+
     it('.amadeus.shopping.flightDates.get', () => {
       amadeus.client.get = jest.fn();
       amadeus.shopping.flightDates.get();
@@ -423,13 +429,23 @@ describe('Namespaces', () => {
         .toHaveBeenCalledWith('/v1/booking/flight-orders/XXX');
     });
 
+    it('.amadeus.booking.flightOrder().get throws when not providing an orderId', () => {
+      expect(() => amadeus.booking.flightOrder().get())
+        .toThrow(new Error('MISSING_REQUIRED_PARAMETER'));
+    });
+
     it('.amadeus.booking.flightOrder().delete', () => {
       amadeus.client.delete = jest.fn();
       amadeus.booking.flightOrder('XXX').delete();
       expect(amadeus.client.delete)
         .toHaveBeenCalledWith('/v1/booking/flight-orders/XXX');
     });
 
+    it('.amadeus.booking.flightOrder().delete throws when not providing an orderId', () => {
+      expect(() => amadeus.booking.flightOrder().delete())
+        .toThrow(new Error('MISSING_REQUIRED_PARAMETER'));
+    });
+
     it('.amadeus.booking.hotelBookings.post', () => {
       amadeus.client.post = jest.fn();
       amadeus.booking.hotelBookings.post();