move the list to the Reqeust class

Author: minjikarin

amadeus/client/request.py

@@ -84,6 +84,16 @@ def __build_user_agent(self):
             user_agent += ' {0}/{1}'.format(self.app_id, self.app_version)
         return user_agent
 
+     # The list of paths that require HTTP override in header
+    list_httpoverride = [
+                        '/v2/shopping/flight-offers',
+                        '/v1/shopping/seatmaps',
+                        '/v1/shopping/availability/flight-availabilities',
+                        '/v2/shopping/flight-offers/prediction',
+                        '/v1/shopping/flight-offers/pricing?',
+                        '/v1/shopping/flight-offers/upselling'
+                        ]
+
     # Builds a HTTP Request object based on the path, params, and verb
     def __build_http_request(self):
         # Requests token in case has not been set
@@ -95,18 +105,9 @@ def __build_http_request(self):
         # Adds the authentication header since the bearer token has been set
         self.headers['Authorization'] = self.bearer_token
 
-        # List of paths that require HTTP override in header
-        list_httpoverride = [
-                            '/v2/shopping/flight-offers',
-                            '/v1/shopping/seatmaps',
-                            '/v1/shopping/availability/flight-availabilities',
-                            '/v2/shopping/flight-offers/prediction',
-                            '/v1/shopping/flight-offers/pricing?',
-                            '/v1/shopping/flight-offers/upselling'
-                            ]
-
         if self.verb == 'POST':
-            if self.path in list_httpoverride:
+            #Adds HTTP override in Header for the list of paths required
+            if self.path in Request.list_httpoverride:
                 self.headers['X-HTTP-Method-Override'] = 'GET'
             if type(self.params) is dict:
                 return HTTPRequest(self.url, headers=self.headers, method='POST',

specs/client/request_spec.py

@@ -86,20 +86,12 @@
             expect(self.request.http_request.data).to(
                 equal(b'{\"foo\": \"bar\"}'))
 
-        with it('should return X-HTTP-Method-Override in header'):
-            self.path =[
-                        '/v2/shopping/flight-offers',
-                        '/v1/shopping/seatmaps',
-                        '/v1/shopping/availability/flight-availabilities',
-                        '/v2/shopping/flight-offers/prediction',
-                        '/v1/shopping/flight-offers/pricing?',
-                        '/v1/shopping/flight-offers/upselling'
-                        ]
-            for i in self.path:              
+        with it('should return X-HTTP-Method-Override in header for some POST requests'):
+            for path in Request.list_httpoverride:              
                 self.request = Request({
                     'host': self.host,
                     'verb': 'POST',
-                    'path': self.path,
+                    'path': path,
                     'params': self.params,
                     'bearer_token': self.bearer_token,
                     'client_version': self.client_version,
@@ -109,10 +101,10 @@
                     'port': self.port,
                     'ssl': self.ssl
                 })
-            
+
                 expect(self.request.http_request).to(be_a(HTTPRequest))
-                expect(self.request.http_request.get_header('X-HTTP-Method-Override')).to(
-                    equal('GET')
+                expect(self.request.headers['X-HTTP-Method-Override']
+                        ).to(equal('GET')
                 )
 
         with it('should handle a custom scheme and port'):