tests: Fix Bucket soft-delete tests.

The soft-deleted buckets were being tracker by the fixture. The fixture tracks buckets for deletion which is done on a best effort basis, so that's not the problem. But, tracked buckets are also use as the expected result for ListAllBuckets tests, so these soft-deleted buckets were being expected but they were not showing up in actual lists.

Author: amanda-tarafa

apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs

@@ -32,7 +32,8 @@ public GetBucketTest(StorageFixture fixture)
     public async Task SoftDeleted()
     {
         var bucketName = _fixture.GenerateBucketName();
-        var softDeleteBucket = _fixture.CreateBucket(bucketName, multiVersion: false, softDelete: true);
+        var softDeleteBucket = _fixture.CreateBucket(bucketName, multiVersion: false, softDelete: true, registerForDeletion: false);
+
         await _fixture.Client.DeleteBucketAsync(softDeleteBucket.Name, new DeleteBucketOptions { DeleteObjects = true });
 
         var softDeleted = await _fixture.Client.GetBucketAsync(softDeleteBucket.Name, new GetBucketOptions { SoftDeleted = true, Generation = softDeleteBucket.Generation });

apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/ListBucketsTest.cs

@@ -79,7 +79,7 @@ public void PartialResponses()
         public async Task SoftDeletedOnly()
         {
             var bucketName = _fixture.GenerateBucketName();
-            var softDeleteBucket = _fixture.CreateBucket(bucketName, multiVersion: false, softDelete: true);
+            var softDeleteBucket = _fixture.CreateBucket(bucketName, multiVersion: false, softDelete: true, registerForDeletion: false);
 
             await _fixture.Client.DeleteBucketAsync(softDeleteBucket.Name, new DeleteBucketOptions { DeleteObjects = true });
 

apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs

@@ -249,7 +249,7 @@ void CreateObject()
 
         }
 
-        internal Bucket CreateBucket(string name, bool multiVersion, bool softDelete = false)
+        internal Bucket CreateBucket(string name, bool multiVersion, bool softDelete = false, bool registerForDeletion = true)
         {
             var bucket = Client.CreateBucket(ProjectId,
                 new Bucket
@@ -260,7 +260,10 @@ internal Bucket CreateBucket(string name, bool multiVersion, bool softDelete = f
                     SoftDeletePolicy = softDelete ? new Bucket.SoftDeletePolicyData { RetentionDurationSeconds = (int) TimeSpan.FromDays(7).TotalSeconds } : null,
                 });
             SleepAfterBucketCreateDelete();
-            RegisterBucketToDelete(name);
+            if (registerForDeletion)
+            {
+                RegisterBucketToDelete(name);
+            }
             return bucket;
         }