Skip to content

Commit f3e6ad6

Browse files
committed
chore(Storage): Skip for real the normalization D test.
Note we correctly used the `Skip` argument but there has been several issues with `InlineData` not respecting it. Most issues claim to have been fixed, but it's not for us and we are not going to figure out why for a test that is skipped anyway.
1 parent 03ec88c commit f3e6ad6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/NormalizationTest.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ public class NormalizationTest
3333
[InlineData("Caf\u00e9", "Normalization Form C")]
3434
// Normalization Form D: an ASCII e followed by U+0301 combining character
3535
// URL should end with Bebe%CC%81
36-
[InlineData("Bebe\u0301", "Normalization Form D", Skip = "b/477619774")]
36+
// Note: We need to skip this test by commenting it out because of
37+
// https://github.com/xunit/visualstudio.xunit/issues/266 and similar issues.
38+
// [InlineData("Bebe\u0301", "Normalization Form D", Skip = "b/477619774")]
3739
public void FetchObjectAndCheckContent(string name, string expectedContent)
3840
{
3941
TestEnvironment.SkipIfVpcSc();

0 commit comments

Comments
 (0)