Skip to content

Commit b86cd01

Browse files
committed
feat(sidekick/rust): Reduce vertical space in RPC samples
This is to improve usability when samples are displayed as tooltips in IDEs.
1 parent 3e378d2 commit b86cd01

File tree

2 files changed

+38
-42
lines changed

2 files changed

+38
-42
lines changed

internal/sidekick/rust/templates/common/client_method_samples/builder_fields.mustache

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,21 @@ distributed under the License is distributed on an "AS IS" BASIS,
1212
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1313
See the License for the specific language governing permissions and
1414
limitations under the License.
15-
}}
16-
{{#AIPStandardGetInfo}}
17-
/// .set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name)
18-
{{/AIPStandardGetInfo}}
19-
{{#AIPStandardDeleteInfo}}
20-
/// .set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name)
21-
{{/AIPStandardDeleteInfo}}
22-
{{#AIPStandardUndeleteInfo}}
23-
/// .set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name)
24-
{{/AIPStandardUndeleteInfo}}
25-
{{#AIPStandardListInfo}}
26-
/// .set_{{ParentRequestField.Codec.SetterName}}(parent)
27-
{{/AIPStandardListInfo}}
28-
{{^IsAIPStandard}}
29-
/// /* set fields */
30-
{{/IsAIPStandard}}
15+
}}{{!
16+
Terminate each line in a comment so
17+
(a) we can read this code as each case is in a separate line,and
18+
(b) the newline is suppressed in the output to get tighter code.
19+
Also use no newline at the end of file so the the partials are all merged into a single line.
20+
}}{{#AIPStandardGetInfo}}{{!
21+
}}.set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name){{!
22+
}}{{/AIPStandardGetInfo}}{{!
23+
}}{{#AIPStandardDeleteInfo}}{{!
24+
}}.set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name){{!
25+
}}{{/AIPStandardDeleteInfo}}{{!
26+
}}{{#AIPStandardUndeleteInfo}}{{!
27+
}}.set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name){{!
28+
}}{{/AIPStandardUndeleteInfo}}{{!
29+
}}{{#AIPStandardListInfo}}{{!
30+
}}.set_{{ParentRequestField.Codec.SetterName}}(parent){{!
31+
}}{{/AIPStandardListInfo}}{{!
32+
}}{{^IsAIPStandard}}/* set fields */{{/IsAIPStandard}}

internal/sidekick/rust/templates/common/client_method_samples/method_call.mustache

Lines changed: 20 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -13,47 +13,41 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1313
See the License for the specific language governing permissions and
1414
limitations under the License.
1515
}}
16+
{{!
17+
Terminate some lines in a comment so
18+
(a) we can read this code as each case is in a separate line,and
19+
(b) the newline is suppressed in the output to get tighter code.
20+
}}
1621
{{#IsSimple}}
1722
{{#ReturnsEmpty}}
18-
/// client
19-
/// .{{Codec.Name}}()
20-
{{> /templates/common/client_method_samples/builder_fields}}
21-
/// .send()
22-
/// .await?;
23+
/// client.{{Codec.Name}}(){{!
24+
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
25+
}}.send().await?;
2326
{{/ReturnsEmpty}}
2427
{{^ReturnsEmpty}}
25-
/// let response = client
26-
/// .{{Codec.Name}}()
27-
{{> /templates/common/client_method_samples/builder_fields}}
28-
/// .send()
29-
/// .await?;
28+
/// let response = client.{{Codec.Name}}(){{!
29+
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
30+
}}.send().await?;
3031
/// println!("response {:?}", response);
3132
{{/ReturnsEmpty}}
3233
{{/IsSimple}}
3334
{{#IsLRO}}
3435
{{#LongRunningReturnsEmpty}}
35-
/// client
36-
/// .{{Codec.Name}}()
37-
{{> /templates/common/client_method_samples/builder_fields}}
38-
/// .poller()
39-
/// .until_done()
40-
/// .await?;
36+
/// client.{{Codec.Name}}(){{!
37+
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
38+
}}.poller().until_done().await?;
4139
{{/LongRunningReturnsEmpty}}
4240
{{^LongRunningReturnsEmpty}}
43-
/// let response = client
44-
/// .{{Codec.Name}}()
45-
{{> /templates/common/client_method_samples/builder_fields}}
46-
/// .poller()
47-
/// .until_done()
48-
/// .await?;
41+
/// let response = client.{{Codec.Name}}(){{!
42+
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
43+
}}.poller().until_done().await?;
4944
/// println!("response {:?}", response);
5045
{{/LongRunningReturnsEmpty}}
5146
{{/IsLRO}}
5247
{{#IsList}}
53-
/// let mut list = client
54-
/// .{{Codec.Name}}()
55-
{{> /templates/common/client_method_samples/builder_fields}}
56-
/// .by_item();
48+
/// let mut list = client.{{Codec.Name}}(){{!
49+
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
50+
}}.by_item();
5751
/// while let Some(item) = list.next().await.transpose()? {
5852
/// println!("{:?}", item);
5953
/// }

0 commit comments

Comments
 (0)