Install carto in the dockerfile

[RayBB]

I noticed this step takes a long time (maybe a minute) to run in the ipynotebook

osm-mapping-party-before-after/make.sh

Lines 44 to 49 in 05dcff6

	if [ ! -s "$ROOT/openstreetmap-carto/node_modules/.bin/carto" ] ; then
	cd "$ROOT/openstreetmap-carto"
	echo "Installing carto into $ROOT/openstreetmap-carto/node_modules with npm..."
	npm init -y
	npm install carto -q
	fi

I see we install it on docker. Was wondering if it's intentional that this has to install again when we run the from the notebook?
Or maybe it's a bug in the make script?

PS: I hope all these reports aren't too overwhelming. I'm very excited about this project and want to see it get even easier to use :)

[gedankenstuecke]

No worries about reporting this, it’s great to see people try and learn where things go wrong!

I think you’re right that it wouldn’t have to be run twice, but the make script as it currently is has no concept of if it’s run inside or outside the container (as a result of how the project organically grew from that original script).

What I’m not 100% sure about though if the install also seeds anything into the DB, in which case we wouldn’t be able to really run it inside the Dockerfile? 🤔 also I guess the step in the dockerfile doesn’t actually do anything if the make script still runs it again 😄

[gedankenstuecke]

I just gave this a try, I fear we can't cut down on the npm install-step in the make file, as the install during the Dockerfile is the one that could be skipped (but then it doesn't save any time for the end-user to do that, as it's only run during the build stage).

If anyone has a solution for this, I'd love to see it!