Typing of href property on Link component does no match the href prop of getPathname? Best practice?

[seloElo]

Hey,

I was doing a big abstract function to construct a pathname based on some database value (that I will then use everywhere, on links/getPathnames function for metada stuff etc) following this: https://next-intl.dev/docs/routing/navigation#link-composition

I saw that the typing signature of the getPathname function href prop was different than the Link component href one. It made my TS yell at me when I wanted to use my function to populate a getPathname href.

I guess it's because of how typing of a jsx props works, and it got me wondering if I was not doing something wrong here? My two sense would be to update my generic function to this return type:

Parameters<typeof getPathname>[0]["href"] instead of ComponentProps<typeof Link>["href"]

Since its more restrictive.

What do you guys think?

Thanks!

[sahandsn]

is it ok to use getPathname and don't include the locale prop?

  const pathname = getPathname({
    locale: "",
    href: {
      pathname: "/clinic/[doctorUuid]/result",
      params: { doctorUuid: "5" },
      query: { uuid: "1234" },
    },
  });

[seloElo]

Not sure its related to my question, but no if you use this you are passing "" as locale, and this function does no allow for undefined locale