stable and unique key for /rules page and key fixes

amanycodes · amanycodes · commit 25d2746e3561 · 2025-04-24T20:09:03.000+05:30
Signed-off-by: amanycodes &lt;amanycodes@gmail.com&gt;
diff --git a/web/ui/mantine-ui/src/pages/AlertsPage.tsx b/web/ui/mantine-ui/src/pages/AlertsPage.tsx
@@ -221,7 +221,7 @@ export default function AlertsPage() {
           shadow="xs"
           withBorder
           p="md"
-          key={`${g.name}-${g.file}`} // TODO: Find a stable and definitely unique key.
+          key={`${g.file}-${g.name}`} // TODO: Find a stable and definitely unique key.
         >
           <Group mb="sm" justify="space-between">
             <Group align="baseline">
diff --git a/web/ui/mantine-ui/src/pages/RulesPage.tsx b/web/ui/mantine-ui/src/pages/RulesPage.tsx
@@ -86,12 +86,13 @@ export default function RulesPage() {
           (effectiveActivePage - 1) * ruleGroupsPerPage,
           effectiveActivePage * ruleGroupsPerPage
         )
-        .map((g, i) => (
+        .map((g) => (
           <Card
             shadow="xs"
             withBorder
             p="md"
-            key={i} // TODO: Find a stable and definitely unique key.
+            mb="md"
+            key={`${g.file}-${g.name}`} // TODO: Find a stable and definitely unique key.
           >
             <Group mb="sm" justify="space-between">
               <Group align="baseline">

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ export default function AlertsPage() {`
`221`	`221`	`shadow="xs"`
`222`	`222`	`withBorder`
`223`	`223`	`p="md"`
`224`		- key={`${g.name}-${g.file}`} // TODO: Find a stable and definitely unique key.
	`224`	+ key={`${g.file}-${g.name}`} // TODO: Find a stable and definitely unique key.
`225`	`225`	`>`
`226`	`226`	`<Group mb="sm" justify="space-between">`
`227`	`227`	`<Group align="baseline">`