fix: typescript and linter issues

amatya-aditya · amatya-aditya · commit 347b88c3850c · 2026-01-01T00:19:14.000-06:00
diff --git a/README.md b/README.md
@@ -193,7 +193,11 @@ If you encounter any issues or have suggestions:
 
 If you find this plugin useful, consider supporting its long-term development:
 
-<a href="https://www.buymeacoffee.com/amatya_aditya"><img src="https://img.buymeacoffee.com/button-api/?text=Buy me a pizza&emoji=🍕&slug=amatya_aditya&button_colour=FFDD00&font_colour=000000&font_family=Cookie&outline_colour=000000&coffee_colour=ffffff" /></a>
+<p align="center">
+  <a href="https://www.buymeacoffee.com/amatya_aditya" target="_blank">☕ Buy me a coffee</a>
+</p>
+
+<p align="center"> <a href='https://ko-fi.com/Y8Y41FV4WI' target='_blank'><img height='36' style='border:0px;height:36px;' src='https://storage.ko-fi.com/cdn/kofi2.png?v=6' border='0' alt='Buy Me a Coffee at ko-fi.com' /></a></p>
 
 ## Other Plugins by Me
 
diff --git a/docs/releases/2.1.5.md b/docs/releases/2.1.5.md
@@ -0,0 +1,7 @@
+# 2.1.5
+
+## Fixes
+- Fixed multiple TypeScript linter errors related to unnecessary `await` expressions
+- Improved async method handling across dashboard and reader views
+- Enhanced type safety for file existence checks
+- Resolved unsafe type assignments in settings and view components
diff --git a/main.ts b/main.ts
@@ -84,7 +84,7 @@ export default class RssDashboardPlugin extends Plugin {
         
         const view = await this.getActiveDashboardView();
         if (view) {
-            await view.render();
+            view.render();
         }
         
         try {
@@ -194,7 +194,7 @@ export default class RssDashboardPlugin extends Plugin {
                     if (view) {
                         this.settings.sidebarCollapsed = !this.settings.sidebarCollapsed;
                         await this.saveSettings();
-                        await view.render();
+                        view.render();
                     }
                 },
             });
@@ -377,7 +377,7 @@ export default class RssDashboardPlugin extends Plugin {
             await this.saveSettings();
             const view = await this.getActiveDashboardView();
             if (view) {
-                await view.refresh();
+                view.refresh();
                 new Notice(`Feeds refreshed: ${feedNoticeText}`);
             }
         } catch (error) {
@@ -436,7 +436,7 @@ export default class RssDashboardPlugin extends Plugin {
             await this.saveSettings();
             const view = await this.getActiveDashboardView();
             if (view) {
-                await view.refresh();
+                view.refresh();
             }
             
             if (updatedCount > 0) {
@@ -490,7 +490,7 @@ export default class RssDashboardPlugin extends Plugin {
         
         const view = await this.getActiveDashboardView();
         if (view) {
-            await view.refresh();
+            view.refresh();
         }
     }
 
@@ -607,7 +607,7 @@ export default class RssDashboardPlugin extends Plugin {
                     
                     const view = await this.getActiveDashboardView();
                     if (view) {
-                        await view.render();
+                        view.render();
                         }
 
                     new Notice(`Imported ${addedFeeds.length} feeds. Articles will be fetched in the background.`);
@@ -704,7 +704,7 @@ export default class RssDashboardPlugin extends Plugin {
             
             const view = await this.getActiveDashboardView();
             if (view && processedCount % 3 === 0) {
-                await view.render();
+                view.render();
         }
 
             
@@ -715,7 +715,7 @@ export default class RssDashboardPlugin extends Plugin {
         await this.saveSettings();
         const view = await this.getActiveDashboardView();
         if (view) {
-            await view.render();
+            view.render();
         }
 
         
@@ -1040,7 +1040,7 @@ export default class RssDashboardPlugin extends Plugin {
             
             const view = await this.getActiveDashboardView();
             if (view) {
-                await view.render();
+                view.render();
             }
         }
     }
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "rss-dashboard",
 	"name": "RSS Dashboard",
-	"version": "2.1.4",
+	"version": "2.1.5",
 	"minAppVersion": "1.1.0",
 	"description": "A Dashboard for organizing and consuming RSS feeds, YouTube channels, and podcasts with smart tagging, media playback, and seamless content flow.",
 	"author": "Aditya Amatya",
diff --git a/src/settings/settings-tab.ts b/src/settings/settings-tab.ts
@@ -80,7 +80,7 @@ export class RssDashboardSettingTab extends PluginSettingTab {
                         const view = await this.plugin.getActiveDashboardView();
                         if (view) {
                             await this.app.workspace.revealLeaf(view.leaf);
-                            await view.render();
+                            view.render();
                         }
                     })
             );
@@ -155,7 +155,7 @@ export class RssDashboardSettingTab extends PluginSettingTab {
                         const view = await this.plugin.getActiveDashboardView();
                         if (view) {
                             await this.app.workspace.revealLeaf(view.leaf);
-                            await view.render();
+                            view.render();
                         }
                     })
             );
@@ -257,7 +257,7 @@ export class RssDashboardSettingTab extends PluginSettingTab {
                         const view = await this.plugin.getActiveDashboardView();
                         if (view && this.plugin.settings.viewStyle === "card") {
                             await this.app.workspace.revealLeaf(view.leaf);
-                            await view.render();
+                            view.render();
                         }
                     })
             );
@@ -604,7 +604,7 @@ export class RssDashboardSettingTab extends PluginSettingTab {
                         const view = await this.plugin.getActiveDashboardView();
                         if (view) {
                             await this.app.workspace.revealLeaf(view.leaf);
-                            await view.render();
+                            view.render();
                         }
                         new Notice("Data imported successfully!");
                     } catch {
@@ -651,7 +651,7 @@ export class RssDashboardSettingTab extends PluginSettingTab {
                         const view = await this.plugin.getActiveDashboardView();
                         if (view) {
                             await this.app.workspace.revealLeaf(view.leaf);
-                            await view.render();
+                            view.render();
                         }
                     })
                 )
diff --git a/src/views/dashboard-view.ts b/src/views/dashboard-view.ts
@@ -153,11 +153,11 @@ export class RssDashboardView extends ItemView {
         }
         
         
-        await this.render();
+        this.render();
     }
     
     
-    async render(): Promise<void> {
+    render(): void {
         
         this.verifySavedArticles();
         
@@ -914,8 +914,8 @@ export class RssDashboardView extends ItemView {
     }
     
     
-    async refresh(): Promise<void> {
-        await this.render();
+    refresh(): void {
+        this.render();
     }
 
     onClose(): Promise<void> {
diff --git a/src/views/reader-view.ts b/src/views/reader-view.ts
@@ -274,7 +274,7 @@ export class ReaderView extends ItemView {
         this.updateSavedLabel(false);
 
         if (item.saved) {
-            const fileExists = await this.checkSavedFileExists(item);
+            const fileExists = this.checkSavedFileExists(item);
             if (!fileExists) {
                 item.saved = false;
                 if (item.tags) {
@@ -751,7 +751,7 @@ export class ReaderView extends ItemView {
     }
     
     
-    private async checkSavedFileExists(item: FeedItem): Promise<boolean> {
+    private checkSavedFileExists(item: FeedItem): boolean {
         try {
             
             const folder = this.settings.articleSaving.defaultFolder || "RSS articles";
diff --git a/versions.json b/versions.json
@@ -13,5 +13,6 @@
 	"2.1.1": "1.1.0",
 	"2.1.2": "1.1.0",
 	"2.1.3": "1.1.0",
-	"2.1.4": "1.1.0"
+	"2.1.4": "1.1.0",
+	"2.1.5": "1.1.0"
 }

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export default class RssDashboardPlugin extends Plugin {`
`84`	`84`
`85`	`85`	`const view = await this.getActiveDashboardView();`
`86`	`86`	`if (view) {`
`87`		`- await view.render();`
	`87`	`+ view.render();`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`try {`
`@@ -194,7 +194,7 @@ export default class RssDashboardPlugin extends Plugin {`
`194`	`194`	`if (view) {`
`195`	`195`	`this.settings.sidebarCollapsed = !this.settings.sidebarCollapsed;`
`196`	`196`	`await this.saveSettings();`
`197`		`- await view.render();`
	`197`	`+ view.render();`
`198`	`198`	`}`
`199`	`199`	`},`
`200`	`200`	`});`
`@@ -377,7 +377,7 @@ export default class RssDashboardPlugin extends Plugin {`
`377`	`377`	`await this.saveSettings();`
`378`	`378`	`const view = await this.getActiveDashboardView();`
`379`	`379`	`if (view) {`
`380`		`- await view.refresh();`
	`380`	`+ view.refresh();`
`381`	`381`	new Notice(`Feeds refreshed: ${feedNoticeText}`);
`382`	`382`	`}`
`383`	`383`	`} catch (error) {`
`@@ -436,7 +436,7 @@ export default class RssDashboardPlugin extends Plugin {`
`436`	`436`	`await this.saveSettings();`
`437`	`437`	`const view = await this.getActiveDashboardView();`
`438`	`438`	`if (view) {`
`439`		`- await view.refresh();`
	`439`	`+ view.refresh();`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`if (updatedCount > 0) {`
`@@ -490,7 +490,7 @@ export default class RssDashboardPlugin extends Plugin {`
`490`	`490`
`491`	`491`	`const view = await this.getActiveDashboardView();`
`492`	`492`	`if (view) {`
`493`		`- await view.refresh();`
	`493`	`+ view.refresh();`
`494`	`494`	`}`
`495`	`495`	`}`
`496`	`496`
`@@ -607,7 +607,7 @@ export default class RssDashboardPlugin extends Plugin {`
`607`	`607`
`608`	`608`	`const view = await this.getActiveDashboardView();`
`609`	`609`	`if (view) {`
`610`		`- await view.render();`
	`610`	`+ view.render();`
`611`	`611`	`}`
`612`	`612`
`613`	`613`	new Notice(`Imported ${addedFeeds.length} feeds. Articles will be fetched in the background.`);
`@@ -704,7 +704,7 @@ export default class RssDashboardPlugin extends Plugin {`
`704`	`704`
`705`	`705`	`const view = await this.getActiveDashboardView();`
`706`	`706`	`if (view && processedCount % 3 === 0) {`
`707`		`- await view.render();`
	`707`	`+ view.render();`
`708`	`708`	`}`
`709`	`709`
`710`	`710`
`@@ -715,7 +715,7 @@ export default class RssDashboardPlugin extends Plugin {`
`715`	`715`	`await this.saveSettings();`
`716`	`716`	`const view = await this.getActiveDashboardView();`
`717`	`717`	`if (view) {`
`718`		`- await view.render();`
	`718`	`+ view.render();`
`719`	`719`	`}`
`720`	`720`
`721`	`721`
`@@ -1040,7 +1040,7 @@ export default class RssDashboardPlugin extends Plugin {`
`1040`	`1040`
`1041`	`1041`	`const view = await this.getActiveDashboardView();`
`1042`	`1042`	`if (view) {`
`1043`		`- await view.render();`
	`1043`	`+ view.render();`
`1044`	`1044`	`}`
`1045`	`1045`	`}`
`1046`	`1046`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"id": "rss-dashboard",`
`3`	`3`	`"name": "RSS Dashboard",`
`4`		`- "version": "2.1.4",`
	`4`	`+ "version": "2.1.5",`
`5`	`5`	`"minAppVersion": "1.1.0",`
`6`	`6`	`"description": "A Dashboard for organizing and consuming RSS feeds, YouTube channels, and podcasts with smart tagging, media playback, and seamless content flow.",`
`7`	`7`	`"author": "Aditya Amatya",`
Original file line number	Diff line number	Diff line change
`@@ -153,11 +153,11 @@ export class RssDashboardView extends ItemView {`
`153`	`153`	`}`
`154`	`154`
`155`	`155`
`156`		`- await this.render();`
	`156`	`+ this.render();`
`157`	`157`	`}`
`158`	`158`
`159`	`159`
`160`		`- async render(): Promise<void> {`
	`160`	`+ render(): void {`
`161`	`161`
`162`	`162`	`this.verifySavedArticles();`
`163`	`163`
`@@ -914,8 +914,8 @@ export class RssDashboardView extends ItemView {`
`914`	`914`	`}`
`915`	`915`
`916`	`916`
`917`		`- async refresh(): Promise<void> {`
`918`		`- await this.render();`
	`917`	`+ refresh(): void {`
	`918`	`+ this.render();`
`919`	`919`	`}`
`920`	`920`
`921`	`921`	`onClose(): Promise<void> {`
Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,6 @@`
`13`	`13`	`"2.1.1": "1.1.0",`
`14`	`14`	`"2.1.2": "1.1.0",`
`15`	`15`	`"2.1.3": "1.1.0",`
`16`		`- "2.1.4": "1.1.0"`
	`16`	`+ "2.1.4": "1.1.0",`
	`17`	`+ "2.1.5": "1.1.0"`
`17`	`18`	`}`