Fix handle pin clicked does not work

amay077 · amay077 · commit 50ba89d886ae · 2019-03-23T14:30:34.000+09:00
diff --git a/XFGoogleMapSample/XFGoogleMapSample/PinsPage.xaml.cs b/XFGoogleMapSample/XFGoogleMapSample/PinsPage.xaml.cs
@@ -161,10 +161,10 @@ void SelectedPin_Changed(object sender, SelectedPinChangedEventArgs e)
             labelStatus.Text = $"[{time}]SelectedPin changed - {e?.SelectedPin?.Label ?? "nothing"}";
         }
 
-        async void Map_PinClicked(object sender, PinClickedEventArgs e)
+        // DO NOT mark async method
+        // Because Xamarin.Forms.GoogleMaps wait synchronously for this callback returns.
+        void Map_PinClicked(object sender, PinClickedEventArgs e)
         {
-            await DisplayAlert("Pin Clicked", $"{e.Pin.Label} Clicked.", "Close");
-
             e.Handled = switchHandlePinClicked.IsToggled;
 
             // If you set e.Handled = true,

Original file line number	Diff line number	Diff line change
`@@ -161,10 +161,10 @@ void SelectedPin_Changed(object sender, SelectedPinChangedEventArgs e)`
`161`	`161`	`labelStatus.Text = $"[{time}]SelectedPin changed - {e?.SelectedPin?.Label ?? "nothing"}";`
`162`	`162`	`}`
`163`	`163`
`164`		`- async void Map_PinClicked(object sender, PinClickedEventArgs e)`
	`164`	`+ // DO NOT mark async method`
	`165`	`+ // Because Xamarin.Forms.GoogleMaps wait synchronously for this callback returns.`
	`166`	`+ void Map_PinClicked(object sender, PinClickedEventArgs e)`
`165`	`167`	`{`
`166`		`- await DisplayAlert("Pin Clicked", $"{e.Pin.Label} Clicked.", "Close");`
`167`		`-`
`168`	`168`	`e.Handled = switchHandlePinClicked.IsToggled;`
`169`	`169`
`170`	`170`	`// If you set e.Handled = true,`