Skip to content
This repository was archived by the owner on Oct 5, 2021. It is now read-only.

Commit 5a470fc

Browse files
Alexander PatrikalakisAlexander Patrikalakis
Alexander Patrikalakis
authored and
Alexander Patrikalakis
committed
Added checkstyle.xml and started fixing issues
1 parent 0dee9eb commit 5a470fc

File tree

89 files changed

+1425
-1604
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

89 files changed

+1425
-1604
lines changed

‎checkstyle.xml

Lines changed: 144 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
1+
<?xml version="1.0"?>
2+
<!DOCTYPE module PUBLIC
3+
"-//Puppy Crawl//DTD Check Configuration 1.2//EN"
4+
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
5+
<module name="Checker">
6+
<!-- TODO enable FileLength again when DynamoDbDelegate is refactored -->
7+
<!--<module name="FileLength">-->
8+
<!--<property name="fileExtensions" value="java"/>-->
9+
<!--<property name="max" value="750"/>-->
10+
<!--</module>-->
11+
<module name="FileTabCharacter"/>
12+
<module name="NewlineAtEndOfFile"/>
13+
<module name="RegexpSingleline">
14+
<property name="format" value="\s+$"/>
15+
<property name="message" value="Line has trailing spaces."/>
16+
</module>
17+
<module name="SuppressionCommentFilter">
18+
<property name="checkFormat" value="$1"/>
19+
<property name="offCommentFormat" value="CHECKSTYLE\:SUPPRESS\:([\w\|]+)"/>
20+
<property name="onCommentFormat" value="CHECKSTYLE\:UNSUPPRESS\:([\w\|]+)$"/>
21+
</module>
22+
<module name="Translation"/>
23+
<module name="TreeWalker">
24+
<module name="AbbreviationAsWordInName">
25+
<property name="allowedAbbreviationLength" value="2"/>
26+
</module>
27+
<module name="ArrayTypeStyle"/>
28+
<module name="AvoidInlineConditionals"/>
29+
<module name="AvoidNestedBlocks"/>
30+
<module name="AvoidStarImport"/>
31+
<module name="AvoidStaticImport">
32+
<property name="excludes" value="com.google.common.base.Preconditions.*,junit.org.Assert.*,org.mockito.Mockito.*,org.janusgraph.diskstorage.configuration.ConfigOption.Type.*"/>
33+
</module>
34+
<module name="ClassTypeParameterName"/>
35+
<module name="ConstantName"/>
36+
<module name="CovariantEquals"/>
37+
<module name="DefaultComesLast"/>
38+
<module name="EmptyBlock"/>
39+
<module name="EmptyCatchBlock"/>
40+
<module name="EmptyForInitializerPad"/>
41+
<module name="EmptyForIteratorPad"/>
42+
<module name="EmptyStatement"/>
43+
<module name="EqualsAvoidNull"/>
44+
<module name="EqualsHashCode"/>
45+
<module name="FallThrough"/>
46+
<module name="FileContentsHolder"/>
47+
<module name="FinalClass"/>
48+
<module name="FinalLocalVariable"/>
49+
<module name="FinalParameters"/>
50+
<module name="GenericWhitespace"/>
51+
<module name="HiddenField">
52+
<property name="ignoreConstructorParameter" value="true"/>
53+
<property name="ignoreSetter" value="true"/>
54+
</module>
55+
<module name="HideUtilityClassConstructor"/>
56+
<module name="IllegalImport">
57+
<property name="illegalPkgs" value="edu.emory.mathcs.backport, sun" />
58+
</module>
59+
<module name="IllegalInstantiation"/>
60+
<module name="IllegalThrows"/>
61+
<module name="InnerAssignment"/>
62+
<module name="InterfaceIsType"/>
63+
<!-- TODO renable and add javadoc later-->
64+
<!--<module name="JavadocMethod">-->
65+
<!--<property name="allowUndeclaredRTE" value="true"/>-->
66+
<!--<property name="scope" value="public"/>-->
67+
<!--</module>-->
68+
<!--<module name="JavadocStyle"/>-->
69+
<!--<module name="JavadocType">-->
70+
<!--<property name="scope" value="public"/>-->
71+
<!--</module>-->
72+
<module name="LeftCurly"/>
73+
<module name="LineLength">
74+
<property name="max" value="200"/>
75+
</module>
76+
<module name="LocalFinalVariableName"/>
77+
<module name="LocalVariableName"/>
78+
<module name="MagicNumber"/>
79+
<module name="MemberName"/>
80+
<module name="MethodCount"/>
81+
<module name="MethodLength"/>
82+
<module name="MethodName"/>
83+
<module name="MethodParamPad"/>
84+
<module name="MissingSwitchDefault"/>
85+
<module name="ModifiedControlVariable"/>
86+
<module name="ModifierOrder"/>
87+
<module name="MultipleVariableDeclarations"/>
88+
<module name="NeedBraces"/>
89+
<module name="NestedForDepth">
90+
<property name="max" value="2"/>
91+
</module>
92+
<module name="NestedIfDepth">
93+
<property name="max" value="2"/>
94+
</module>
95+
<module name="NestedTryDepth">
96+
<property name="max" value="1"/>
97+
</module>
98+
<module name="NoLineWrap"/>
99+
<module name="NoClone"/>
100+
<module name="NoFinalizer"/>
101+
<module name="NoWhitespaceAfter"/>
102+
<module name="NoWhitespaceBefore"/>
103+
<module name="OneStatementPerLine"/>
104+
<module name="OneTopLevelClass"/>
105+
<module name="OperatorWrap"/>
106+
<module name="OuterTypeNumber"/>
107+
<module name="PackageDeclaration"/>
108+
<module name="PackageName"/>
109+
<module name="ParameterAssignment"/>
110+
<module name="ParameterName"/>
111+
<module name="ParenPad"/>
112+
<module name="RedundantImport"/>
113+
<module name="RedundantModifier"/>
114+
<module name="RightCurly"/>
115+
<module name="SeparatorWrap">
116+
<property name="option" value="EOL"/>
117+
<property name="tokens" value="COMMA"/>
118+
</module>
119+
<module name="SeparatorWrap">
120+
<property name="option" value="nl"/>
121+
<property name="tokens" value="DOT"/>
122+
</module>
123+
<module name="SimplifyBooleanExpression"/>
124+
<module name="SimplifyBooleanReturn"/>
125+
<module name="StaticVariableName"/>
126+
<module name="StringLiteralEquality"/>
127+
<module name="ThrowsCount">
128+
<property name="max" value="5"/>
129+
</module>
130+
<module name="TodoComment">
131+
<property name="severity" value="info"/>
132+
</module>
133+
<module name="TypecastParenPad"/>
134+
<module name="TypeName"/>
135+
<module name="UnnecessaryParentheses"/>
136+
<module name="UnusedImports"/>
137+
<module name="UpperEll"/>
138+
<module name="VisibilityModifier">
139+
<property name="protectedAllowed" value="true"/>
140+
</module>
141+
<module name="WhitespaceAfter"/>
142+
<module name="WhitespaceAround"/>
143+
</module>
144+
</module>

‎pom.xml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,27 @@
198198
</dependencies>
199199
<build>
200200
<plugins>
201+
<!-- TODO uncomment to find and fix more checkstyle issues -->
202+
<plugin>
203+
<groupId>org.apache.maven.plugins</groupId>
204+
<artifactId>maven-checkstyle-plugin</artifactId>
205+
<version>2.17</version>
206+
<executions>
207+
<execution>
208+
<id>validate</id>
209+
<phase>validate</phase>
210+
<configuration>
211+
<configLocation>checkstyle.xml</configLocation>
212+
<encoding>UTF-8</encoding>
213+
<consoleOutput>true</consoleOutput>
214+
<failsOnError>true</failsOnError>
215+
</configuration>
216+
<goals>
217+
<goal>check</goal>
218+
</goals>
219+
</execution>
220+
</executions>
221+
</plugin>
201222
<plugin>
202223
<groupId>org.apache.maven.plugins</groupId>
203224
<artifactId>maven-pmd-plugin</artifactId>

0 commit comments

Comments
 (0)