Skip to content

Commit 7cdf62c

Browse files
committed
Fix _updateSpeakerIdInLcms to pass in generatedSpeakerId
cr: https://code.amazon.com/reviews/CR-81414768
1 parent afd305b commit 7cdf62c

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

release/connect-streams-min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

release/connect-streams.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3795,7 +3795,8 @@ module.exports = cloneDeep;
37953795
client.call(connect.AgentAppClientMethods.UPDATE_SESSION, params, {
37963796
success: function (data) {
37973797
connect.getLog().info("updateSpeakerIdInVoiceId succeeded").withObject(data).sendInternalLogToServer();
3798-
self._updateSpeakerIdInLcms(speakerId, data.generatedSpeakerId)
3798+
var generatedSpeakerId = data && data.Session && data.Session.GeneratedSpeakerId;
3799+
self._updateSpeakerIdInLcms(speakerId, generatedSpeakerId)
37993800
.then(function() {
38003801
resolve(data);
38013802
})

src/api.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1846,7 +1846,8 @@
18461846
client.call(connect.AgentAppClientMethods.UPDATE_SESSION, params, {
18471847
success: function (data) {
18481848
connect.getLog().info("updateSpeakerIdInVoiceId succeeded").withObject(data).sendInternalLogToServer();
1849-
self._updateSpeakerIdInLcms(speakerId, data.generatedSpeakerId)
1849+
var generatedSpeakerId = data && data.Session && data.Session.GeneratedSpeakerId;
1850+
self._updateSpeakerIdInLcms(speakerId, generatedSpeakerId)
18501851
.then(function() {
18511852
resolve(data);
18521853
})

test/unit/voiceid.spec.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,7 +1161,11 @@ describe('VoiceId', () => {
11611161

11621162
describe('updateSpeakerIdInVoiceId', () => {
11631163
it('should get resolved with data', async () => {
1164-
const response = 'fakeData';
1164+
const response = {
1165+
Session: {
1166+
GeneratedSpeakerId: 'dummy-generated-speaker-id'
1167+
}
1168+
};
11651169
sinon.stub(connect.core, 'getClient').callsFake(() => ({
11661170
call: (endpoint, params, callbacks) => {
11671171
callbacks.success(response);
@@ -1175,7 +1179,7 @@ describe('VoiceId', () => {
11751179
expect(obj).to.equal(response);
11761180
sinon.assert.calledOnce(voiceId.checkConferenceCall);
11771181
sinon.assert.calledOnce(voiceId.getDomainId);
1178-
sinon.assert.calledOnce(voiceId._updateSpeakerIdInLcms);
1182+
sinon.assert.calledWith(voiceId._updateSpeakerIdInLcms, speakerId, 'dummy-generated-speaker-id');
11791183
connect.core.getClient.restore();
11801184
});
11811185

0 commit comments

Comments
 (0)