Improve logging

Author: barshaul

redis/src/aio/connection.rs

@@ -444,6 +444,16 @@ pub(crate) async fn get_socket_addrs(
     }
 }
 
+fn log_conn_creation<T>(conn_type: &str, node: T, ip: Option<IpAddr>)
+where
+    T: std::fmt::Debug,
+{
+    info!(
+        "Creating {conn_type} connection for node: {node:?}{}",
+        ip.map(|ip| format!(", IP: {:?}", ip)).unwrap_or_default()
+    );
+}
+
 pub(crate) async fn connect_simple<T: RedisRuntime>(
     connection_info: &ConnectionInfo,
     _socket_addr: Option<SocketAddr>,
@@ -458,7 +468,7 @@ pub(crate) async fn connect_simple<T: RedisRuntime>(
             }
             let socket_addrs = get_socket_addrs(host, port).await?;
             select_ok(socket_addrs.map(|socket_addr| {
-                info!("IP of node {:?} is {:?}", host, socket_addr.ip());
+                log_conn_creation("TCP", host, Some(socket_addr.ip()));
                 Box::pin(async move {
                     Ok::<_, RedisError>((
                         <T>::connect_tcp(socket_addr).await?,
@@ -485,7 +495,7 @@ pub(crate) async fn connect_simple<T: RedisRuntime>(
             }
             let socket_addrs = get_socket_addrs(host, port).await?;
             select_ok(socket_addrs.map(|socket_addr| {
-                info!("IP of node {:?} is {:?}", host, socket_addr.ip());
+                log_conn_creation("TCP with TLS", host, Some(socket_addr.ip()));
                 Box::pin(async move {
                     Ok::<_, RedisError>((
                         <T>::connect_tcp_tls(host, socket_addr, insecure, tls_params).await?,
@@ -506,7 +516,10 @@ pub(crate) async fn connect_simple<T: RedisRuntime>(
         }
 
         #[cfg(unix)]
-        ConnectionAddr::Unix(ref path) => (<T>::connect_unix(path).await?, None),
+        ConnectionAddr::Unix(ref path) => {
+            log_conn_creation("UDS", path, None);
+            (<T>::connect_unix(path).await?, None)
+        }
 
         #[cfg(not(unix))]
         ConnectionAddr::Unix(_) => {

redis/src/cluster_topology.rs

@@ -16,6 +16,7 @@ use std::sync::Arc;
 use std::time::{Duration, SystemTime};
 #[cfg(all(feature = "cluster-async", feature = "tokio-comp"))]
 use tokio::sync::RwLock;
+use tracing::info;
 
 // Exponential backoff constants for retrying a slot refresh
 /// The default number of refresh topology retries in the same call
@@ -260,8 +261,11 @@ pub(crate) fn calculate_topology<'a>(
     }
 
     let parse_and_built_result = |most_frequent_topology: TopologyView| {
+        info!(
+            "calculate_topology found topology map:\n{:?}",
+            most_frequent_topology
+        );
         let slots_data = most_frequent_topology.slots_and_count.1;
-
         Ok((
             SlotMap::new(slots_data, read_from_replica),
             most_frequent_topology.hash_value,