Follow-up fix to 14655

Follow-up to rabbitmq#14655

The code to format `cacerts` and `certs_keys` needs to check if the
incoming value is a list or map, and skip it if not. This is the same
pattern as used in a later function head:

```
format_socket_opts([Head = {Name, Value} | Tail], Acc) when is_list(Value) ->
```

It ensures that the code won't be called again on an already-formatted
value.

Author: lukebakken

deps/rabbitmq_management/src/rabbit_mgmt_wm_overview.erl

@@ -126,10 +126,10 @@ web_contexts(ReqData) ->
       ["description", "port", "node"]).
 
 fmt_contexts(Node) ->
-    [fmt_context(Node, C) || C <- pget(contexts, Node, [])].
+  [fmt_context(Node, C) || C <- pget(contexts, Node, [])].
 
 fmt_context(Node, C) ->
-  rabbit_mgmt_format:web_context([{node, pget(name, Node)} | C]).
+    rabbit_mgmt_format:web_context([{node, pget(name, Node)} | C]).
 
 erlang_version() -> list_to_binary(rabbit_misc:otp_release()).
 

deps/rabbitmq_management_agent/src/rabbit_mgmt_format.erl

@@ -318,16 +318,16 @@ format_socket_opts([{user_lookup_fun, _Value} | Tail], Acc) ->
 format_socket_opts([{sni_fun, _Value} | Tail], Acc) ->
     format_socket_opts(Tail, Acc);
 %% https://www.erlang.org/doc/apps/ssl/ssl.html#t:server_option_cert/0
-format_socket_opts([{cacerts, Cacerts} | Tail], Acc) ->
+format_socket_opts([{cacerts, Cacerts} | Tail], Acc) when is_list(Cacerts) ->
     CacertsMsg = rabbit_data_coercion:to_utf8_binary(
         io_lib:format("(~b cacerts entries)", [length(Cacerts)])),
     format_socket_opts(Tail, [{cacerts, CacertsMsg} | Acc]);
 %% https://www.erlang.org/doc/apps/ssl/ssl.html#t:common_option_cert/0
 %% https://www.erlang.org/doc/apps/ssl/ssl.html#t:cert_key_conf/0
-format_socket_opts([{certs_keys, CertsKeys} | Tail], Acc)  ->
+format_socket_opts([{certs_keys, CertsKeys} | Tail], Acc) when is_map(CertsKeys) ->
     CertsKeysMsg = rabbit_data_coercion:to_utf8_binary(
         io_lib:format("(~b certs_keys entries)", [length(CertsKeys)])),
-    format_socket_opts(Tail, [{cacerts, CertsKeysMsg} | Acc]);
+    format_socket_opts(Tail, [{certs_keys, CertsKeysMsg} | Acc]);
 %% we do not report SNI host details in the UI,
 %% so skip this option and avoid some recursive formatting
 %% complexity