Skip to content

Commit acf29e2

Browse files
authored
Merge pull request #13 from ambarltd/parsing
Simplify request parsing
2 parents 4cc093d + 471a7ce commit acf29e2

File tree

3 files changed

+7
-36
lines changed

3 files changed

+7
-36
lines changed

application/backend-credit-card-enrollment/backend-typescript/src/common/util/ParseWithValidation.ts

Lines changed: 0 additions & 25 deletions
This file was deleted.

application/backend-credit-card-enrollment/backend-typescript/src/creditCard/enrollment/command/EnrollmentCommandController.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@ import { PostgresTransactionalEventStore } from '../../../common/eventStore/Post
44
import { MongoTransactionalProjectionOperator } from '../../../common/projection/MongoTransactionalProjectionOperator';
55
import { RequestEnrollmentCommandHandler } from './RequestEnrollmentCommandHandler';
66
import { RequestEnrollmentCommand } from './RequestEnrollmentCommand';
7-
import {requestEnrollmentHttpRequestSchema} from './RequestEnrollmentHttpRequest';
87
import {inject, injectable} from "tsyringe";
9-
import {parseWithValidation} from "../../../common/util/ParseWithValidation";
8+
import { z } from 'zod';
109

1110
@injectable()
1211
export class EnrollmentCommandController extends CommandController {
@@ -32,7 +31,7 @@ export class EnrollmentCommandController extends CommandController {
3231
return;
3332
}
3433

35-
const requestBody = parseWithValidation(req.body, requestEnrollmentHttpRequestSchema);
34+
const requestBody = requestSchema.parse(req.body);
3635
const command = new RequestEnrollmentCommand(
3736
sessionToken,
3837
requestBody.productId,
@@ -43,3 +42,8 @@ export class EnrollmentCommandController extends CommandController {
4342
res.status(200).json({});
4443
}
4544
}
45+
46+
const requestSchema = z.object({
47+
productId: z.string(),
48+
annualIncomeInCents: z.number().min(0, "Annual income cannot be negative").max(1_000_000_000, "Annual income is too high")
49+
});

application/backend-credit-card-enrollment/backend-typescript/src/creditCard/enrollment/command/RequestEnrollmentHttpRequest.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)