Add more logs to csharp example

galeaspablo · galeaspablo · commit ddcc09285ed3 · 2025-01-04T19:32:59.000Z
diff --git a/application/backend-credit-card-enrollment/backend-c#/Common/Command/CommandController.cs b/application/backend-credit-card-enrollment/backend-c#/Common/Command/CommandController.cs
@@ -29,6 +29,7 @@ protected void ProcessCommand(Command command, CommandHandler commandHandler) {
 
             _postgresTransactionalEventStore.AbortDanglingTransactionsAndReturnConnectionToPool();
             _mongoTransactionalProjectionOperator.AbortDanglingTransactionsAndReturnSessionToPool();
+            _logger.LogDebug("Successfully processed command: {CommandType}", command.GetType().Name);
         } catch (Exception ex) {
             _postgresTransactionalEventStore.AbortDanglingTransactionsAndReturnConnectionToPool();
             _mongoTransactionalProjectionOperator.AbortDanglingTransactionsAndReturnSessionToPool();
diff --git a/application/backend-credit-card-enrollment/backend-c#/Common/EventStore/PostgresTransactionalEventStore.cs b/application/backend-credit-card-enrollment/backend-c#/Common/EventStore/PostgresTransactionalEventStore.cs
@@ -11,19 +11,22 @@ public class PostgresTransactionalEventStore
     private readonly Serializer _serializer;
     private readonly Deserializer _deserializer;
     private readonly string _eventStoreTable;
+    private readonly ILogger<PostgresTransactionalEventStore> _logger;
     private NpgsqlConnection? _connection;
     private NpgsqlTransaction? _activeTransaction;
 
     public PostgresTransactionalEventStore(
         PostgresConnectionPool connectionPool,
         Serializer serializer,
         Deserializer deserializer,
-        string eventStoreTable
+        string eventStoreTable,
+        ILogger<PostgresTransactionalEventStore> logger
     ) {
         _connectionPool = connectionPool;
         _serializer = serializer;
         _deserializer = deserializer;
         _eventStoreTable = eventStoreTable;
+        _logger = logger;
         _connection = null;
         _activeTransaction = null;
     }
@@ -125,7 +128,7 @@ public void AbortDanglingTransactionsAndReturnConnectionToPool()
                 _activeTransaction.Rollback();
                 _activeTransaction = null;
             } catch (Exception ex) {
-                // todo log error
+                _logger.LogError(ex, "Failed to rollback PG transaction");
             }
         }
         
@@ -134,7 +137,7 @@ public void AbortDanglingTransactionsAndReturnConnectionToPool()
                 _connection.Close();
                 _connection = null;
             } catch (Exception ex) {
-                // todo log error
+                _logger.LogError(ex, "Failed to release PG connection");
             }
         }
     }
@@ -192,7 +195,6 @@ private void SaveSerializedEvent(SerializedEvent.SerializedEvent serializedEvent
         try {
             command.ExecuteNonQuery();
         } catch (Exception ex) {
-            // todo log error
             throw new Exception($"Failed to save event: {serializedEvent.EventId}", ex);
         }
     }
diff --git a/application/backend-credit-card-enrollment/backend-c#/Common/Projection/MongoTransactionalProjectorOperator.cs b/application/backend-credit-card-enrollment/backend-c#/Common/Projection/MongoTransactionalProjectorOperator.cs
@@ -7,12 +7,18 @@ namespace CreditCardEnrollment.Common.Projection;
 public class MongoTransactionalProjectionOperator {
     private readonly MongoSessionPool _sessionPool;
     private readonly string _databaseName;
+    private readonly ILogger<MongoTransactionalProjectionOperator> _logger;
     private IClientSessionHandle? _session;
     private IMongoDatabase? _database;
 
-    public MongoTransactionalProjectionOperator(MongoSessionPool sessionPool, string databaseName) {
+    public MongoTransactionalProjectionOperator(
+        MongoSessionPool sessionPool,
+        string databaseName, 
+        ILogger<MongoTransactionalProjectionOperator> logger
+    ) {
         _sessionPool = sessionPool;
         _databaseName = databaseName;
+        _logger = logger;
         _session = null;
         _database = null;
     }
@@ -69,13 +75,13 @@ public void AbortDanglingTransactionsAndReturnSessionToPool() {
                 _session.AbortTransaction();
             }
         } catch (Exception ex) {
-            // todo: log error
+            _logger.LogError(ex, "Failed to abort Mongo transaction");
         }
 
         try {
             _session.Dispose();
         } catch (Exception ex) {
-            // todo: log error
+            _logger.LogError(ex, "Failed to release Mongo session");
         }
 
         _session = null;
diff --git a/application/backend-credit-card-enrollment/backend-c#/Common/Projection/ProjectionController.cs b/application/backend-credit-card-enrollment/backend-c#/Common/Projection/ProjectionController.cs
@@ -24,7 +24,11 @@ protected string ProcessProjectionHttpRequest(
         ProjectionHandler projectionHandler,
         string projectionName) {
         try {
-            _logger.LogDebug("Starting to process projection for event name: {EventName}", ambarHttpRequest.SerializedEvent.EventName);
+            _logger.LogDebug(
+                "Starting to process projection for event name: {EventName} using handler: {HandlerName}", 
+                ambarHttpRequest.SerializedEvent.EventName,
+                projectionHandler.GetType().Name
+            );
             var @event = _deserializer.Deserialize(ambarHttpRequest.SerializedEvent);
 
             _mongoOperator.StartTransaction();
@@ -37,6 +41,11 @@ protected string ProcessProjectionHttpRequest(
 
             if (isAlreadyProjected) {
                 _mongoOperator.AbortDanglingTransactionsAndReturnSessionToPool();
+                _logger.LogDebug(
+                    "Duplication projection ignored for event name: {EventName} using handler: {HandlerName}", 
+                    ambarHttpRequest.SerializedEvent.EventName,
+                    projectionHandler.GetType().Name
+                );
                 return AmbarResponseFactory.SuccessResponse();
             }
 
@@ -54,13 +63,30 @@ protected string ProcessProjectionHttpRequest(
             _mongoOperator.CommitTransaction();
             _mongoOperator.AbortDanglingTransactionsAndReturnSessionToPool();
 
+            _logger.LogDebug(
+                "Projection successfully processed for event name: {EventName} using handler: {HandlerName}", 
+                ambarHttpRequest.SerializedEvent.EventName,
+                projectionHandler.GetType().Name
+            );
             return AmbarResponseFactory.SuccessResponse();
         } catch (Exception ex) when (ex.Message?.StartsWith("Unknown event type") == true) {
             _mongoOperator.AbortDanglingTransactionsAndReturnSessionToPool();
+            
+            _logger.LogDebug(
+                "Unknown event in projection ignored for event name: {EventName} using handler: {HandlerName}", 
+                ambarHttpRequest.SerializedEvent.EventName,
+                projectionHandler.GetType().Name
+            );
             return AmbarResponseFactory.SuccessResponse();
         } catch (Exception ex) {
             _mongoOperator.AbortDanglingTransactionsAndReturnSessionToPool();
-            _logger.LogError("Exception in ProcessProjectionHttpRequest: {0}, {1}", ex.Message, ex.StackTrace);
+            _logger.LogError(
+                "Exception in ProcessProjectionHttpRequest: {0}, {1}. For event name: {EventName} using handler: {HandlerName}", 
+                ex.Message, 
+                ex.StackTrace,
+                ambarHttpRequest.SerializedEvent.EventName,
+                projectionHandler.GetType().Name
+            );
             return AmbarResponseFactory.RetryResponse(ex);
         }
     }
diff --git a/application/backend-credit-card-enrollment/backend-c#/Common/Query/QueryController.cs b/application/backend-credit-card-enrollment/backend-c#/Common/Query/QueryController.cs
@@ -22,6 +22,7 @@ protected object ProcessQuery(Query query, QueryHandler queryHandler) {
             _mongoTransactionalProjectionOperator.CommitTransaction();
             _mongoTransactionalProjectionOperator.AbortDanglingTransactionsAndReturnSessionToPool();
 
+            _logger.LogDebug("Successfully processed query: {QueryType}", query.GetType().Name);
             return result;
         } catch (Exception ex) {
             _mongoTransactionalProjectionOperator.AbortDanglingTransactionsAndReturnSessionToPool();
diff --git a/application/backend-credit-card-enrollment/backend-c#/Common/Reaction/ReactionController.cs b/application/backend-credit-card-enrollment/backend-c#/Common/Reaction/ReactionController.cs
@@ -25,7 +25,11 @@ ILogger<ReactionController> logger
 
     protected string ProcessReactionHttpRequest(AmbarHttpRequest ambarHttpRequest, ReactionHandler reactionHandler) {
         try {
-            _logger.LogDebug("Starting to process reaction for event name: {EventName}", ambarHttpRequest.SerializedEvent.EventName);
+            _logger.LogDebug(
+                "Starting to process reaction for event name: {EventName} using handler: {HandlerName}", 
+                ambarHttpRequest.SerializedEvent.EventName,
+                reactionHandler.GetType().Name
+            );
             _postgresTransactionalEventStore.BeginTransaction();
             _mongoTransactionalProjectionOperator.StartTransaction();
             reactionHandler.React(_deserializer.Deserialize(ambarHttpRequest.SerializedEvent));
@@ -35,6 +39,11 @@ protected string ProcessReactionHttpRequest(AmbarHttpRequest ambarHttpRequest, R
             _postgresTransactionalEventStore.AbortDanglingTransactionsAndReturnConnectionToPool();
             _mongoTransactionalProjectionOperator.AbortDanglingTransactionsAndReturnSessionToPool();
 
+            _logger.LogDebug(
+                "Reaction successfully processed for event name: {EventName} using handler: {HandlerName}", 
+                ambarHttpRequest.SerializedEvent.EventName,
+                reactionHandler.GetType().Name
+            );
             return AmbarResponseFactory.SuccessResponse();
         } catch (Exception ex) when (ex.Message?.StartsWith("Unknown event type") == true) {
             _postgresTransactionalEventStore.AbortDanglingTransactionsAndReturnConnectionToPool();
diff --git a/application/backend-credit-card-enrollment/backend-c#/Program.cs b/application/backend-credit-card-enrollment/backend-c#/Program.cs
@@ -26,8 +26,9 @@
     var deserializer = provider.GetRequiredService<Deserializer>();
     var serializer = provider.GetRequiredService<Serializer>();
     var eventStoreTable = postgresTableName; 
+    var logger = provider.GetRequiredService<ILogger<PostgresTransactionalEventStore>>();
 
-    return new PostgresTransactionalEventStore(pool, serializer, deserializer, eventStoreTable);
+    return new PostgresTransactionalEventStore(pool, serializer, deserializer, eventStoreTable, logger);
 });
 
 var mongoConnectionString = 
@@ -40,7 +41,8 @@
 builder.Services.AddScoped<MongoTransactionalProjectionOperator>(provider =>
 {
     var sessionPool = provider.GetRequiredService<MongoSessionPool>();
-    return new MongoTransactionalProjectionOperator(sessionPool, mongoDatabaseName);
+    var logger = provider.GetRequiredService<ILogger<MongoTransactionalProjectionOperator>>();
+    return new MongoTransactionalProjectionOperator(sessionPool, mongoDatabaseName, logger);
 });
 
 AddScopedInheritors<CommandController>(builder.Services);
