chore: apply black/isort formatting from rebase

jeremyeder · claude · jeremyeder · commit 0fe6430b2011 · 2025-11-24T10:33:18.000-05:00
Fix formatting issues that emerged after rebasing on main. Auto-formatters (black, isort, ruff --fix) applied to ensure CI passes. Changes: - Black reformatted 12 files - isort organized imports - ruff removed unused imports (align.py) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/batch-repos.txt b/batch-repos.txt
@@ -0,0 +1,3 @@
+https://github.com/ambient-code/agentready
+https://github.com/ambient-code/platform
+https://github.com/ambient-code/spec-kit-rh
diff --git a/src/agentready/cli/align.py b/src/agentready/cli/align.py
@@ -6,9 +6,7 @@
 import click
 
 from ..models.config import Config
-from ..models.repository import Repository
 from ..services.fixer_service import FixerService
-from ..services.language_detector import LanguageDetector
 from ..services.scanner import Scanner
 
 
diff --git a/src/agentready/models/batch_assessment.py b/src/agentready/models/batch_assessment.py
@@ -2,7 +2,6 @@
 
 from dataclasses import dataclass, field
 from datetime import datetime
-from pathlib import Path
 
 from .assessment import Assessment
 
diff --git a/src/agentready/reporters/csv_reporter.py b/src/agentready/reporters/csv_reporter.py
@@ -112,7 +112,9 @@ def generate(
                     # SECURITY: Sanitize all string fields
                     row = {
                         "repo_url": self.sanitize_csv_field(result.repository_url),
-                        "repo_name": self.sanitize_csv_field(assessment.repository.name),
+                        "repo_name": self.sanitize_csv_field(
+                            assessment.repository.name
+                        ),
                         "overall_score": assessment.overall_score,
                         "certification_level": self.sanitize_csv_field(
                             assessment.certification_level
diff --git a/src/agentready/services/assessment_cache.py b/src/agentready/services/assessment_cache.py
@@ -6,7 +6,7 @@
 from pathlib import Path
 from typing import Optional
 
-from ..models import Assessment, BatchAssessment, RepositoryResult
+from ..models import Assessment
 
 
 class AssessmentCache:
@@ -230,7 +230,9 @@ def get_stats(self) -> dict:
                 )
                 valid = cursor.fetchone()[0]
 
-                cursor = conn.execute("SELECT COUNT(DISTINCT repository_url) FROM assessments")
+                cursor = conn.execute(
+                    "SELECT COUNT(DISTINCT repository_url) FROM assessments"
+                )
                 unique_repos = cursor.fetchone()[0]
 
                 return {
@@ -258,7 +260,6 @@ def _deserialize_assessment(data: dict) -> Assessment:
         # In practice, you'd need full deserialization logic
         # For now, we'll use a placeholder that assumes the cached JSON
         # has the correct structure
-        from .scanner import Scanner
 
         # Note: This is a simplified approach. In production, you'd need
         # proper deserialization that reconstructs all nested objects
diff --git a/src/agentready/services/batch_scanner.py b/src/agentready/services/batch_scanner.py
@@ -6,7 +6,7 @@
 from typing import Callable, Optional
 from uuid import uuid4
 
-from ..models import Assessment, BatchAssessment, BatchSummary, RepositoryResult
+from ..models import BatchAssessment, BatchSummary, RepositoryResult
 from .assessment_cache import AssessmentCache
 from .repository_manager import RepositoryManager
 from .scanner import Scanner
diff --git a/src/agentready/services/github_scanner.py b/src/agentready/services/github_scanner.py
@@ -146,9 +146,7 @@ def get_org_repos(
                 response.raise_for_status()
 
             except requests.Timeout:
-                raise GitHubAPIError(
-                    f"GitHub API timeout for organization: {org_name}"
-                )
+                raise GitHubAPIError(f"GitHub API timeout for organization: {org_name}")
 
             except requests.HTTPError as e:
                 # SECURITY: Redact token before raising
diff --git a/tests/integration/test_github_integration.py b/tests/integration/test_github_integration.py
@@ -1,9 +1,9 @@
 """Integration tests for GitHub scanner (requires GITHUB_TOKEN)."""
 
 import os
+import urllib.parse
 
 import pytest
-import urllib.parse
 
 from agentready.services.github_scanner import GitHubOrgScanner
 
diff --git a/tests/security/test_xss_prevention.py b/tests/security/test_xss_prevention.py
@@ -57,9 +57,7 @@ def create_test_batch_with_payload(payload: str, inject_location: str):
     )
 
     repo_url = (
-        "https://github.com/test/repo"
-        if inject_location != "repo_url"
-        else payload
+        "https://github.com/test/repo" if inject_location != "repo_url" else payload
     )
     error = payload if inject_location == "error_message" else None
 
diff --git a/tests/unit/cli/test_main.py b/tests/unit/cli/test_main.py
@@ -1,8 +1,5 @@
 """Unit tests for main CLI commands."""
 
-import json
-import shutil
-import tempfile
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -18,7 +15,6 @@
     load_config,
     research_version,
     run_assessment,
-    show_version,
 )
 from agentready.models.config import Config
 
diff --git a/tests/unit/learners/test_skill_generator.py b/tests/unit/learners/test_skill_generator.py
@@ -1,6 +1,5 @@
 """Unit tests for skill generation."""
 
-import json
 from pathlib import Path
 
 import pytest
diff --git a/tests/unit/test_assessment_cache.py b/tests/unit/test_assessment_cache.py
@@ -1,9 +1,8 @@
 """Unit tests for assessment cache."""
 
-import pytest
 from pathlib import Path
 from tempfile import TemporaryDirectory
-from datetime import datetime, timedelta
+
 
 from agentready.services.assessment_cache import AssessmentCache
 
diff --git a/tests/unit/test_cli_extract_skills.py b/tests/unit/test_cli_extract_skills.py
@@ -64,7 +64,9 @@ def test_extract_skills_command_basic(self, runner, temp_repo):
     def test_extract_skills_command_json_output(self, runner, temp_repo):
         """Test extract-skills command with JSON output."""
         with runner.isolated_filesystem(temp_dir=temp_repo.parent):
-            result = runner.invoke(extract_skills, [str(temp_repo), "--output-format", "json"])
+            result = runner.invoke(
+                extract_skills, [str(temp_repo), "--output-format", "json"]
+            )
 
             assert result.exit_code == 0
 
@@ -104,7 +106,9 @@ def test_extract_skills_command_github_issues_output(self, runner, temp_repo):
     def test_extract_skills_command_all_output_formats(self, runner, temp_repo):
         """Test extract-skills command with all output formats."""
         with runner.isolated_filesystem(temp_dir=temp_repo.parent):
-            result = runner.invoke(extract_skills, [str(temp_repo), "--output-format", "all"])
+            result = runner.invoke(
+                extract_skills, [str(temp_repo), "--output-format", "all"]
+            )
 
             assert result.exit_code == 0
 
diff --git a/tests/unit/test_csv_reporter.py b/tests/unit/test_csv_reporter.py
@@ -234,7 +234,9 @@ def test_csv_formula_injection_in_repo_name(
     ):
         """Test that formula injection in repo name is prevented."""
         # Modify repository name to contain formula
-        mock_batch_assessment.results[0].assessment.repository.name = "=cmd|'/c calc'!A1"
+        mock_batch_assessment.results[0].assessment.repository.name = (
+            "=cmd|'/c calc'!A1"
+        )
 
         reporter = CSVReporter()
         reporter.generate(mock_batch_assessment, temp_csv_file)
diff --git a/tests/unit/test_fixer_service.py b/tests/unit/test_fixer_service.py
@@ -8,10 +8,7 @@
 from agentready.fixers.base import BaseFixer
 from agentready.models import Assessment, Attribute, Finding, Repository
 from agentready.models.fix import (
-    CommandFix,
     FileCreationFix,
-    FileModificationFix,
-    MultiStepFix,
 )
 from agentready.services.fixer_service import FixerService, FixPlan
 
diff --git a/tests/unit/test_github_scanner.py b/tests/unit/test_github_scanner.py
@@ -1,6 +1,5 @@
 """Unit tests for GitHub organization scanner."""
 
-import os
 from unittest.mock import Mock, patch
 
 import pytest
@@ -452,4 +451,6 @@ def test_rate_limit_warning(mock_get, caplog):
 
         assert len(repos) == 1
         # Should have logged a warning about low rate limit
-        assert any("rate limit low" in record.message.lower() for record in caplog.records)
+        assert any(
+            "rate limit low" in record.message.lower() for record in caplog.records
+        )
diff --git a/tests/unit/test_multi_html_reporter.py b/tests/unit/test_multi_html_reporter.py
@@ -175,9 +175,9 @@ def test_generate_html_xss_prevention_repo_name(
     ):
         """Test that XSS in repository name is prevented."""
         # Inject XSS payload into repository name
-        mock_batch_assessment.results[
-            0
-        ].assessment.repository.name = "<script>alert('XSS')</script>"
+        mock_batch_assessment.results[0].assessment.repository.name = (
+            "<script>alert('XSS')</script>"
+        )
 
         reporter = MultiRepoHTMLReporter(template_dir)
         reporter.generate(mock_batch_assessment, temp_html_file)
diff --git a/tests/unit/test_repository_manager.py b/tests/unit/test_repository_manager.py
@@ -1,9 +1,9 @@
 """Unit tests for repository manager."""
 
-import pytest
 from pathlib import Path
 from tempfile import TemporaryDirectory
 
+
 from agentready.services.repository_manager import RepositoryManager
 
 
@@ -73,9 +73,7 @@ def test_get_repository_name_from_https_url(self):
     def test_get_repository_name_from_url_without_git_suffix(self):
         """Test extracting repository name from URL without .git suffix."""
         manager = RepositoryManager(Path("/tmp/cache"))
-        name = manager.get_repository_name_from_url(
-            "https://github.com/user/my-repo"
-        )
+        name = manager.get_repository_name_from_url("https://github.com/user/my-repo")
         assert name == "my-repo"
 
     def test_get_repository_name_from_local_path(self):
diff --git a/tests/unit/test_security.py b/tests/unit/test_security.py
@@ -310,9 +310,8 @@ class TestGitHubTokenSecurity:
 
     def test_token_not_in_logs(self, caplog):
         """Test that token never appears in logs."""
-        from unittest.mock import Mock, patch
+        from unittest.mock import patch
 
-        import requests
 
         from agentready.services.github_scanner import GitHubOrgScanner
 
@@ -367,9 +366,8 @@ def test_token_not_in_error_messages(self):
 
     def test_token_format_validation(self):
         """Test that token format is validated."""
-        from agentready.services.github_scanner import GitHubAuthError, GitHubOrgScanner
 
-        import pytest
+        from agentready.services.github_scanner import GitHubAuthError, GitHubOrgScanner
 
         invalid_tokens = [
             "invalid",
@@ -381,14 +379,15 @@ def test_token_format_validation(self):
 
         for invalid_token in invalid_tokens:
             with patch.dict("os.environ", {"GITHUB_TOKEN": invalid_token}):
-                with pytest.raises(GitHubAuthError, match="Invalid GitHub token format"):
+                with pytest.raises(
+                    GitHubAuthError, match="Invalid GitHub token format"
+                ):
                     GitHubOrgScanner()
 
     def test_token_read_from_env_only(self):
         """Test that token is only read from environment variable."""
-        from agentready.services.github_scanner import GitHubAuthError, GitHubOrgScanner
 
-        import pytest
+        from agentready.services.github_scanner import GitHubAuthError, GitHubOrgScanner
 
         # Ensure environment is clean
         with patch.dict("os.environ", {}, clear=True):
@@ -404,9 +403,8 @@ def test_token_read_from_env_only(self):
 
     def test_org_name_validation_prevents_injection(self):
         """Test that org name validation prevents injection attacks."""
-        from agentready.services.github_scanner import GitHubOrgScanner
 
-        import pytest
+        from agentready.services.github_scanner import GitHubOrgScanner
 
         token = "ghp_" + "a" * 36
 
diff --git a/tests/unit/test_security_controls.py b/tests/unit/test_security_controls.py
@@ -1,11 +1,12 @@
 """Security control verification tests for batch assessment."""
 
-import pytest
 from pathlib import Path
 from tempfile import TemporaryDirectory
 
-from agentready.services.repository_manager import RepositoryManager
+import pytest
+
 from agentready.services.assessment_cache import AssessmentCache
+from agentready.services.repository_manager import RepositoryManager
 
 
 class TestSecurityControls:
diff --git a/tests/unit/utils/test_privacy.py b/tests/unit/utils/test_privacy.py
@@ -1,6 +1,5 @@
 """Unit tests for privacy utilities."""
 
-import getpass
 from pathlib import Path
 from unittest.mock import patch
 
@@ -398,7 +397,9 @@ def test_sanitize_empty_metadata(self):
 
     def test_sanitize_command_field(self):
         """Test command field sanitization."""
-        metadata = {"command": "agentready assess /home/user/project --config secret.yaml"}
+        metadata = {
+            "command": "agentready assess /home/user/project --config secret.yaml"
+        }
         result = sanitize_metadata(metadata)
 
         assert "command" in result
diff --git a/tests/unit/utils/test_subprocess_utils.py b/tests/unit/utils/test_subprocess_utils.py
@@ -51,31 +51,39 @@ def test_validate_forbidden_etc(self, tmp_path):
         with patch.object(Path, "resolve") as mock_resolve:
             mock_resolve.return_value = Path("/etc/project")
 
-            with pytest.raises(SubprocessSecurityError, match="Cannot access sensitive directory"):
+            with pytest.raises(
+                SubprocessSecurityError, match="Cannot access sensitive directory"
+            ):
                 validate_repository_path(Path("/etc/project"))
 
     def test_validate_forbidden_sys(self, tmp_path):
         """Test validation blocks /sys directory."""
         with patch.object(Path, "resolve") as mock_resolve:
             mock_resolve.return_value = Path("/sys/project")
 
-            with pytest.raises(SubprocessSecurityError, match="Cannot access sensitive directory"):
+            with pytest.raises(
+                SubprocessSecurityError, match="Cannot access sensitive directory"
+            ):
                 validate_repository_path(Path("/sys/project"))
 
     def test_validate_forbidden_proc(self, tmp_path):
         """Test validation blocks /proc directory."""
         with patch.object(Path, "resolve") as mock_resolve:
             mock_resolve.return_value = Path("/proc/project")
 
-            with pytest.raises(SubprocessSecurityError, match="Cannot access sensitive directory"):
+            with pytest.raises(
+                SubprocessSecurityError, match="Cannot access sensitive directory"
+            ):
                 validate_repository_path(Path("/proc/project"))
 
     def test_validate_forbidden_root_ssh(self, tmp_path):
         """Test validation blocks /.ssh directory."""
         with patch.object(Path, "resolve") as mock_resolve:
             mock_resolve.return_value = Path("/.ssh")
 
-            with pytest.raises(SubprocessSecurityError, match="Cannot access sensitive directory"):
+            with pytest.raises(
+                SubprocessSecurityError, match="Cannot access sensitive directory"
+            ):
                 validate_repository_path(Path("/.ssh"))
 
     def test_validate_symlink_resolution(self, tmp_path):

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+https://github.com/ambient-code/agentready`
	`2`	`+https://github.com/ambient-code/platform`
	`3`	`+https://github.com/ambient-code/spec-kit-rh`
Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,7 @@ def create_test_batch_with_payload(payload: str, inject_location: str):`
`57`	`57`	`)`
`58`	`58`
`59`	`59`	`repo_url = (`
`60`		`- "https://github.com/test/repo"`
`61`		`- if inject_location != "repo_url"`
`62`		`- else payload`
	`60`	`+ "https://github.com/test/repo" if inject_location != "repo_url" else payload`
`63`	`61`	`)`
`64`	`62`	`error = payload if inject_location == "error_message" else None`
`65`	`63`