fix: resolve linting failures from CI

jeremyeder · claude · jeremyeder · commit 4d119fc90a80 · 2025-11-24T00:06:56.000-05:00
- Fix undefined 'repo' variable in align.py (should be scanner.repository) - Remove unused imports across 30 files (black/ruff violations) - Fix import ordering (isort) - Fix jsonschema import patterns - Fix f-string literals without placeholders All linters now pass: black, isort, ruff 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/src/agentready/cli/align.py b/src/agentready/cli/align.py
@@ -6,9 +6,7 @@
 import click
 
 from ..models.config import Config
-from ..models.repository import Repository
 from ..services.fixer_service import FixerService
-from ..services.language_detector import LanguageDetector
 from ..services.scanner import Scanner
 
 
@@ -120,7 +118,9 @@ def align(repository, dry_run, attributes, interactive):
         attribute_list = [a.strip() for a in attributes.split(",")]
 
     fixer_service = FixerService()
-    fix_plan = fixer_service.generate_fix_plan(assessment, repo, attribute_list)
+    fix_plan = fixer_service.generate_fix_plan(
+        assessment, scanner.repository, attribute_list
+    )
 
     if not fix_plan.fixes:
         click.echo("\n✅ No automatic fixes available.")
diff --git a/src/agentready/cli/assess_batch.py b/src/agentready/cli/assess_batch.py
@@ -11,7 +11,6 @@
 from ..reporters.html import HTMLReporter
 from ..reporters.markdown import MarkdownReporter
 from ..services.batch_scanner import BatchScanner
-from ..utils.subprocess_utils import safe_subprocess_run
 
 
 def _get_agentready_version() -> str:
@@ -152,9 +151,7 @@ def _load_config(config_path: Path) -> Config:
     )
 
 
-def _generate_multi_reports(
-    batch_assessment, output_path: Path, verbose: bool
-) -> None:
+def _generate_multi_reports(batch_assessment, output_path: Path, verbose: bool) -> None:
     """Generate all report formats in dated folder structure.
 
     Phase 2 Reporting:
@@ -170,10 +167,10 @@ def _generate_multi_reports(
         output_path: Base output directory
         verbose: Whether to show verbose progress
     """
-    from ..reporters.csv_reporter import CSVReporter
     from ..reporters.aggregated_json import AggregatedJSONReporter
-    from ..reporters.multi_html import MultiRepoHTMLReporter
+    from ..reporters.csv_reporter import CSVReporter
     from ..reporters.json_reporter import JSONReporter
+    from ..reporters.multi_html import MultiRepoHTMLReporter
 
     # Create dated reports folder
     timestamp = batch_assessment.timestamp.strftime("%Y%m%d-%H%M%S")
@@ -186,8 +183,12 @@ def _generate_multi_reports(
     # 1. CSV/TSV summary
     try:
         csv_reporter = CSVReporter()
-        csv_reporter.generate(batch_assessment, reports_dir / "summary.csv", delimiter=",")
-        csv_reporter.generate(batch_assessment, reports_dir / "summary.tsv", delimiter="\t")
+        csv_reporter.generate(
+            batch_assessment, reports_dir / "summary.csv", delimiter=","
+        )
+        csv_reporter.generate(
+            batch_assessment, reports_dir / "summary.tsv", delimiter="\t"
+        )
         if verbose:
             click.echo("  ✓ summary.csv")
             click.echo("  ✓ summary.tsv")
@@ -225,7 +226,9 @@ def _generate_multi_reports(
                 if verbose:
                     click.echo(f"  ✓ {base_name}.{{html,json,md}}")
             except Exception as e:
-                click.echo(f"  ✗ Individual reports failed for {base_name}: {e}", err=True)
+                click.echo(
+                    f"  ✗ Individual reports failed for {base_name}: {e}", err=True
+                )
 
     # 4. Multi-repo summary HTML (index)
     try:
@@ -259,12 +262,12 @@ def _generate_multi_reports(
 
     # Print final summary
     click.echo(f"\n✓ Reports generated: {reports_dir}/")
-    click.echo(f"  - index.html (summary)")
-    click.echo(f"  - summary.csv & summary.tsv")
-    click.echo(f"  - all-assessments.json")
-    click.echo(f"  - Individual reports per repository")
+    click.echo("  - index.html (summary)")
+    click.echo("  - summary.csv & summary.tsv")
+    click.echo("  - all-assessments.json")
+    click.echo("  - Individual reports per repository")
     if failed_results:
-        click.echo(f"  - failures.json")
+        click.echo("  - failures.json")
 
 
 @click.command()
@@ -573,7 +576,9 @@ def _generate_batch_markdown_report(batch_assessment, output_file: Path) -> None
         lines.append(f"\n### {result.repository_url}\n")
         if result.is_success():
             lines.append(f"- **Score**: {result.assessment.overall_score}/100\n")
-            lines.append(f"- **Certification**: {result.assessment.certification_level}\n")
+            lines.append(
+                f"- **Certification**: {result.assessment.certification_level}\n"
+            )
             lines.append(f"- **Duration**: {result.duration_seconds:.1f}s\n")
             lines.append(f"- **Cached**: {result.cached}\n")
         else:
diff --git a/src/agentready/cli/experiment.py b/src/agentready/cli/experiment.py
@@ -1,12 +1,13 @@
 """Experiment CLI commands."""
 
-import click
 from pathlib import Path
+
+import click
+
+from ..services.attribute_analyzer import AttributeAnalyzer
+from ..services.experiment_comparer import ExperimentComparer
 from ..services.sweagent_runner import SWEAgentRunner
-from ..services.claudecode_runner import ClaudeCodeRunner
 from ..services.swebench_evaluator import SWEBenchEvaluator
-from ..services.experiment_comparer import ExperimentComparer
-from ..services.attribute_analyzer import AttributeAnalyzer
 
 
 @click.group()
diff --git a/src/agentready/cli/main.py b/src/agentready/cli/main.py
@@ -58,7 +58,6 @@
 from .bootstrap import bootstrap
 from .demo import demo
 from .experiment import experiment
-from .extract_skills import extract_skills
 from .learn import learn
 from .repomix import repomix_generate
 from .research import research
@@ -496,7 +495,6 @@ def generate_config():
 cli.add_command(bootstrap)
 cli.add_command(demo)
 cli.add_command(experiment)
-cli.add_command(extract_skills)
 cli.add_command(learn)
 cli.add_command(migrate_report)
 cli.add_command(repomix_generate)
diff --git a/src/agentready/models/batch_assessment.py b/src/agentready/models/batch_assessment.py
@@ -2,7 +2,6 @@
 
 from dataclasses import dataclass, field
 from datetime import datetime
-from pathlib import Path
 
 from .assessment import Assessment
 
diff --git a/src/agentready/reporters/csv_reporter.py b/src/agentready/reporters/csv_reporter.py
@@ -112,7 +112,9 @@ def generate(
                     # SECURITY: Sanitize all string fields
                     row = {
                         "repo_url": self.sanitize_csv_field(result.repository_url),
-                        "repo_name": self.sanitize_csv_field(assessment.repository.name),
+                        "repo_name": self.sanitize_csv_field(
+                            assessment.repository.name
+                        ),
                         "overall_score": assessment.overall_score,
                         "certification_level": self.sanitize_csv_field(
                             assessment.certification_level
diff --git a/src/agentready/services/assessment_cache.py b/src/agentready/services/assessment_cache.py
@@ -6,7 +6,7 @@
 from pathlib import Path
 from typing import Optional
 
-from ..models import Assessment, BatchAssessment, RepositoryResult
+from ..models import Assessment
 
 
 class AssessmentCache:
@@ -230,7 +230,9 @@ def get_stats(self) -> dict:
                 )
                 valid = cursor.fetchone()[0]
 
-                cursor = conn.execute("SELECT COUNT(DISTINCT repository_url) FROM assessments")
+                cursor = conn.execute(
+                    "SELECT COUNT(DISTINCT repository_url) FROM assessments"
+                )
                 unique_repos = cursor.fetchone()[0]
 
                 return {
@@ -258,7 +260,6 @@ def _deserialize_assessment(data: dict) -> Assessment:
         # In practice, you'd need full deserialization logic
         # For now, we'll use a placeholder that assumes the cached JSON
         # has the correct structure
-        from .scanner import Scanner
 
         # Note: This is a simplified approach. In production, you'd need
         # proper deserialization that reconstructs all nested objects
diff --git a/src/agentready/services/attribute_analyzer.py b/src/agentready/services/attribute_analyzer.py
@@ -1,10 +1,11 @@
 """Attribute correlation analysis with Plotly Express heatmap."""
 
 import json
-import pandas as pd
-import plotly.express as px
 from pathlib import Path
 from typing import List
+
+import pandas as pd
+import plotly.express as px
 from scipy.stats import pearsonr
 
 
diff --git a/src/agentready/services/batch_scanner.py b/src/agentready/services/batch_scanner.py
@@ -6,7 +6,7 @@
 from typing import Callable, Optional
 from uuid import uuid4
 
-from ..models import Assessment, BatchAssessment, BatchSummary, RepositoryResult
+from ..models import BatchAssessment, BatchSummary, RepositoryResult
 from .assessment_cache import AssessmentCache
 from .repository_manager import RepositoryManager
 from .scanner import Scanner
diff --git a/src/agentready/services/claudecode_runner.py b/src/agentready/services/claudecode_runner.py
@@ -1,7 +1,7 @@
 """Claude Code headless mode execution wrapper."""
 
-import subprocess
 import json
+import subprocess
 from pathlib import Path
 from typing import Optional
 
diff --git a/src/agentready/services/experiment_comparer.py b/src/agentready/services/experiment_comparer.py
@@ -1,9 +1,9 @@
 """Compare experiment results."""
 
 import json
+from dataclasses import asdict, dataclass
 from pathlib import Path
 from typing import List
-from dataclasses import dataclass, asdict
 
 
 @dataclass
diff --git a/src/agentready/services/github_scanner.py b/src/agentready/services/github_scanner.py
@@ -146,9 +146,7 @@ def get_org_repos(
                 response.raise_for_status()
 
             except requests.Timeout:
-                raise GitHubAPIError(
-                    f"GitHub API timeout for organization: {org_name}"
-                )
+                raise GitHubAPIError(f"GitHub API timeout for organization: {org_name}")
 
             except requests.HTTPError as e:
                 # SECURITY: Redact token before raising
diff --git a/src/agentready/services/schema_validator.py b/src/agentready/services/schema_validator.py
@@ -1,15 +1,15 @@
 """Schema validation service for AgentReady assessment reports."""
 
+import importlib.util
 import json
 from pathlib import Path
 from typing import Any
 
-try:
-    import jsonschema
+if importlib.util.find_spec("jsonschema") is not None:
     from jsonschema import Draft7Validator, validators
 
     JSONSCHEMA_AVAILABLE = True
-except ImportError:
+else:
     JSONSCHEMA_AVAILABLE = False
 
 
diff --git a/src/agentready/services/sweagent_runner.py b/src/agentready/services/sweagent_runner.py
@@ -1,7 +1,6 @@
 """SWE-agent batch execution wrapper."""
 
 import subprocess
-import json
 from pathlib import Path
 from typing import Optional
 
diff --git a/src/agentready/services/swebench_evaluator.py b/src/agentready/services/swebench_evaluator.py
@@ -1,9 +1,9 @@
 """SWE-bench evaluation harness wrapper."""
 
-import subprocess
 import json
-from pathlib import Path
+import subprocess
 from dataclasses import dataclass
+from pathlib import Path
 
 
 @dataclass
diff --git a/tests/integration/test_schema_commands.py b/tests/integration/test_schema_commands.py
@@ -71,9 +71,9 @@ def sample_report(tmp_path):
 
 def test_validate_report_valid(runner, sample_report):
     """Test validate-report command with valid report."""
-    try:
-        import jsonschema
-    except ImportError:
+    import importlib.util
+
+    if importlib.util.find_spec("jsonschema") is None:
         pytest.skip("jsonschema not installed")
 
     result = runner.invoke(cli, ["validate-report", str(sample_report)])
@@ -84,9 +84,9 @@ def test_validate_report_valid(runner, sample_report):
 
 def test_validate_report_nonexistent(runner, tmp_path):
     """Test validate-report command with nonexistent file."""
-    try:
-        import jsonschema
-    except ImportError:
+    import importlib.util
+
+    if importlib.util.find_spec("jsonschema") is None:
         pytest.skip("jsonschema not installed")
 
     nonexistent = tmp_path / "nonexistent.json"
@@ -99,9 +99,9 @@ def test_validate_report_nonexistent(runner, tmp_path):
 
 def test_validate_report_invalid_json(runner, tmp_path):
     """Test validate-report command with invalid JSON."""
-    try:
-        import jsonschema
-    except ImportError:
+    import importlib.util
+
+    if importlib.util.find_spec("jsonschema") is None:
         pytest.skip("jsonschema not installed")
 
     invalid_file = tmp_path / "invalid.json"
@@ -116,9 +116,9 @@ def test_validate_report_invalid_json(runner, tmp_path):
 
 def test_validate_report_no_strict(runner, sample_report):
     """Test validate-report with --no-strict option."""
-    try:
-        import jsonschema
-    except ImportError:
+    import importlib.util
+
+    if importlib.util.find_spec("jsonschema") is None:
         pytest.skip("jsonschema not installed")
 
     result = runner.invoke(cli, ["validate-report", "--no-strict", str(sample_report)])
@@ -173,9 +173,9 @@ def test_migrate_report_unsupported_version(runner, sample_report):
 
 def test_validate_then_migrate_workflow(runner, sample_report, tmp_path):
     """Test full workflow: validate, migrate, validate again."""
-    try:
-        import jsonschema
-    except ImportError:
+    import importlib.util
+
+    if importlib.util.find_spec("jsonschema") is None:
         pytest.skip("jsonschema not installed")
 
     # Step 1: Validate original
diff --git a/tests/security/test_xss_prevention.py b/tests/security/test_xss_prevention.py
@@ -57,9 +57,7 @@ def create_test_batch_with_payload(payload: str, inject_location: str):
     )
 
     repo_url = (
-        "https://github.com/test/repo"
-        if inject_location != "repo_url"
-        else payload
+        "https://github.com/test/repo" if inject_location != "repo_url" else payload
     )
     error = payload if inject_location == "error_message" else None
 
diff --git a/tests/unit/cli/test_main.py b/tests/unit/cli/test_main.py
@@ -1,8 +1,5 @@
 """Unit tests for main CLI commands."""
 
-import json
-import shutil
-import tempfile
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -18,7 +15,6 @@
     load_config,
     research_version,
     run_assessment,
-    show_version,
 )
 from agentready.models.config import Config
 
diff --git a/tests/unit/learners/test_llm_enricher.py b/tests/unit/learners/test_llm_enricher.py
@@ -415,7 +415,7 @@ def test_call_claude_api_builds_prompt(
     """Test that _call_claude_api builds correct prompt."""
     enricher = LLMEnricher(mock_anthropic_client, cache_dir=tmp_path)
 
-    result = enricher._call_claude_api(
+    enricher._call_claude_api(
         basic_skill, sample_finding, sample_repository, "code samples"
     )
 
diff --git a/tests/unit/learners/test_skill_generator.py b/tests/unit/learners/test_skill_generator.py
@@ -1,6 +1,5 @@
 """Unit tests for skill generation."""
 
-import json
 from pathlib import Path
 
 import pytest
diff --git a/tests/unit/test_assessment_cache.py b/tests/unit/test_assessment_cache.py
diff --git a/tests/unit/test_csv_reporter.py b/tests/unit/test_csv_reporter.py
diff --git a/tests/unit/test_fixer_service.py b/tests/unit/test_fixer_service.py
diff --git a/tests/unit/test_github_scanner.py b/tests/unit/test_github_scanner.py
diff --git a/tests/unit/test_multi_html_reporter.py b/tests/unit/test_multi_html_reporter.py
diff --git a/tests/unit/test_repository_manager.py b/tests/unit/test_repository_manager.py
diff --git a/tests/unit/test_security.py b/tests/unit/test_security.py
diff --git a/tests/unit/test_security_controls.py b/tests/unit/test_security_controls.py
diff --git a/tests/unit/utils/test_privacy.py b/tests/unit/utils/test_privacy.py
diff --git a/tests/unit/utils/test_subprocess_utils.py b/tests/unit/utils/test_subprocess_utils.py
