Skip to content

Commit b04c508

Browse files
sallyomclaude
andauthored
remove stale code (#332)
Remove stale RFE workflow code from frontend following the UI refactor in commit 1540e30. This cleanup eliminates unused API services, type definitions, and workflow phase constants. Files removed: - components/frontend/src/services/api/rfe.ts (270 lines) - components/frontend/src/types/api/rfe.ts (154 lines) Files modified: - Remove RFE exports from API and type index files - Remove stale RFE types from agentic-session.ts (83 lines) - Remove workflow phase constants from lib/agents.ts (20 lines) Build verified: 0 errors, 0 warnings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent 8a4d5cd commit b04c508

File tree

6 files changed

+1
-523
lines changed

6 files changed

+1
-523
lines changed

components/frontend/src/lib/agents.ts

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -139,25 +139,4 @@ function getCategoryForRole(role: string): string {
139139
if (role.includes("Product") || role.includes("Strategy")) return "Product";
140140
if (role.includes("Content") || role.includes("Documentation")) return "Content";
141141
return "Process & Leadership";
142-
}
143-
144-
export const WORKFLOW_PHASE_LABELS = {
145-
pre: "⏳ Pre",
146-
ideate: "💡 Ideate",
147-
specify: "📝 Specify",
148-
plan: "🗂️ Plan",
149-
tasks: "✅ Tasks",
150-
implement: "🚧 Implement",
151-
review: "👁️ Review",
152-
completed: "🎉 Completed"
153-
};
154-
155-
export const WORKFLOW_PHASE_DESCRIPTIONS = {
156-
ideate: "Collaboratively ideate and define the high-level RFE in rfe.md",
157-
specify: "Create comprehensive specifications from different perspectives",
158-
plan: "Generate detailed implementation plans with technical approach",
159-
tasks: "Break down features into actionable development tasks",
160-
implement: "Start implementation session to begin coding based on tasks",
161-
review: "Review and finalize all artifacts before implementation",
162-
completed: "All phases complete, artifacts pushed to repository"
163-
};
142+
}

components/frontend/src/services/api/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export * from './client';
77
export * as clusterApi from './cluster';
88
export * as projectsApi from './projects';
99
export * as sessionsApi from './sessions';
10-
export * as rfeApi from './rfe';
1110
export * as githubApi from './github';
1211
export * as keysApi from './keys';
1312
export * as repoApi from './repo';

components/frontend/src/services/api/rfe.ts

Lines changed: 0 additions & 269 deletions
This file was deleted.

components/frontend/src/types/agentic-session.ts

Lines changed: 0 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -177,88 +177,11 @@ export type CreateAgenticSessionRequest = {
177177
annotations?: Record<string, string>;
178178
};
179179

180-
// New types for RFE workflows
181-
export type WorkflowPhase = "pre" | "ideate" | "specify" | "plan" | "tasks" | "implement" | "review" | "completed";
182-
183180
export type AgentPersona = {
184181
persona: string;
185182
name: string;
186183
role: string;
187184
description: string;
188185
};
189186

190-
export type ArtifactFile = {
191-
path: string;
192-
name: string;
193-
content: string;
194-
lastModified: string;
195-
size: number;
196-
agent?: string;
197-
phase?: string;
198-
};
199-
200-
export type RFESession = {
201-
id: string;
202-
agentPersona: string; // Agent persona key (e.g., "ENGINEERING_MANAGER")
203-
phase: WorkflowPhase;
204-
status: string; // "pending", "running", "completed", "failed"
205-
startedAt?: string;
206-
completedAt?: string;
207-
result?: string;
208-
cost?: number;
209-
};
210-
211-
export type RFEWorkflow = {
212-
id: string;
213-
title: string;
214-
description: string;
215-
branchName?: string; // Platform-generated feature branch name
216-
currentPhase?: WorkflowPhase; // derived in UI
217-
status?: "active" | "completed" | "failed" | "paused"; // derived in UI
218-
// New CRD-aligned repo fields
219-
umbrellaRepo?: GitRepository; // required in CRD, but optional in API reads
220-
supportingRepos?: GitRepository[];
221-
workspacePath?: string; // CRD-aligned optional path
222-
parentOutcome?: string; // Optional parent Jira Outcome key (e.g., RHASTRAT-456)
223-
agentSessions?: RFESession[];
224-
artifacts?: ArtifactFile[];
225-
createdAt: string;
226-
updatedAt: string;
227-
phaseResults?: { [phase: string]: PhaseResult };
228-
jiraLinks?: Array<{ path: string; jiraKey: string }>;
229-
};
230-
231-
export type CreateRFEWorkflowRequest = {
232-
title: string;
233-
description: string;
234-
umbrellaRepo: GitRepository;
235-
supportingRepos?: GitRepository[];
236-
workspacePath?: string;
237-
parentOutcome?: string; // Optional parent Jira Outcome key (e.g., RHASTRAT-456)
238-
};
239-
240-
export type PhaseResult = {
241-
phase: string;
242-
status: string; // "completed", "in_progress", "failed"
243-
agents: string[]; // agents that worked on this phase
244-
artifacts: string[]; // artifact paths created in this phase
245-
summary: string;
246-
startedAt: string;
247-
completedAt?: string;
248-
metadata?: { [key: string]: unknown };
249-
};
250-
251-
export type RFEWorkflowStatus = {
252-
phase: WorkflowPhase;
253-
agentProgress: {
254-
[agentPersona: string]: {
255-
status: AgenticSessionPhase;
256-
sessionName?: string;
257-
completedAt?: string;
258-
};
259-
};
260-
artifactCount: number;
261-
lastActivity: string;
262-
};
263-
264187
export type { Project } from "@/types/project";

0 commit comments

Comments
 (0)