Commit b27d17b
committed
chore: Address code review feedback
Addresses Claude Code Review feedback items:
1. Delete deprecated setup-vertex-ai.sh script
- Script was replaced by Makefile automation
- Prevents confusion and risk of modifying tracked files
2. Replace hardcoded sleeps with kubectl wait
- Use 'kubectl wait --for=condition=ready' for pods
- More reliable than fixed timeouts
- Reduced final sleep from 2s to 1s
3. Update SECURITY_DEV_MODE.md to reflect allow-list implementation
- Code uses allow-list (ambient-code, default, vteam-dev)
- Documentation was describing old deny-list approach
- Now accurately documents current security posture
4. Add ShellCheck directive for intentional set +e
- Documents why we continue on errors (collect all test results)
5. Document sys.path.insert in wrapper.py
- Explains why runner-shell path manipulation is necessary
- Clarifies dependency on RunnerShell framework
All changes improve code quality, documentation accuracy, and reliability.1 parent b2269aa commit b27d17b
File tree
5 files changed
+20
-88
lines changed- components/runners/claude-code-runner
- docs
- scripts
- tests
5 files changed
+20
-88
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
521 | 521 | | |
522 | 522 | | |
523 | 523 | | |
524 | | - | |
| 524 | + | |
| 525 | + | |
525 | 526 | | |
526 | 527 | | |
527 | 528 | | |
528 | 529 | | |
529 | 530 | | |
530 | | - | |
| 531 | + | |
531 | 532 | | |
532 | 533 | | |
533 | 534 | | |
534 | | - | |
| 535 | + | |
535 | 536 | | |
536 | 537 | | |
537 | 538 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
76 | 75 | | |
77 | 76 | | |
78 | | - | |
79 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
80 | 81 | | |
81 | 82 | | |
| 83 | + | |
| 84 | + | |
82 | 85 | | |
83 | 86 | | |
84 | 87 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
0 commit comments