-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
improvementCode review, improvements, good practicesCode review, improvements, good practices
Milestone
Description
Estimated time: 1 hour
- Starting from the
masterbranch, create a new branchchore/code-review. - Create a file named
CODE_REVIEW.mdat the workspace root write a short code review based on the existing code. - Are there any problems or code smells in the app? (Focus on code in the
libs/booksfolder) - Are there other improvements you would make to the app? What are they and why?
- Good practices
- Write your review in bullet points. You should list at least three items.
- Google Chrome, run an automated scan with the Lighthouse extension. Lighthouse, note these issues.
- Chrome again, manually check for accessibility issues.
- Identify at least 3 issue, not found in the automated scan.
- Fix at least one of the issues noted in step 2 and all the issues from step 3.
- Run lint
- Run unit tests
- Run e2e tests.
- Fix anything that fails.
- Commit your changes to the feature branch.
- Open a pull-request with
masteras the target. - You should now have two commits on
master.
Metadata
Metadata
Assignees
Labels
improvementCode review, improvements, good practicesCode review, improvements, good practices