addressed reviews

alexandraBara · alexandraBara · commit 0a912a64abc2 · 2025-08-18T09:33:33.000-05:00
diff --git a/nodescraper/plugins/inband/rocm/rocm_collector.py b/nodescraper/plugins/inband/rocm/rocm_collector.py
@@ -65,7 +65,7 @@ def collect_data(self, args=None) -> tuple[TaskResult, RocmDataModel | None]:
         else:
             self._log_event(
                 category=EventCategory.OS,
-                description=f"Could not get ROCm version format from {path}",
+                description=f"Unable to read ROCm version from {version_paths}",
                 data={"raw_output": res.stdout},
                 priority=EventPriority.ERROR,
             )

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ def collect_data(self, args=None) -> tuple[TaskResult, RocmDataModel \| None]:`
`65`	`65`	`else:`
`66`	`66`	`self._log_event(`
`67`	`67`	`category=EventCategory.OS,`
`68`		`- description=f"Could not get ROCm version format from {path}",`
	`68`	`+ description=f"Unable to read ROCm version from {version_paths}",`
`69`	`69`	`data={"raw_output": res.stdout},`
`70`	`70`	`priority=EventPriority.ERROR,`
`71`	`71`	`)`