Merge branch 'development' into alex_devenum

Author: alexandraBara

.github/workflows/code_quality_checks.yml

@@ -4,7 +4,9 @@ name: Code Quality Check
 permissions:
   contents: read
 
-on: [pull_request]
+on:
+  - pull_request
+  - workflow_dispatch
 
 jobs:
   pre-commit:
@@ -13,11 +15,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-      - name: setup environment
-        run: |
-          ./dev-setup.sh
-      - name: run pre-commit hooks
+      - name: setup environment and run pre-commit hooks
+        shell: bash
         run: |
+          source ./dev-setup.sh
           pre-commit run --all-files --show-diff-on-failure --color=always
       - name: Print message on failure
         if: failure()

.github/workflows/unit-test.yml

@@ -17,19 +17,16 @@ jobs:
     steps:
     - uses: actions/checkout@v3
 
-    - name: Install package
-      run: |
-        ./dev-setup.sh
-
     - name: Install xmllint
       run: |
         apt-get update
         apt-get install -y libxml2-utils bc
 
-
-    - name: Run unit tests with coverage
+    - name: Install package and run unit tests with coverage
       id: extract_coverage
+      shell: bash
       run: |
+        source ./dev-setup.sh
         pytest test/unit -s --cov=nodescraper --cov-report=xml --cov-report=term --cov-fail-under=70 --maxfail=1 --disable-warnings -v
 
     - name: Print coverage

README.md

@@ -32,6 +32,27 @@ a python virtual environment and also configures the pre-commit hooks for the pr
 source dev-setup.sh
 ```
 
+Alternatively, follow these manual steps:
+
+### 1. Virtual Environment (Optional)
+```sh
+python3 -m venv venv
+source venv/bin/activate
+```
+On Debian/Ubuntu, you may need: `sudo apt install python3-venv`
+
+### 2. Install from Source (Required)
+```sh
+python3 -m pip install --editable .[dev] --upgrade
+```
+This installs Node Scraper in editable mode with development dependencies. To verify: `node-scraper --help`
+
+### 3. Git Hooks (Optional)
+```sh
+pre-commit install
+```
+Sets up pre-commit hooks for code quality checks. On Debian/Ubuntu, you may need: `sudo apt install pre-commit`
+
 ## CLI Usage
 The Node Scraper CLI can be used to run Node Scraper plugins on a target system. The following CLI
 options are available:

dev-setup.sh

@@ -1,6 +1,7 @@
+#!/usr/bin/env bash
+
 # Create venv if not already present
 if [ ! -d "venv" ]; then
-    python3 -m pip install venv
     python3 -m venv venv
 fi
 

nodescraper/models/analyzerargs.py

@@ -23,12 +23,61 @@
 # SOFTWARE.
 #
 ###############################################################################
-from pydantic import BaseModel
+from typing import Any
+
+from pydantic import BaseModel, model_validator
 
 
 class AnalyzerArgs(BaseModel):
+    """Base class for all analyzer arguments.
+
+    This class provides automatic string stripping for all string values
+    in analyzer args. All analyzer args classes should inherit from this
+    directly.
+
+    """
+
     model_config = {"extra": "forbid", "exclude_none": True}
 
+    @model_validator(mode="before")
+    @classmethod
+    def strip_string_values(cls, data: Any) -> Any:
+        """Strip whitespace from all string values in analyzer args.
+
+        This validator recursively processes:
+        - String values: strips whitespace
+        - Lists: strips strings in lists
+        - Dicts: strips string values in dicts
+        - Other types: left unchanged
+
+        Args:
+            data: The input data to validate
+
+        Returns:
+            The data with all string values stripped
+        """
+        if isinstance(data, dict):
+            return {k: cls._strip_value(v) for k, v in data.items()}
+        return data
+
+    @classmethod
+    def _strip_value(cls, value: Any) -> Any:
+        """Recursively strip string values.
+
+        Args:
+            value: The value to process
+
+        Returns:
+            The processed value
+        """
+        if isinstance(value, str):
+            return value.strip()
+        elif isinstance(value, list):
+            return [cls._strip_value(item) for item in value]
+        elif isinstance(value, dict):
+            return {k: cls._strip_value(v) for k, v in value.items()}
+        return value
+
     @classmethod
     def build_from_model(cls, datamodel):
         """Build analyzer args instance from data model object

nodescraper/plugins/inband/amdsmi/__init__.py

@@ -0,0 +1,28 @@
+###############################################################################
+#
+# MIT License
+#
+# Copyright (c) 2025 Advanced Micro Devices, Inc.
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+#
+###############################################################################
+from .amdsmi_plugin import AmdSmiPlugin
+
+__all__ = ["AmdSmiPlugin"]