Merge pull request #22 from amd/alex_sudo

alexandraBara · web-flow · commit 3963c6f3893a · 2025-07-18T09:53:34.000-05:00
removed sudo req from bios &amp; os plugin
diff --git a/nodescraper/plugins/inband/bios/bios_collector.py b/nodescraper/plugins/inband/bios/bios_collector.py
@@ -55,7 +55,7 @@ def collect_data(
                     0
                 ].split("=")[1]
         else:
-            res = self._run_sut_cmd("sh -c 'dmidecode -s bios-version'", sudo=True)
+            res = self._run_sut_cmd("sh -c 'cat /sys/devices/virtual/dmi/id/bios_version'")
             if res.exit_code == 0:
                 bios = res.stdout
 
diff --git a/nodescraper/plugins/inband/os/os_collector.py b/nodescraper/plugins/inband/os/os_collector.py
@@ -85,7 +85,7 @@ def collect_data(self, args=None) -> tuple[TaskResult, OsDataModel | None]:
             PRETTY_STR = "PRETTY_NAME"  # noqa: N806
             res = self._run_sut_cmd(
                 f"sh -c '( lsb_release -ds || (cat /etc/*release | grep {PRETTY_STR}) || uname -om ) 2>/dev/null | head -n1'",
-                sudo=True,
+                sudo=False,
             )
             # search for PRETTY_NAME in res
             if res.exit_code == 0:

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ def collect_data(`
`55`	`55`	`0`
`56`	`56`	`].split("=")[1]`
`57`	`57`	`else:`
`58`		`- res = self._run_sut_cmd("sh -c 'dmidecode -s bios-version'", sudo=True)`
	`58`	`+ res = self._run_sut_cmd("sh -c 'cat /sys/devices/virtual/dmi/id/bios_version'")`
`59`	`59`	`if res.exit_code == 0:`
`60`	`60`	`bios = res.stdout`
`61`	`61`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ def collect_data(self, args=None) -> tuple[TaskResult, OsDataModel \| None]:`
`85`	`85`	`PRETTY_STR = "PRETTY_NAME" # noqa: N806`
`86`	`86`	`res = self._run_sut_cmd(`
`87`	`87`	`f"sh -c '( lsb_release -ds \|\| (cat /etc/*release \| grep {PRETTY_STR}) \|\| uname -om ) 2>/dev/null \| head -n1'",`
`88`		`- sudo=True,`
	`88`	`+ sudo=False,`
`89`	`89`	`)`
`90`	`90`	`# search for PRETTY_NAME in res`
`91`	`91`	`if res.exit_code == 0:`