Skip to content

Commit 397ec53

Browse files
committed
addressed reviews
1 parent 8be4d84 commit 397ec53

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

nodescraper/cli/helper.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
from nodescraper.cli.inputargtypes import ModelArgHandler
3434
from nodescraper.configbuilder import ConfigBuilder
3535
from nodescraper.configregistry import ConfigRegistry
36-
from nodescraper.enums import SystemInteractionLevel, SystemLocation
36+
from nodescraper.enums import ExecutionStatus, SystemInteractionLevel, SystemLocation
3737
from nodescraper.models import PluginConfig, PluginResult, SystemInfo
3838
from nodescraper.pluginexecutor import PluginExecutor
3939
from nodescraper.pluginregistry import PluginRegistry
@@ -299,12 +299,23 @@ def generate_reference_config(
299299
plugin_config = PluginConfig()
300300
plugins = {}
301301
for obj in results:
302+
if obj.result_data.collection_result.status != ExecutionStatus.OK:
303+
logger.warning(
304+
"Plugin: %s result status is %, skipping",
305+
obj.source,
306+
obj.result_data.collection_result.status,
307+
)
308+
continue
309+
302310
data_model = obj.result_data.system_data
311+
if data_model is None:
312+
logger.warning("Plugin: %s data model not found: %s, skipping", obj.source)
313+
continue
303314

304315
plugin = plugin_reg.plugins.get(obj.source)
305316
if not plugin.ANALYZER_ARGS:
306317
logger.warning(
307-
"Plugin: %s does not support reference config creation. No analyzer args defined.",
318+
"Plugin: %s does not support reference config creation. No analyzer args defined, skipping.",
308319
obj.source,
309320
)
310321
continue

0 commit comments

Comments
 (0)