Skip to content

Commit 5c7cf60

Browse files
committed
fix for default args
1 parent c06d019 commit 5c7cf60

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

nodescraper/plugins/inband/device_enumeration/device_enumeration_analyzer.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,11 @@ def analyze_data(
4646
) -> TaskResult:
4747

4848
if args is None:
49-
args = DeviceEnumerationAnalyzerArgs()
49+
self.result.status = ExecutionStatus.NOT_RAN
50+
self.result.message = (
51+
"Expected Device Enumeration data not provided, skipping analysis."
52+
)
53+
return self.result
5054

5155
# Convert to lists if integers, otherwise use as-is
5256
cpu_count = [args.cpu_count] if isinstance(args.cpu_count, int) else args.cpu_count

test/unit/plugin/test_device_enumeration_analyzer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ def test_analyze_passing_windows(system_info, device_enumeration_analyzer, devic
7575

7676

7777
def test_analyze_no_args(device_enumeration_analyzer, device_enumeration_data):
78-
"""Test with no analyzer args provided - should skip all checks"""
78+
"""Test with no analyzer args provided - should skip analysis"""
7979

8080
result = device_enumeration_analyzer.analyze_data(data=device_enumeration_data, args=None)
8181

82-
assert result.status == ExecutionStatus.OK
83-
assert "Device Enumeration validated" in result.message
82+
assert result.status == ExecutionStatus.NOT_RAN
83+
assert "Expected Device Enumeration data not provided, skipping analysis." in result.message
8484
assert len(result.events) == 0
8585

8686

0 commit comments

Comments
 (0)