Skip to content

Commit 759f425

Browse files
Jaspal SinghJaspal Singh
authored andcommitted
pre commit error fixes
1 parent 1a76e3e commit 759f425

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

nodescraper/plugins/inband/kernel/analyzer_args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,4 @@ def build_from_model(cls, datamodel: KernelDataModel) -> "KernelAnalyzerArgs":
6161
Returns:
6262
KernelAnalyzerArgs: instance of analyzer args class
6363
"""
64-
return cls(exp_kernel=datamodel.kernel_version)
64+
return cls(exp_kernel=datamodel.kernel_info)

nodescraper/plugins/inband/kernel/kernel_analyzer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,23 +68,23 @@ def analyze_data(
6868
priority=EventPriority.ERROR,
6969
)
7070
continue
71-
if regex_data.match(data.kernel_version):
71+
if regex_data.match(data.kernel_info):
7272
self.result.message = "Kernel matches expected"
7373
self.result.status = ExecutionStatus.OK
7474
return self.result
75-
elif data.kernel_version == kernel:
75+
elif data.kernel_info == kernel:
7676
self.result.message = "Kernel matches expected"
7777
self.result.status = ExecutionStatus.OK
7878
return self.result
7979

8080
self.result.message = (
81-
f"Kernel mismatch! Expected: {args.exp_kernel}, actual: {data.kernel_version}"
81+
f"Kernel mismatch! Expected: {args.exp_kernel}, actual: {data.kernel_info}"
8282
)
8383
self.result.status = ExecutionStatus.ERROR
8484
self._log_event(
8585
category=EventCategory.OS,
8686
description=f"{self.result.message}",
87-
data={"expected": args.exp_kernel, "actual": data.kernel_version},
87+
data={"expected": args.exp_kernel, "actual": data.kernel_info},
8888
priority=EventPriority.CRITICAL,
8989
console_log=True,
9090
)

test/unit/plugin/test_kernel_analyzer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
@pytest.fixture
3737
def model_obj():
3838
return KernelDataModel(
39-
kernel_version="Linux MockSystem 5.13.0-30-generic #1 XYZ Day Month 10 15:19:13 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux",
40-
kernel_info="5.13.0-30-generic",
39+
kernel_info="Linux MockSystem 5.13.0-30-generic #1 XYZ Day Month 10 15:19:13 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux",
40+
kernel_version="5.13.0-30-generic",
4141
)
4242

4343

@@ -86,7 +86,7 @@ def test_no_config_data(system_info, model_obj):
8686

8787
def test_invalid_kernel(system_info, model_obj, config):
8888
args = KernelAnalyzerArgs(exp_kernel=config["kernel_name"])
89-
model_obj.kernel_version = "some_invalid"
89+
model_obj.kernel_info = "some_invalid"
9090

9191
analyzer = KernelAnalyzer(system_info)
9292
result = analyzer.analyze_data(model_obj, args=args)

0 commit comments

Comments
 (0)