added build_from_model for MemoryPlugin, to overwrite upper bound with --gen-plugin-config

Author: alexandraBara

nodescraper/plugins/inband/memory/analyzer_args.py

@@ -25,7 +25,21 @@
 ###############################################################################
 from nodescraper.models.analyzerargs import AnalyzerArgs
 
+from .memorydata import MemoryDataModel
+
 
 class MemoryAnalyzerArgs(AnalyzerArgs):
     ratio: float = 0.66
     memory_threshold: str = "30Gi"
+
+    @classmethod
+    def build_from_model(cls, datamodel: MemoryDataModel) -> "MemoryAnalyzerArgs":
+        """build analyzer args from data model
+
+        Args:
+            datamodel (MemoryDataModel): data model for plugin
+
+        Returns:
+            MemoryAnalyzerArgs: instance of analyzer args class
+        """
+        return cls(memory_threshold=datamodel.mem_total)

nodescraper/plugins/inband/memory/memory_plugin.py

@@ -39,3 +39,5 @@ class MemoryPlugin(InBandDataPlugin[MemoryDataModel, None, MemoryAnalyzerArgs]):
     COLLECTOR = MemoryCollector
 
     ANALYZER = MemoryAnalyzer
+
+    ANALYZER_ARGS = MemoryAnalyzerArgs

test/functional/test_reference_config_workflow.py

@@ -234,6 +234,7 @@ def test_reference_config_with_analysis_args(run_cli_command, tmp_path):
         "DkmsPlugin",
         "KernelPlugin",
         "KernelModulePlugin",
+        "MemoryPlugin",
         "OsPlugin",
         "PackagePlugin",
         "ProcessPlugin",

test/unit/plugin/test_analyzer_args_build_from_model.py

@@ -48,6 +48,8 @@
 from nodescraper.plugins.inband.kernel_module.kernel_module_data import (
     KernelModuleDataModel,
 )
+from nodescraper.plugins.inband.memory.analyzer_args import MemoryAnalyzerArgs
+from nodescraper.plugins.inband.memory.memorydata import MemoryDataModel
 from nodescraper.plugins.inband.os.analyzer_args import OsAnalyzerArgs
 from nodescraper.plugins.inband.os.osdata import OsDataModel
 from nodescraper.plugins.inband.package.analyzer_args import PackageAnalyzerArgs
@@ -207,3 +209,12 @@ def test_kernel_module_analyzer_args_build_from_model():
     assert "amd_iommu" in args.kernel_modules
     assert "other_module" not in args.kernel_modules
     assert args.regex_filter == []
+
+
+def test_memory_analyzer_args_build_from_model():
+    """Test MemoryAnalyzerArgs.build_from_model includes all fields"""
+    datamodel = MemoryDataModel(mem_free="128Gi", mem_total="256Gi")
+    args = MemoryAnalyzerArgs.build_from_model(datamodel)
+
+    assert isinstance(args, MemoryAnalyzerArgs)
+    assert args.memory_threshold == "256Gi"